From dd3328a4c4e0884d1b5d70504c089fee06c5b0ae Mon Sep 17 00:00:00 2001 From: mabofu Date: Thu, 27 Mar 2025 19:11:06 +0800 Subject: [PATCH] Fixed sonar issue: fixed StoragePoolImpl issue --- .../storagepool/service/impl/StoragePoolImpl.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/dsms-engine-application/src/main/java/com/dsms/modules/storagepool/service/impl/StoragePoolImpl.java b/dsms-engine-application/src/main/java/com/dsms/modules/storagepool/service/impl/StoragePoolImpl.java index 6972073..d448bf7 100644 --- a/dsms-engine-application/src/main/java/com/dsms/modules/storagepool/service/impl/StoragePoolImpl.java +++ b/dsms-engine-application/src/main/java/com/dsms/modules/storagepool/service/impl/StoragePoolImpl.java @@ -91,6 +91,7 @@ public class StoragePoolImpl implements IStoragePoolService { private static final String NOT_ALLOWED_REMOVE_OSD_REASON = "存储池需要冗余模式数量的节点磁盘对数据进行平衡和备份，移除磁盘操作可能会导致存储池不可用和数据丢失，请通过删除存储池或添加大于冗余模式数量磁盘的方式移除磁盘"; private static final String TASK_ALREADY_EXIST = "Task already exist,task message: {}"; private static final String TASK_CREATE_FAILED = "Task create failed exist,task message: {}"; + private static final String NOT_BE_EMPTY = "storagePoolNodeManageDto can not be empty"; StoragePoolApi storagePoolApi; @@ -525,7 +526,7 @@ public class StoragePoolImpl implements IStoragePoolService { @Override public boolean addNode(StoragePoolNodeManageDTO storagePoolNodeManageDto) { if (ObjectUtils.isEmpty(storagePoolNodeManageDto)) { - log.error("storagePoolNodeManageDto can not be empty"); + log.error(NOT_BE_EMPTY); return false; } @@ -554,7 +555,7 @@ public class StoragePoolImpl implements IStoragePoolService { @Override public boolean removeNode(StoragePoolNodeManageDTO storagePoolNodeManageDto) { if (ObjectUtils.isEmpty(storagePoolNodeManageDto)) { - log.error("storagePoolNodeManageDto can not be empty"); + log.error(NOT_BE_EMPTY); return false; } @@ -582,7 +583,7 @@ public class StoragePoolImpl implements IStoragePoolService { @Override public boolean addDisk(StoragePoolDiskManageDTO storagePoolDiskManageDto) { if (ObjectUtils.isEmpty(storagePoolDiskManageDto)) { - log.error("storagePoolNodeManageDto can not be empty"); + log.error(NOT_BE_EMPTY); return false; } @@ -626,7 +627,7 @@ public class StoragePoolImpl implements IStoragePoolService { @Override public boolean removeDisk(StoragePoolDiskManageDTO storagePoolDiskManageDto) { if (ObjectUtils.isEmpty(storagePoolDiskManageDto)) { - log.error("storagePoolNodeManageDto can not be empty"); + log.error(NOT_BE_EMPTY); return false; } validateRemoveOsd(storagePoolDiskManageDto); -- Gitee