diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c index 0551fed9a6d3c886351ee29b516bc075491d55fb..fa31a4b45e9b0d16e322e3f1f471f612cff1466f 100644 --- a/net/ipv4/inet_connection_sock.c +++ b/net/ipv4/inet_connection_sock.c @@ -927,11 +927,25 @@ static int inet_ulp_can_listen(const struct sock *sk) return 0; } +static int inet_ulp_can_listen(const struct sock *sk) +{ + const struct inet_connection_sock *icsk = inet_csk(sk); + + if (icsk->icsk_ulp_ops && !icsk->icsk_ulp_ops->clone) + return -EINVAL; + + return 0; +} + int inet_csk_listen_start(struct sock *sk, int backlog) { struct inet_connection_sock *icsk = inet_csk(sk); struct inet_sock *inet = inet_sk(sk); - int err = -EADDRINUSE; + int err; + + err = inet_ulp_can_listen(sk); + if (unlikely(err)) + return err; err = inet_ulp_can_listen(sk); if (unlikely(err)) diff --git a/net/ipv4/tcp_ulp.c b/net/ipv4/tcp_ulp.c index 8e135af0d4f701cffa028ae4c63bc80cdd52dfdd..fd6a006bfd717d537e4df5e7503719c3d1589499 100644 --- a/net/ipv4/tcp_ulp.c +++ b/net/ipv4/tcp_ulp.c @@ -140,6 +140,10 @@ static int __tcp_set_ulp(struct sock *sk, const struct tcp_ulp_ops *ulp_ops) if (!ulp_ops->clone && sk->sk_state == TCP_LISTEN) goto out_err; + err = -EINVAL; + if (!ulp_ops->clone && sk->sk_state == TCP_LISTEN) + goto out_err; + err = ulp_ops->init(sk); if (err) goto out_err;