From 0897c7b0274b376483878ab6623799138b1828af Mon Sep 17 00:00:00 2001 From: fanglanyue Date: Tue, 19 Aug 2025 20:21:42 +0800 Subject: [PATCH] ExcelView resource safety --- .../compare_tools/compare_backend/view/excel_view.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/profiler/msprof_analyze/compare_tools/compare_backend/view/excel_view.py b/profiler/msprof_analyze/compare_tools/compare_backend/view/excel_view.py index 8e35bc84e..57f2803e9 100644 --- a/profiler/msprof_analyze/compare_tools/compare_backend/view/excel_view.py +++ b/profiler/msprof_analyze/compare_tools/compare_backend/view/excel_view.py @@ -29,9 +29,8 @@ class ExcelView(BaseView): self._args = args def generate_view(self): - workbook = Workbook(self._file_path) - for sheet_name, data in self._data_dict.items(): - WorkSheetCreator(workbook, sheet_name, data, self._args).create_sheet() - workbook.close() + with Workbook(self._file_path) as workbook: + for sheet_name, data in self._data_dict.items(): + WorkSheetCreator(workbook, sheet_name, data, self._args).create_sheet() os.chmod(self._file_path, Constant.FILE_AUTHORITY) -- Gitee