From 3129f7bd7a9ad61e497b5fd66e895ee7e4eeeaf8 Mon Sep 17 00:00:00 2001 From: Jeremyzz Date: Fri, 2 Jun 2023 14:45:03 +0800 Subject: [PATCH 1/2] fix memory problem Signed-off-by: Jeremyzz --- .../data_share/gaussdb_rd/src/interface/src/document_key.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/distributeddataservice/service/data_share/gaussdb_rd/src/interface/src/document_key.cpp b/services/distributeddataservice/service/data_share/gaussdb_rd/src/interface/src/document_key.cpp index a54ca478..5c75bf1a 100644 --- a/services/distributeddataservice/service/data_share/gaussdb_rd/src/interface/src/document_key.cpp +++ b/services/distributeddataservice/service/data_share/gaussdb_rd/src/interface/src/document_key.cpp @@ -39,7 +39,7 @@ static int InitDocIdFromOid(DocKey &docKey) return -E_INNER_ERROR; } docKey.key = idTemp; - delete idTemp; + delete[] idTemp; return E_OK; } -- Gitee From 43e4b344d07a86b35a394b8877c5a267c198edbb Mon Sep 17 00:00:00 2001 From: Jeremyzz Date: Fri, 2 Jun 2023 14:52:31 +0800 Subject: [PATCH 2/2] add ut Signed-off-by: Jeremyzz --- .../gaussdb_rd/test/unittest/api/documentdb_insert_test.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/services/distributeddataservice/service/data_share/gaussdb_rd/test/unittest/api/documentdb_insert_test.cpp b/services/distributeddataservice/service/data_share/gaussdb_rd/test/unittest/api/documentdb_insert_test.cpp index c3ad96cb..385470b2 100644 --- a/services/distributeddataservice/service/data_share/gaussdb_rd/test/unittest/api/documentdb_insert_test.cpp +++ b/services/distributeddataservice/service/data_share/gaussdb_rd/test/unittest/api/documentdb_insert_test.cpp @@ -826,4 +826,10 @@ HWTEST_F(DocumentDBInsertTest, DocumentDBInsertTest046, TestSize.Level1) const char *document1 = R""({})""; EXPECT_EQ(GRD_InsertDoc(g_db, RIGHT_COLLECTION_NAME, document1, 0), GRD_OK); } + +HWTEST_F(DocumentDBInsertTest, DocumentDBInsertTest047, TestSize.Level1) +{ + const char *document1 = R""({"empty" : null})""; + EXPECT_EQ(GRD_InsertDoc(g_db, RIGHT_COLLECTION_NAME, document1, 0), GRD_OK); +} } // namespace -- Gitee