From ccc4e7b52da2deafe7ad1e8c53e10541ca4dc4b8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?tianxiang=20bao=20=EF=BC=88=E5=8C=85=E5=A4=A9=E7=A5=A5?=
 =?UTF-8?q?=EF=BC=89?= <txbao@trip.com>
Date: Tue, 2 Jul 2024 11:03:16 +0800
Subject: [PATCH] =?UTF-8?q?=E6=81=A2=E5=A4=8D=E5=8E=9F=E6=9C=89=E4=BB=A3?=
 =?UTF-8?q?=E7=A0=81?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../monitor/collector/jmx/JMXCollector.java   | 29 ++++++++++++++-----
 1 file changed, 22 insertions(+), 7 deletions(-)

diff --git a/core/src/main/java/org/dromara/dynamictp/core/monitor/collector/jmx/JMXCollector.java b/core/src/main/java/org/dromara/dynamictp/core/monitor/collector/jmx/JMXCollector.java
index 366aab46..a3e59afc 100644
--- a/core/src/main/java/org/dromara/dynamictp/core/monitor/collector/jmx/JMXCollector.java
+++ b/core/src/main/java/org/dromara/dynamictp/core/monitor/collector/jmx/JMXCollector.java
@@ -21,11 +21,14 @@ import lombok.extern.slf4j.Slf4j;
 import org.dromara.dynamictp.common.em.CollectorTypeEnum;
 import org.dromara.dynamictp.common.entity.ThreadPoolStats;
 import org.dromara.dynamictp.core.monitor.collector.AbstractCollector;
+import org.springframework.beans.BeanUtils;
 
 import javax.management.JMException;
 import javax.management.MBeanServer;
 import javax.management.ObjectName;
 import java.lang.management.ManagementFactory;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
 
 /**
  * ThreadPoolStatsInfo related
@@ -37,15 +40,27 @@ public class JMXCollector extends AbstractCollector {
 
     public static final String DTP_METRIC_NAME_PREFIX = "dtp.thread.pool";
 
+    /**
+     * thread pool stats map
+     * 缓存的作用是将注册到JMX的数据，每次都是同一个对象
+     */
+    private static final Map<String, ThreadPoolStats> GAUGE_CACHE = new ConcurrentHashMap<>();
+
     @Override
     public void collect(ThreadPoolStats threadPoolStats) {
-        try {
-            MBeanServer server = ManagementFactory.getPlatformMBeanServer();
-            ObjectName name = new ObjectName(DTP_METRIC_NAME_PREFIX + ":name=" + threadPoolStats.getPoolName());
-            ThreadPoolStatsJMX stats = new ThreadPoolStatsJMX(threadPoolStats);
-            server.registerMBean(stats, name);
-        } catch (JMException e) {
-            log.error("collect thread pool stats error", e);
+        if (GAUGE_CACHE.containsKey(threadPoolStats.getPoolName())) {
+            ThreadPoolStats poolStats = GAUGE_CACHE.get(threadPoolStats.getPoolName());
+            BeanUtils.copyProperties(threadPoolStats, poolStats);
+        } else {
+            try {
+                MBeanServer server = ManagementFactory.getPlatformMBeanServer();
+                ObjectName name = new ObjectName(DTP_METRIC_NAME_PREFIX + ":name=" + threadPoolStats.getPoolName());
+                ThreadPoolStatsJMX stats = new ThreadPoolStatsJMX(threadPoolStats);
+                server.registerMBean(stats, name);
+            } catch (JMException e) {
+                log.error("collect thread pool stats error", e);
+            }
+            GAUGE_CACHE.put(threadPoolStats.getPoolName(), threadPoolStats);
         }
     }
 
-- 
Gitee