From ec20037908963870e27572fadef766cc8a6d9818 Mon Sep 17 00:00:00 2001
From: Kenny Levinsen <kl@kl.wtf>
Date: Tue, 12 Nov 2024 10:39:49 +0100
Subject: [PATCH] Unlock on allocation failure in FcCacheInsert

If an allocation error occurred during FcCacheInsert, the function would
return without unlocking the cache lock, deadlocking all future
interactions with the cache.

Unlock the cache on allocation failure.
---
 src/fccache.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/fccache.c b/src/fccache.c
index e74dada6..f5c41aeb 100644
--- a/src/fccache.c
+++ b/src/fccache.c
@@ -586,7 +586,10 @@ FcCacheInsert (FcCache *cache, struct stat *cache_stat)
 
     s = malloc (sizeof (FcCacheSkip) + (level - 1) * sizeof (FcCacheSkip *));
     if (!s)
+    {
+	unlock_cache ();
 	return FcFalse;
+    }
 
     s->cache = cache;
     s->size = cache->size;
-- 
GitLab