登录
注册
开源
企业版
高校版
搜索
帮助中心
使用条款
关于我们
开源
企业版
高校版
私有云
模力方舟
登录
注册
代码拉取完成,页面将自动刷新
捐赠
捐赠前请先登录
取消
前往登录
扫描微信二维码支付
取消
支付完成
支付提示
将跳转至支付宝完成支付
确定
取消
Watch
不关注
关注所有动态
仅关注版本发行动态
关注但不提醒动态
118
Star
1
Fork
39
src-openEuler
/
haproxy
代码
Issues
0
Pull Requests
3
Wiki
统计
流水线
服务
JavaDoc
PHPDoc
质量分析
Jenkins for Gitee
腾讯云托管
腾讯云 Serverless
悬镜安全
阿里云 SAE
Codeblitz
SBOM
我知道了,不再自动展开
更新失败,请稍后重试!
移除标识
内容风险标识
本任务被
标识为内容中包含有代码安全 Bug 、隐私泄露等敏感信息,仓库外成员不可访问
haproxy运行过程时间发生跳变时,通过curl IPv6 IP访问异常会报错“connection reset by peer”
已完成
#IASH43
缺陷
peulerosci
创建于
2024-09-20 14:58
<h3>【测试步骤】:详细描述可以复现该问题的测试步骤</h3><p>1、haproxy服务配置需增加:tcp-request connection reject if { fe_sess_rate gt 100 },<span style="color:#000000"><span style="font-size:16px"><span style="background-color:#ffffff">启动haproxy服务</span></span></span></p><p>2、执行时间跳变脚本:</p><pre data-lang="c" class="lang-c"><code class="lang-c">while :; do<br/> sleep 1<br/> date -s '30year'<br/> sleep 1<br/> date -s '-30year'<br/> sleep 1<br/> date -s '30day'<br/> sleep 1<br/> date -s '-30day'<br/> sleep 1<br/> date -s '30hour'<br/> sleep 1<br/> date -s '-30hour'<br/> sleep 1<br/> date -s '30min'<br/> sleep 1<br/> date -s '-30min'<br/> sleep 1<br/> date -s '30sec'<br/> sleep 1<br/> date -s '-30sec'<br/>done</code></pre><p>2、wrk打流</p><p><span style="color:#000000"> wrk -c </span><span style="color:#098658">1000</span><span style="color:#000000"> -d </span><span style="color:#098658">1000000</span><span style="color:#000000"> https://</span><span style="color:#001188">${ipv4}</span><span style="color:#000000"> &</span><br/><span style="color:#000000"> wrk -c </span><span style="color:#098658">1000</span><span style="color:#000000"> -d </span><span style="color:#098658">1000000</span><span style="color:#000000"> https://[</span><span style="color:#001188">${ipv6}</span><span style="color:#000000">] &</span></p><p>3、curl访问haproxy服务配置的监听ip</p><p><span style="color:#000000">curl -k https://</span><span style="color:#001188">${ipv4}</span></p><p><span style="color:#000000">curl -k https://[</span><span style="color:#001188">${ipv6}</span><span style="color:#000000">]</span></p><p> 【结果输出】:根据上述测试步骤执行后,系统的实际输出</p><pre data-lang="bash" class="lang-bash"><code class="lang-bash"># curl -k https://xx.xx.xx.xx<br/>curl: (35) OpenSSL SSL_connect: Connection reset by peer in connection to xx.xx.xx.xx:443</code></pre><p> 【预期输出】:系统在上述测试步骤操作后,按照系统设计应该输出的结果</p><p></p><p>不返回curl错误码,curl访问正常</p><p></p><h3>原因分析:</h3><p>社区对于haproxy的限速计算方式存在异常,对于时间跨越过大场景,会导致速率跳跃式变大,导致一直触发haproxy的限速机制,社区暂无解决方案,自研补丁解决</p><p>https://github.com/haproxy/haproxy/issues/2704</p><p></p><p>在haproxy的会话处理流程中,会在每轮会话开始时刷新全局时间,在会话过程中进行流量统计与规则匹配,最后在会话完成以后进行curr_tick值的刷新。</p><p>src/freq_ctr.c</p><pre data-lang="c" class="lang-c"><code class="lang-c"> remain = tick + period - HA_ATOMIC_LOAD(&global_now_ms);<br/> if (unlikely(remain < 0)) {<br/> /* We're past the first period, check if we can still report a<br/> * part of last period or if we're too far away.<br/> */<br/> remain += period;<br/> past = (remain >= 0) ? curr : 0;<br/> curr = 0;<br/> }<br/><br/> if (pend < 0) {<br/> /* enable flapping correction at very low rates */<br/> pend = 0;<br/> if (!curr && past <= 1)<br/> return past * period;<br/> }<br/><br/> /* compute the total number of confirmed events over the period */<br/> return past * remain + (curr + pend) * period;<br/></code></pre><p>其中remain为int类型,curr_tick与global_now_ms为unsigned int类型,单位均为毫秒ms</p><p>int类型正数上限可以表示的最大值换算为天数为24.8天,最小值为 -24.9天 ,uint类型最大值换算成天数为49.7天</p><p>现在考虑如下异常情况:</p><p>在上一次会话过后30天,第二次会话到来,此时curr_tick - global_now_ms 为 -30天,超过int类型负数下限,此时会发生整形下溢出翻转,导致remain值变为超大数,从而导致计算出超大速率值,进而导致规则匹配失败,会话被误限流,而异常退出以后curr_tick值不会更新,于是问题无法自愈</p><p></p><p>自研方案:通过curr_tick与global_now_ms的绝对值,与时间周期period进行比较,符合社区原本设计意图</p><p></p><p>自研补丁如下:fix-timehopping-in-freq_ctr_total.patch</p><pre data-lang="c" class="lang-c"><code class="lang-c">From 638b8b2fe4163a85815424549a629a6c9b113d1d Mon Sep 17 00:00:00 2001<br/>From: zhongxuan <zhongxuan2@huawei.com><br/>Date: Fri, 6 Sep 2024 18:42:49 +0800<br/>Subject: [PATCH] fix timehopping in freq_ctr_total<br/> <br/>---<br/> src/freq_ctr.c | 10 ++++++++--<br/> 1 file changed, 8 insertions(+), 2 deletions(-)<br/> <br/>diff --git a/src/freq_ctr.c b/src/freq_ctr.c<br/>index 54aa78f..66397a0 100644<br/>--- a/src/freq_ctr.c<br/>+++ b/src/freq_ctr.c<br/>@@ -28,6 +28,7 @@ ullong freq_ctr_total(const struct freq_ctr *ctr, uint period, int pend)<br/> {<br/> ullong curr, past, old_curr, old_past;<br/> uint tick, old_tick;<br/>+ uint toofar = 0;<br/> int remain;<br/> <br/> tick = HA_ATOMIC_LOAD(&ctr->curr_tick);<br/>@@ -75,13 +76,18 @@ ullong freq_ctr_total(const struct freq_ctr *ctr, uint period, int pend)<br/> __ha_cpu_relax();<br/> };<br/> <br/>+ if (((tick + 2 * period) < HA_ATOMIC_LOAD(&global_now_ms)) || ((HA_ATOMIC_LOAD(&global_now_ms) + 2 * period) < tick))<br/>+ toofar = 2;<br/>+ else if (((tick + period) < HA_ATOMIC_LOAD(&global_now_ms)) || ((HA_ATOMIC_LOAD(&global_now_ms) + period) < tick))<br/>+ toofar = 1;<br/>+<br/> remain = tick + period - HA_ATOMIC_LOAD(&global_now_ms);<br/>- if (unlikely(remain < 0)) {<br/>+ if (unlikely(remain < 0 || toofar)) {<br/> /* We're past the first period, check if we can still report a<br/> * part of last period or if we're too far away.<br/> */<br/> remain += period;<br/>- past = (remain >= 0) ? curr : 0;<br/>+ past = (toofar != 2) ? curr : 0;<br/> curr = 0;<br/> }<br/> <br/>-- <br/>2.33.0</code></pre><p></p>
<h3>【测试步骤】:详细描述可以复现该问题的测试步骤</h3><p>1、haproxy服务配置需增加:tcp-request connection reject if { fe_sess_rate gt 100 },<span style="color:#000000"><span style="font-size:16px"><span style="background-color:#ffffff">启动haproxy服务</span></span></span></p><p>2、执行时间跳变脚本:</p><pre data-lang="c" class="lang-c"><code class="lang-c">while :; do<br/> sleep 1<br/> date -s '30year'<br/> sleep 1<br/> date -s '-30year'<br/> sleep 1<br/> date -s '30day'<br/> sleep 1<br/> date -s '-30day'<br/> sleep 1<br/> date -s '30hour'<br/> sleep 1<br/> date -s '-30hour'<br/> sleep 1<br/> date -s '30min'<br/> sleep 1<br/> date -s '-30min'<br/> sleep 1<br/> date -s '30sec'<br/> sleep 1<br/> date -s '-30sec'<br/>done</code></pre><p>2、wrk打流</p><p><span style="color:#000000"> wrk -c </span><span style="color:#098658">1000</span><span style="color:#000000"> -d </span><span style="color:#098658">1000000</span><span style="color:#000000"> https://</span><span style="color:#001188">${ipv4}</span><span style="color:#000000"> &</span><br/><span style="color:#000000"> wrk -c </span><span style="color:#098658">1000</span><span style="color:#000000"> -d </span><span style="color:#098658">1000000</span><span style="color:#000000"> https://[</span><span style="color:#001188">${ipv6}</span><span style="color:#000000">] &</span></p><p>3、curl访问haproxy服务配置的监听ip</p><p><span style="color:#000000">curl -k https://</span><span style="color:#001188">${ipv4}</span></p><p><span style="color:#000000">curl -k https://[</span><span style="color:#001188">${ipv6}</span><span style="color:#000000">]</span></p><p> 【结果输出】:根据上述测试步骤执行后,系统的实际输出</p><pre data-lang="bash" class="lang-bash"><code class="lang-bash"># curl -k https://xx.xx.xx.xx<br/>curl: (35) OpenSSL SSL_connect: Connection reset by peer in connection to xx.xx.xx.xx:443</code></pre><p> 【预期输出】:系统在上述测试步骤操作后,按照系统设计应该输出的结果</p><p></p><p>不返回curl错误码,curl访问正常</p><p></p><h3>原因分析:</h3><p>社区对于haproxy的限速计算方式存在异常,对于时间跨越过大场景,会导致速率跳跃式变大,导致一直触发haproxy的限速机制,社区暂无解决方案,自研补丁解决</p><p>https://github.com/haproxy/haproxy/issues/2704</p><p></p><p>在haproxy的会话处理流程中,会在每轮会话开始时刷新全局时间,在会话过程中进行流量统计与规则匹配,最后在会话完成以后进行curr_tick值的刷新。</p><p>src/freq_ctr.c</p><pre data-lang="c" class="lang-c"><code class="lang-c"> remain = tick + period - HA_ATOMIC_LOAD(&global_now_ms);<br/> if (unlikely(remain < 0)) {<br/> /* We're past the first period, check if we can still report a<br/> * part of last period or if we're too far away.<br/> */<br/> remain += period;<br/> past = (remain >= 0) ? curr : 0;<br/> curr = 0;<br/> }<br/><br/> if (pend < 0) {<br/> /* enable flapping correction at very low rates */<br/> pend = 0;<br/> if (!curr && past <= 1)<br/> return past * period;<br/> }<br/><br/> /* compute the total number of confirmed events over the period */<br/> return past * remain + (curr + pend) * period;<br/></code></pre><p>其中remain为int类型,curr_tick与global_now_ms为unsigned int类型,单位均为毫秒ms</p><p>int类型正数上限可以表示的最大值换算为天数为24.8天,最小值为 -24.9天 ,uint类型最大值换算成天数为49.7天</p><p>现在考虑如下异常情况:</p><p>在上一次会话过后30天,第二次会话到来,此时curr_tick - global_now_ms 为 -30天,超过int类型负数下限,此时会发生整形下溢出翻转,导致remain值变为超大数,从而导致计算出超大速率值,进而导致规则匹配失败,会话被误限流,而异常退出以后curr_tick值不会更新,于是问题无法自愈</p><p></p><p>自研方案:通过curr_tick与global_now_ms的绝对值,与时间周期period进行比较,符合社区原本设计意图</p><p></p><p>自研补丁如下:fix-timehopping-in-freq_ctr_total.patch</p><pre data-lang="c" class="lang-c"><code class="lang-c">From 638b8b2fe4163a85815424549a629a6c9b113d1d Mon Sep 17 00:00:00 2001<br/>From: zhongxuan <zhongxuan2@huawei.com><br/>Date: Fri, 6 Sep 2024 18:42:49 +0800<br/>Subject: [PATCH] fix timehopping in freq_ctr_total<br/> <br/>---<br/> src/freq_ctr.c | 10 ++++++++--<br/> 1 file changed, 8 insertions(+), 2 deletions(-)<br/> <br/>diff --git a/src/freq_ctr.c b/src/freq_ctr.c<br/>index 54aa78f..66397a0 100644<br/>--- a/src/freq_ctr.c<br/>+++ b/src/freq_ctr.c<br/>@@ -28,6 +28,7 @@ ullong freq_ctr_total(const struct freq_ctr *ctr, uint period, int pend)<br/> {<br/> ullong curr, past, old_curr, old_past;<br/> uint tick, old_tick;<br/>+ uint toofar = 0;<br/> int remain;<br/> <br/> tick = HA_ATOMIC_LOAD(&ctr->curr_tick);<br/>@@ -75,13 +76,18 @@ ullong freq_ctr_total(const struct freq_ctr *ctr, uint period, int pend)<br/> __ha_cpu_relax();<br/> };<br/> <br/>+ if (((tick + 2 * period) < HA_ATOMIC_LOAD(&global_now_ms)) || ((HA_ATOMIC_LOAD(&global_now_ms) + 2 * period) < tick))<br/>+ toofar = 2;<br/>+ else if (((tick + period) < HA_ATOMIC_LOAD(&global_now_ms)) || ((HA_ATOMIC_LOAD(&global_now_ms) + period) < tick))<br/>+ toofar = 1;<br/>+<br/> remain = tick + period - HA_ATOMIC_LOAD(&global_now_ms);<br/>- if (unlikely(remain < 0)) {<br/>+ if (unlikely(remain < 0 || toofar)) {<br/> /* We're past the first period, check if we can still report a<br/> * part of last period or if we're too far away.<br/> */<br/> remain += period;<br/>- past = (remain >= 0) ? curr : 0;<br/>+ past = (toofar != 2) ? curr : 0;<br/> curr = 0;<br/> }<br/> <br/>-- <br/>2.33.0</code></pre><p></p>
评论 (
1
)
登录
后才可以发表评论
状态
已完成
待办的
已挂起
修复中
已确认
已完成
已验收
已取消
负责人
未设置
标签
sig/System-tool
未设置
项目
未立项任务
未立项任务
里程碑
未关联里程碑
未关联里程碑
Pull Requests
未关联
未关联
关联的 Pull Requests 被合并后可能会关闭此 issue
分支
未关联
分支 (27)
标签 (39)
master
openEuler-24.03-LTS-Next
openEuler-24.03-LTS-SP1
openEuler-24.03-LTS-SP2
openEuler-24.03-LTS
openEuler-22.03-LTS-SP3
openEuler-22.03-LTS-SP4
openEuler-20.03-LTS-SP4
openEuler-25.09
openEuler-25.03
openEuler-22.03-LTS-SP1
openEuler-24.09
openEuler-22.03-LTS-Next
openEuler-22.03-LTS-SP2
openEuler-22.03-LTS
openEuler-20.03-LTS-SP3
openEuler-20.03-LTS-SP1
openEuler-23.09
openEuler-23.03
openEuler-22.09
openEuler-20.03-LTS-SP2
openEuler-21.09
openEuler-21.03
openEuler-20.03-LTS-Next
openEuler-20.03-LTS
openEuler-20.09
revert-merge-5-openEuler-20.03-LTS
openEuler-25.09-release
openEuler-24.03-LTS-SP2-release
openEuler-24.03-LTS-SP1-update-20250509
openEuler-24.03-LTS-update-20250509
openEuler-22.03-LTS-SP4-update-20250509
openEuler-22.03-LTS-SP3-update-20250509
openEuler-20.03-LTS-SP4-update-20250509
openEuler-25.03-release
openEuler-22.03-LTS-SP4-update-20250329
openEuler-22.03-LTS-SP3-update-20250329
openEuler-24.03-LTS-SP1-update-20250329
openEuler-24.03-LTS-update-20250329
openEuler-24.03-LTS-SP1-release
openEuler-24.03-LTS-update-20241213
openEuler-22.03-LTS-SP4-update-20241213
openEuler-22.03-LTS-SP3-update-20241213
openEuler-22.03-LTS-SP1-update-20241213
openEuler-22.03-LTS-SP4-update-before-20241025
openEuler-24.03-LTS-update-20241018
openEuler-22.03-LTS-SP4-release
openEuler-24.09-release
openEuler-24.03-LTS-release
openEuler-22.03-LTS-SP3-release
openEuler-23.09-rc5
openEuler-22.03-LTS-SP1-release
openEuler-22.09-release
openEuler-22.09-rc5
openEuler-22.09-20220829
openEuler-22.03-LTS-20220331
openEuler-22.03-LTS-round5
openEuler-22.03-LTS-round3
openEuler-22.03-LTS-round2
openEuler-22.03-LTS-round1
openEuler-20.03-LTS-SP3-release
openEuler-20.03-LTS-SP2-20210624
openEuler-21.03-20210330
openEuler-20.09-20200928
openEuler-20.03-LTS-20200606
openEuler-20.03-LTS-tag
开始日期   -   截止日期
-
置顶选项
不置顶
置顶等级:高
置顶等级:中
置顶等级:低
优先级
不指定
严重
主要
次要
不重要
预计工期
(小时)
参与者(1)
1
https://gitee.com/src-openeuler/haproxy.git
git@gitee.com:src-openeuler/haproxy.git
src-openeuler
haproxy
haproxy
点此查找更多帮助
搜索帮助
Git 命令在线学习
如何在 Gitee 导入 GitHub 仓库
Git 仓库基础操作
企业版和社区版功能对比
SSH 公钥设置
如何处理代码冲突
仓库体积过大,如何减小?
如何找回被删除的仓库数据
Gitee 产品配额说明
GitHub仓库快速导入Gitee及同步更新
什么是 Release(发行版)
将 PHP 项目自动发布到 packagist.org
仓库举报
回到顶部
登录提示
该操作需登录 Gitee 帐号,请先登录后再操作。
立即登录
没有帐号,去注册