From 170874040acb7c05f5ead3c11e9ed591ba71fac5 Mon Sep 17 00:00:00 2001 From: miravity111 Date: Wed, 10 May 2023 03:13:58 +0000 Subject: [PATCH] drivers: fix a nullptr bug in smu8_start_smu() drivers inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I71TCN CVE: NA Reference: N/A ---------------------------------------------------------------- pointer 'hwmgr' could be a nullptr, so it should be checked first before it is accessed. Signed-off-by: miravity111 --- drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c index f7e3bc22bb93..884f60c28cf7 100644 --- a/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c +++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c @@ -698,7 +698,7 @@ static int smu8_start_smu(struct pp_hwmgr *hwmgr) { int ret = 0; uint32_t fw_to_check = 0; - struct amdgpu_device *adev = hwmgr->adev; + struct amdgpu_device *adev; uint32_t index = SMN_MP1_SRAM_START_ADDR + SMU8_FIRMWARE_HEADER_LOCATION + @@ -707,6 +707,8 @@ static int smu8_start_smu(struct pp_hwmgr *hwmgr) if (hwmgr == NULL || hwmgr->device == NULL) return -EINVAL; + else + adev = hwmgr->adev; cgs_write_register(hwmgr->device, mmMP0PUB_IND_INDEX, index); hwmgr->smu_version = cgs_read_register(hwmgr->device, mmMP0PUB_IND_DATA); -- Gitee