From 6a48614c836af8616ca9ef307e2783a03f10f28d Mon Sep 17 00:00:00 2001 From: dinglimin Date: Sat, 14 Jun 2025 16:16:10 +0800 Subject: [PATCH] pc-bios: ensure installed ROMs don't have execute permissions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We have been inconsistent about whether ROMS stored in git have execute permission set, and by default meson will preserve source file permissions when installing files. This has caused periodic problems in RPM packaging as executable binary files get analysed by various tools/linters, which can trip up on the ROMs. Tell meson explicitly that all the ROMs should be without execute permission when installed. Signed-off-by: Daniel P. Berrangé Reviewed-by: Helge Deller Tested-by: Helge Deller Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20250530152118.65030-1-berrange@redhat.com> Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: dinglimin --- pc-bios/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/meson.build b/pc-bios/meson.build index e67fa433a1..b158a95041 100644 --- a/pc-bios/meson.build +++ b/pc-bios/meson.build @@ -102,7 +102,7 @@ foreach f : [ endforeach if get_option('install_blobs') - install_data(blobs, install_dir: qemu_datadir) + install_data(blobs, install_dir: qemu_datadir, install_mode: 'rw-r--r--') endif subdir('descriptors') -- Gitee