From 2ef6af224c566c3729b404c36ed7c4094c9c1aa1 Mon Sep 17 00:00:00 2001 From: guping Date: Thu, 21 Aug 2025 07:27:46 +0000 Subject: [PATCH] block/stream: fix -Werror=maybe-uninitialized false-positives cherry-pick from ce2a0ef65c3bb857985cd4b9c1f2145c81f2cdec MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ../block/stream.c:193:19: error: ‘unfiltered_bs’ may be used uninitialized [-Werror=maybe-uninitialized] ../block/stream.c:176:5: error: ‘len’ may be used uninitialized [-Werror=maybe-uninitialized] trace/trace-block.h:906:9: error: ‘ret’ may be used uninitialized [-Werror=maybe-uninitialized] Signed-off-by: Marc-André Lureau Acked-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Manos Pitsidianakis Signed-off-by: guping --- block/stream.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/stream.c b/block/stream.c index 01fe7c0f16..b6705c62f2 100644 --- a/block/stream.c +++ b/block/stream.c @@ -149,8 +149,8 @@ static void stream_clean(Job *job) static int coroutine_fn stream_run(Job *job, Error **errp) { StreamBlockJob *s = container_of(job, StreamBlockJob, common.job); - BlockDriverState *unfiltered_bs; - int64_t len; + BlockDriverState *unfiltered_bs = NULL; + int64_t len = 0; int64_t offset = 0; int error = 0; int64_t n = 0; /* bytes */ @@ -171,7 +171,7 @@ static int coroutine_fn stream_run(Job *job, Error **errp) for ( ; offset < len; offset += n) { bool copy; - int ret; + int ret = -1; /* Note that even when no rate limit is applied we need to yield * with no pending I/O here so that bdrv_drain_all() returns. -- Gitee