From 334787a0350778147c47a29680162b7a9142a99a Mon Sep 17 00:00:00 2001 From: Korobeinikov Evgeny Date: Wed, 12 Feb 2025 15:24:35 +0300 Subject: [PATCH 1/2] Using interop-fatal in convertors-napi --- interop/src/cpp/napi/convertors-napi.cc | 2 +- interop/src/cpp/napi/convertors-napi.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/interop/src/cpp/napi/convertors-napi.cc b/interop/src/cpp/napi/convertors-napi.cc index 7fa237507..a9b16c83e 100644 --- a/interop/src/cpp/napi/convertors-napi.cc +++ b/interop/src/cpp/napi/convertors-napi.cc @@ -291,7 +291,7 @@ const std::vector>& Exports::getMethods(cons auto it = implementations.find(module); if (it == implementations.end()) { LOGE("Module %s is not registered", module.c_str()); - throw "Fatal error"; + INTEROP_FATAL("Fatal error"); } return it->second; } diff --git a/interop/src/cpp/napi/convertors-napi.h b/interop/src/cpp/napi/convertors-napi.h index 29adb1265..e1c370105 100644 --- a/interop/src/cpp/napi/convertors-napi.h +++ b/interop/src/cpp/napi/convertors-napi.h @@ -29,6 +29,7 @@ #include #endif #include "koala-types.h" +#include "interop-types.h" // TODO: switch to more generic convertors eventually. template @@ -476,7 +477,7 @@ inline KLength getArgument(const CallbackInfo& info, int index) { break; } default: - throw "Error, unexpected KLength type"; + INTEROP_FATAL("Error, unexpected KLength type"); } return result; } -- Gitee From 600e4ff5ed9b6bf9a9934b133af6c9e81839d58d Mon Sep 17 00:00:00 2001 From: Korobeinikov Evgeny Date: Wed, 12 Feb 2025 15:27:55 +0300 Subject: [PATCH 2/2] Using interop-fatal in events --- arkoala/framework/native/src/events.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arkoala/framework/native/src/events.cc b/arkoala/framework/native/src/events.cc index 82c7e74fa..bb9e9015c 100644 --- a/arkoala/framework/native/src/events.cc +++ b/arkoala/framework/native/src/events.cc @@ -4,6 +4,7 @@ #include #include "events.h" #include "common-interop.h" +#include "interop-types.h" static std::deque eventQueue; @@ -13,7 +14,7 @@ void sendEvent(const EventBuffer* event) { KInt impl_CheckArkoalaGeneratedEvents(KByte* result, KInt size) { if (((size_t)size) < sizeof(EventBuffer::buffer)) - throw std::invalid_argument("Expected buffer size be not less than sizeof(EventBuffer) bytes"); + INTEROP_FATAL("Expected buffer size be not less than sizeof(EventBuffer) bytes"); if (!eventQueue.size()) return 0; -- Gitee