From fa321b267c054f351faef5c95aeead2fa793e27d Mon Sep 17 00:00:00 2001 From: Evgeniy Okolnov Date: Wed, 27 Sep 2023 23:24:20 +0300 Subject: [PATCH] [ArkTS Linter] Revert recent change to 'handleGenericCallWithNoTypeArgs' method to improve performance, as the original problem was fixed by filtering out incorrect strict diagnostic messages. Change-Id: Idc14f512d9f155fdc5a9bf8db6f3f8eb427c3323 Signed-off-by: Evgeniy Okolnov --- linter-4.2/src/TypeScriptLinter.ts | 3 +-- linter/src/TypeScriptLinter.ts | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/linter-4.2/src/TypeScriptLinter.ts b/linter-4.2/src/TypeScriptLinter.ts index cbe8b3106..7c9eb90e2 100644 --- a/linter-4.2/src/TypeScriptLinter.ts +++ b/linter-4.2/src/TypeScriptLinter.ts @@ -1779,11 +1779,10 @@ export class TypeScriptLinter { let tsSyntaxKind = ts.isNewExpression(callLikeExpr) ? ts.SyntaxKind.Constructor : ts.SyntaxKind.FunctionDeclaration; - const sym = this.tsTypeChecker.getTypeAtLocation(callLikeExpr.expression).symbol; let signDecl = this.tsTypeChecker.signatureToSignatureDeclaration( callSignature, tsSyntaxKind, - (!!sym && !!sym.declarations) ? sym.declarations[0] : undefined, + undefined, ts.NodeBuilderFlags.WriteTypeArgumentsOfSignature | ts.NodeBuilderFlags.IgnoreErrors ); diff --git a/linter/src/TypeScriptLinter.ts b/linter/src/TypeScriptLinter.ts index aaa107e74..e582ba84c 100644 --- a/linter/src/TypeScriptLinter.ts +++ b/linter/src/TypeScriptLinter.ts @@ -1460,10 +1460,9 @@ export class TypeScriptLinter { return; } const tsSyntaxKind = ts.isNewExpression(callLikeExpr) ? ts.SyntaxKind.Constructor : ts.SyntaxKind.FunctionDeclaration; - const sym = this.tsTypeChecker.getTypeAtLocation(callLikeExpr.expression).symbol; const signFlags = ts.NodeBuilderFlags.WriteTypeArgumentsOfSignature | ts.NodeBuilderFlags.IgnoreErrors; const signDecl = - this.tsTypeChecker.signatureToSignatureDeclaration(callSignature, tsSyntaxKind, this.tsUtils.getDeclaration(sym), signFlags); + this.tsTypeChecker.signatureToSignatureDeclaration(callSignature, tsSyntaxKind, undefined, signFlags); if (!signDecl?.typeArguments) { return; } -- Gitee