From 3b3f57f7fa2a7a168ae8da5003642db3078ecc92 Mon Sep 17 00:00:00 2001
From: aleksisch <churkin.aleksey@huawei-partners.com>
Date: Thu, 26 Oct 2023 15:53:52 +0300
Subject: [PATCH] fix empty iterator usage

Signed-off-by: aleksisch <churkin.aleksey@huawei-partners.com>
---
 binder/scope.cpp    | 2 +-
 binder/scope.h      | 2 +-
 parser/parserImpl.h | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/binder/scope.cpp b/binder/scope.cpp
index 22f53e1d2..60764033e 100644
--- a/binder/scope.cpp
+++ b/binder/scope.cpp
@@ -475,7 +475,7 @@ Scope::InsertResult GlobalScope::InsertImpl(const util::StringView &name, Variab
         if (const bool exported = node->IsClassDefinition() ? node->Parent()->IsExported() : node->IsExported();
             !exported) {
             if (!node->IsDefaultExported()) {
-                return Scope::InsertResult {{}, false};
+                return std::make_pair(Bindings().end(), false);
             }
         }
     }
diff --git a/binder/scope.h b/binder/scope.h
index 57a16b50b..c7a3d6a93 100644
--- a/binder/scope.h
+++ b/binder/scope.h
@@ -73,7 +73,7 @@ public:
     NO_MOVE_SEMANTIC(Scope);
 
     using VariableMap = ArenaUnorderedMap<util::StringView, Variable *>;
-    using InsertResult = std::pair<VariableMap::iterator, bool>;
+    using InsertResult = std::pair<VariableMap::const_iterator, bool>;
 
     virtual ScopeType Type() const = 0;
 
diff --git a/parser/parserImpl.h b/parser/parserImpl.h
index e680020b4..ae9944037 100644
--- a/parser/parserImpl.h
+++ b/parser/parserImpl.h
@@ -792,7 +792,7 @@ protected:
         return binder_;
     }
 
-    binder::Scope::VariableMap SavedBindings() const
+    const binder::Scope::VariableMap &SavedBindings() const
     {
         return saved_bindings_;
     }
-- 
Gitee