From eefb15b4c20a857cac2748a42abe13860ff7d8b8 Mon Sep 17 00:00:00 2001 From: Nazarov Konstantin Date: Fri, 9 Dec 2022 15:24:11 +0300 Subject: [PATCH] fix unnecessary JSHandle creation --- runtime/js_date_time_format.cpp | 6 ++---- runtime/object_factory-inl.h | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/runtime/js_date_time_format.cpp b/runtime/js_date_time_format.cpp index 6a632f557..0d6a6898b 100644 --- a/runtime/js_date_time_format.cpp +++ b/runtime/js_date_time_format.cpp @@ -117,8 +117,7 @@ void JSDateTimeFormat::SetIcuLocale(JSThread *thread, JSHandle native->ResetExternalPointer(icuPointer); return; } - JSHandle pointer(thread, - factory->NewJSNativePointer(icuPointer, callback, ecmaVm).GetTaggedValue()); + JSHandle pointer = factory->NewJSNativePointer(icuPointer, callback, ecmaVm); obj->SetLocaleIcu(thread, pointer.GetTaggedValue()); ecmaVm->PushToArrayDataList(*pointer); } @@ -155,8 +154,7 @@ void JSDateTimeFormat::SetIcuSimpleDateFormat(JSThread *thread, JSHandleResetExternalPointer(icuPointer); return; } - JSHandle pointer(thread, - factory->NewJSNativePointer(icuPointer, callback, ecmaVm).GetTaggedValue()); + JSHandle pointer = factory->NewJSNativePointer(icuPointer, callback, ecmaVm); obj->SetSimpleDateTimeFormatIcu(thread, pointer.GetTaggedValue()); ecmaVm->PushToArrayDataList(*pointer); } diff --git a/runtime/object_factory-inl.h b/runtime/object_factory-inl.h index d6c058972..33f74fe35 100644 --- a/runtime/object_factory-inl.h +++ b/runtime/object_factory-inl.h @@ -75,7 +75,7 @@ void ObjectFactory::NewJSIntlIcuData(const JSHandle &obj, const S &icu, const native->ResetExternalPointer(icu_point); return; } - JSHandle pointer(thread_, NewJSNativePointer(icu_point, callback, vm_).GetTaggedValue()); + JSHandle pointer = NewJSNativePointer(icu_point, callback, vm_); obj->SetIcuField(thread_, pointer.GetTaggedValue()); // push uint8_t* to ecma array_data_list vm_->PushToArrayDataList(*pointer); -- Gitee