From a1595f7d12e80449fd8d354dbdf1e787def45b28 Mon Sep 17 00:00:00 2001 From: Semenov Aleksandr Date: Thu, 18 May 2023 23:39:32 +0300 Subject: [PATCH] Clang-tidy: Fix warnings for tests/assembler Signed-off-by: Semenov Aleksandr --- tests/assembler/emitter_test_ecmascript.cpp | 8 +++++--- tests/assembler/parser_test_ecmascript.cpp | 3 ++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/tests/assembler/emitter_test_ecmascript.cpp b/tests/assembler/emitter_test_ecmascript.cpp index e15a983e1..db8e18ddb 100644 --- a/tests/assembler/emitter_test_ecmascript.cpp +++ b/tests/assembler/emitter_test_ecmascript.cpp @@ -38,7 +38,9 @@ namespace panda::test { -using namespace panda::pandasm; +using panda::pandasm::AsmEmitter; +using panda::pandasm::Error; +using panda::pandasm::Parser; static const uint8_t *GetTypeDescriptor(const std::string &name, std::string *storage) { @@ -96,8 +98,8 @@ TEST(emittertests, ecmascript_debuginfo) panda_file::DebugInfoExtractor extractor(pf.get()); auto methods = extractor.GetMethodIdList(); ASSERT_EQ(methods.size(), 1); - auto line_table = extractor.GetLineNumberTable(methods[0]); - auto column_table = extractor.GetColumnNumberTable(methods[0]); + const auto &line_table = extractor.GetLineNumberTable(methods[0]); + const auto &column_table = extractor.GetColumnNumberTable(methods[0]); EXPECT_EQ(line_table.size(), 1); EXPECT_EQ(column_table.size(), 1); diff --git a/tests/assembler/parser_test_ecmascript.cpp b/tests/assembler/parser_test_ecmascript.cpp index d42dd2f1c..cb16db579 100644 --- a/tests/assembler/parser_test_ecmascript.cpp +++ b/tests/assembler/parser_test_ecmascript.cpp @@ -18,7 +18,8 @@ #include #include -using namespace panda::pandasm; +using panda::pandasm::Error; +using panda::pandasm::Parser; TEST(parsertests, calli_dyn_3args) { -- Gitee