diff --git a/README.en.md b/README.en.md index 3ca50592f0d0d56f176b643b6a4f442f513b68ca..0485324f3399fcf23730327d493c1fcd9a605346 100644 --- a/README.en.md +++ b/README.en.md @@ -1,126 +1,126 @@ -# Flutter SDK repository +Flutter SDK repository +============== -Original warehouse source：https://github.com/flutter/flutter - -## Warehouse description： +Original warehouse source: https://github.com/flutter/flutter +## Warehouse description: This warehouse is based on the compatible extension of flutter sdk for OpenHarmony, and can support the use of flutter tools instructions to compile and build OpenHarmony applications. ## Build instructions: -- Build environment: - Currently, the flutter tools command supports use on Linux and Mac. - -- Build dependencies: - To build products that depend on [flutter engine](https://github.com/flutter/engine): `ohos_debug_unopt_arm64` and `ohos_release_arm64`, please add: `-local-engine=` in the running parameters of the flutter tools command. - -- Building steps: - - 1. Download the [command line tool](https://developer.harmonyos.com/cn/develop/deveco-studio#download_cli) and configure the environment variables ohpm and sdkmanager. After the download is complete, execute `ohpm/bin/init` to install ohpm. Refer to the guidance document: [ohpm usage guide](https://developer.harmonyos.com/cn/docs/documentation/doc-guides-V3/ide-command-line-ohpm-0000001490235312-V3). - - ``` - export OHPM_HOME=/home//ohos/oh-command-line-tools/ohpm/ - export PATH=/home//ohos/oh-command-line-tools/sdkmanager/bin:$PATH - export PATH=$PATH:$OHPM_HOME/bin - ``` - - 2. Download the sdk and configure the environment variables. Please refer to the [ohsdkmgr usage guide](https://developer.harmonyos.com/cn/docs/documentation/doc-guides-V3/ide-command-line-ohsdkmgr-0000001545647965-V3). Use the command to download the OpenHarmony sdk (below API9). AP10 needs to download ohos-full-sdk from [the daily build](http://ci.openharmony.cn/workbench/cicd/dailybuild/detail/component). Please keep the sdk directory structure as follows. - - ``` - export OHOS_SDK_HOME=/home//env/sdk - export HDC_HOME=/home//env/sdk/10/toolchains - export PATH=$PATH:$HDC_HOME - ``` - - ``` - /SDK - ├── 10 - │ └── ets - │ └── js - │ └── native - │ └── previewer - │ └── toolchains - ├── 9 - ... - ``` - - 3. Configure Gradle: Download `gradle 7.1` and unzip it, and configure it into environment variables: - - ``` - # grade - export PATH=/home//env/gradle-7.1/bin:$PATH - ``` - - 4. Download Flutter and configure the environment after the download is complete: - - ``` - git clone https://gitee.com/openharmony-sig/flutter_flutter.git - - export PATH=/home//ohos/flutter_flutter/bin:$PATH - export PUB_HOSTED_URL=https://pub.flutter-io.cn - export FLUTTER_STORAGE_BASE_URL=https://storage.flutter-io.cn - ``` - - 5. The signature tool requires the following configuration: - - - Download the [signature tool](https://gitee.com/openharmony/developtools_hapsigner) and configure the environment variable SIGN_TOOL_HOME. - - ``` - export SIGN_TOOL_HOME=/home//ohos/developtools_hapsigner/autosign - ``` - - - Execute the following command to compile hap-sign-tool.jar and make sure it is in the directory: ./hapsigntool/hap_sign_tool/build/libs/hap-sign-tool.jar. - - ``` - gradle build - ``` - - - Edit the `autosign.config` and `createAppCertAndProfile.config` files in the autosign directory and modify their values: - - ``` - sign.profile.inFile=profile_tmp.json - ``` - - - In the autosign directory, execute the command `chmod 777 *.sh`, and add the `profile_tmp_template.json` file, edit it as follows: - - ``` - { - "version-name": "2.0.0", - "version-code": 2, - "app-distribution-type": "os_integration", - "uuid": "5027b99e-5f9e-465d-9508-a9e0134ffe18", - "validity": { - "not-before": 1594865258, - "not-after": 1689473258 - }, - "type": "release", - "bundle-info": { - "developer-id": "OpenHarmony", - "distribution-certificate": "-----BEGIN CERTIFICATE-----\nMIICSTCCAc+gAwIBAgIFAJV7uNUwCgYIKoZIzj0EAwIwYzELMAkGA1UEBhMCQ04x\nFDASBgNVBAoMC09wZW5IYXJtb255MRkwFwYDVQQLDBBPcGVuSGFybW9ueSBUZWFt\nMSMwIQYDVQQDDBpPcGVuSGFybW9ueSBBcHBsaWNhdGlvbiBDQTAeFw0yMjAxMjkw\nNTU0MTRaFw0yMzAxMjkwNTU0MTRaMGgxCzAJBgNVBAYTAkNOMRQwEgYDVQQKDAtP\ncGVuSGFybW9ueTEZMBcGA1UECwwQT3Blbkhhcm1vbnkgVGVhbTEoMCYGA1UEAwwf\nT3Blbkhhcm1vbnkgQXBwbGljYXRpb24gUmVsZWFzZTBZMBMGByqGSM49AgEGCCqG\nSM49AwEHA0IABAW8pFu7tHGUuWtddD5wvazc1qN8ts9UPZH4pecbb/bSFWKh7X7R\n/eTVaRrCTSSdovI1dhoV5GjuFsKW+jT2TwSjazBpMB0GA1UdDgQWBBScyywAaAMj\nI7HcuIS42lvZx0Lj+zAJBgNVHRMEAjAAMA4GA1UdDwEB/wQEAwIHgDATBgNVHSUE\nDDAKBggrBgEFBQcDAzAYBgwrBgEEAY9bAoJ4AQMECDAGAgEBCgEAMAoGCCqGSM49\nBAMCA2gAMGUCMFfNidGo6uK6KGT9zT1T5bY1NCHTH3P3muy5X1xudOgxWoOqIbnk\ntmQYB78dxWEHLQIxANfApAlXAD/0hnyNC8RDzfLOPEeay6jU9FXJj3AoR90rwZpR\noN9sYD6Oks4VGRw6yQ==\n-----END CERTIFICATE-----\n", - "bundle-name": "{{ohosId}}", - "apl": "normal", - "app-feature": "hos_normal_app" - }, - "acls": { - "allowed-acls": [ - "" - ] - }, - "permissions": { - "restricted-permissions": [] - }, - "issuer": "pki_internal" - } - ``` - - 6. If the `.npmrc` configuration is not created in the `/home//`directory, an error may be reported when building hap: `Error: The hvigor depends on the npmrc file. Configure the npmrc file first.` Please configure the npmrc file in the user directory `/home//` Create the file `.npmrc` under. You can also refer to the official documentation for this configuration. The editing content is as follows: - - ``` - registry=https://repo.huaweicloud.com/repository/npm/ - @ohos:registry=https://repo.harmonyos.com/npm/ - ``` - -For the configuration of all the above environment variables, please refer to the following example (please replace user and specific code path with the actual path): +* Build environment: + Currently, the flutter tools command supports use on Linux and Mac. + +* Build dependencies: + Depend on [flutter engine](https://github.com/flutter/engine) to build products: `ohos_debug_unopt_arm64` and `ohos_release_arm64`, please add: `--local-engine=\` + +*Building steps: + + 1. Download [command line tool](https://developer.harmonyos.com/cn/develop/deveco-studio#download_cli), and configure the environment variables ohpm and sdkmanager. After the download is complete, execute `ohpm/bin/init` to install ohpm. Refer to the guidance document: [ohpm usage guide](https://developer.harmonyos.com/cn/docs/documentation/doc-guides-V3/ide-command-line-ohpm-0000001490235312-V3). + + ``` + export OHPM_HOME=/home//ohos/oh-command-line-tools/ohpm/ + export PATH=/home//ohos/oh-command-line-tools/sdkmanager/bin:$PATH + export PATH=$PATH:$OHPM_HOME/bin + ``` + + 2. Download SDK and configure environment variables, please refer to [ohsdkmgr usage guide](https://developer.harmonyos.com/cn/docs/documentation/doc-guides-V3/ide-command-line-ohsdkmgr-0000001545647965-V3 ) Use the command to download OpenHarmony sdk (below API9), AP10 needs to download ohos-full-sdk from [Daily Build](http://ci.openharmony.cn/workbench/cicd/dailybuild/detail/component), please keep the sdk The directory structure is as follows. (To compile in mac environment, please download mac-sdk-full or mac-sdk-m1-full) + + ``` + export OHOS_SDK_HOME=/home//env/sdk + export HDC_HOME=/home//env/sdk/10/toolchains + export PATH=$PATH:$HDC_HOME + ``` + + ``` + /SDK + ├── 10 + │ └── ets + │ └── js + │ └── native + │ └── previewer + │ └── toolchains + ├── 9 + ... + ``` + + 3. Configure Gradle: Download `gradle 7.1` and unzip it, configure it into environment variables: + + ``` + # grade + export PATH=/home//env/gradle-7.1/bin:$PATH + ``` + + 4. Download Flutter and configure the environment after the download is complete: + + ``` + git clone https://gitee.com/openharmony-sig/flutter_flutter.git + + export PATH=/home//ohos/flutter_flutter/bin:$PATH + export PUB_HOSTED_URL=https://pub.flutter-io.cn + export FLUTTER_STORAGE_BASE_URL=https://storage.flutter-io.cn + ``` + + 5. The signature tool requires the following configuration: + + - Download [Signature Tool](https://gitee.com/openharmony/developtools_hapsigner) and configure the environment variable SIGN_TOOL_HOME. + + ``` + export SIGN_TOOL_HOME=/home//ohos/developtools_hapsigner/autosign + ``` + + - Execute the following command to compile hap-sign-tool.jar and make sure it is in the directory: ./hapsigntool/hap_sign_tool/build/libs/hap-sign-tool.jar. + + ``` + gradle build + ``` + + - Edit the `autosign.config` and `createAppCertAndProfile.config` files in the autosign directory and modify their values: + + ``` + sign.profile.inFile=profile_tmp.json + ``` + + - In the autosign directory, execute the command `chmod 777 *.sh`, and add the `profile_tmp_template.json` file, edit it as follows: + + ``` + { + "version-name": "2.0.0", + "version-code": 2, + "app-distribution-type": "os_integration", + "uuid": "5027b99e-5f9e-465d-9508-a9e0134ffe18", + "validity": { + "not-before": 1594865258, + "not-after": 1689473258 + }, + "type": "release", + "bundle-info": { + "developer-id": "OpenHarmony", + "distribution-certificate": "-----BEGIN CERTIFICATE-----\nMIICSTCCAc+gAwIBAgIFAJV7uNUwCgYIKoZIzj0EAwIwYzELMAkGA1UEBhMCQ04x\nFDASBgNVBAoMC09wZW5IYXJtb255MRkwFwYDVQQLDBBPcGVuSGFybW9 ueSBUZWFt\nMSMwIQYDVQQDDBpPcGVuSGFybW9ueSBBcHBsaWNhdGlvbiBDQTAeFw0yMjAxMjkw\nNTU0MTRaFw0yMzAxMjkwNTU0MTRaMGgxCzAJBgNVBAYTAkNOMRQwEgYDVQQKDAtP\ncGVuSGFyb W9ueTEZMBcGA1UECwwQT3Blbkhhcm1vbnkgVGVhbTEoMCYGA1UEAwwf\nT3Blbkhhcm1vbnkgQXBwbGljYXRpb24gUmVsZWFzZTBZMBMGByqGSM49AgEGCCqG\nSM49AwEHA0IABAW8pFu7tHGUuWtddD5wvaz c1qN8ts9UPZH4pecbb/bSFWKh7X7R\n/eTVaRrCTSSdovI1dhoV5GjuFsKW+jT2TwSjazBpMB0GA1UdDgQWBBScyywAaAMj\nI7HcuIS42lvZx0Lj+zAJBgNVHRMEAjAAMA4GA1UdDwEB/wQEAwIHgDA TBgNVHSUE\ nDDAKBggrBgEFBQcDAzAYBgwrBgEEAY9bAoJ4AQMECDAGAgEBCgEAMAoGCCqGSM49\nBAMCA2gAMGUCMFfNidGo6uK6KGT9zT1T5bY1NCHTH3P3muy5X1xudOgxWoOqIbnk\ntmQYB78dxWEHLQIxANfApAlXAD /0hnyNC8RDzfLOPEeay6jU9FXJj3AoR90rwZpR\noN9sYD6Oks4VGRw6yQ==\n-----END CERTIFICATE-----\n", + "bundle-name": "{{ohosId}}", + "apl": "normal", + "app-feature": "hos_normal_app" + }, + "acls": { + "allowed-acls": [ + "" + ] + }, + "permissions": { + "restricted-permissions": [] + }, + "issuer": "pki_internal" + } + ``` + + 6. If the `.npmrc` configuration is not created in the `/home//` directory, an error may be reported when building hap: Error: The hvigor depends on the npmrc file. Configure the npmrc file first. Please configure the npmrc file first in the user directory` Create the file `.npmrc` under /home//`. For this configuration, you can also refer to [Official Documentation](https://developer.harmonyos.com/cn/docs/documentation/doc-guides-V3/environment_config- 0000001052902427-V3), the edited content is as follows: + + ``` + registry=https://repo.huaweicloud.com/repository/npm/ + @ohos:registry=https://repo.harmonyos.com/npm/ + ``` + + For the configuration of all the above environment variables, please refer to the following example (please replace user and specific code path with the actual path): ``` #flutter env start ===> @@ -129,7 +129,7 @@ For the configuration of all the above environment variables, please refer to th export PUB_HOSTED_URL=https://pub.flutter-io.cn export FLUTTER_STORAGE_BASE_URL=https://storage.flutter-io.cn -# flutter +#flutter export FLUTTER_HOME=/home//code/flutter/gitlab/flutter export PATH=$PATH:$FLUTTER_HOME/bin @@ -137,13 +137,13 @@ export PATH=/home//ohos/flutter_flutter/bin:$PATH export PUB_HOSTED_URL=https://pub.flutter-io.cn export FLUTTER_STORAGE_BASE_URL=https://storage.flutter-io.cn -# ohpm +#ohpm export OHPM_HOME=/home//ohos/oh-command-line-tools/ohpm/ export PATH=$PATH:$OHPM_HOME/bin -# sdkmanager +#sdkmanager export PATH=/home//ohos/oh-command-line-tools/sdkmanager/bin:$PATH -# sdk/hdc +# sdk and hdc export OHOS_SDK_HOME=/home//env/sdk export HDC_HOME=/home//env/sdk/10/toolchains export PATH=$PATH:$HDC_HOME @@ -153,7 +153,7 @@ export SIGN_TOOL_HOME=/home//ohos/developtools_hapsigner/autosign # grade export PATH=/home//env/gradle-7.1/bin:$PATH -# nodejs +#nodejs export NODE_HOME=/home//env/node-v14.19.1-linux-x64 export PATH=$NODE_HOME/bin:$PATH @@ -162,70 +162,67 @@ export PATH=$NODE_HOME/bin:$PATH - Construct -1. Run `flutter doctor -v` to check whether the environment variable configuration is correct. Both **Futter** and **OpenHarmony** should be ok. If the two prompts indicate that the environment is missing, just follow the prompts to fill in the corresponding environment. - -2. Create the project and compile the command. The compiled product is under `flutter_demo/ohos/entry/build/default/outputs/default/entry-default-signed.hap`. +1. Run `flutter doctor -v` to check whether the environment variable configuration is correct. **Futter** and **Openharmony** should both be ok. If the two prompts indicate that the environment is missing, just follow the prompts to fill in the corresponding environment. - ``` - # Create project - flutter create --platforms ohos flutter_demo - # Enter the project root directory to compile - flutter build hap --local-engine-src-path /home//ohos/engine/src --local-engine ohos_release_arm64 - ``` +2. Create the project and compile the command. The compiled product is under flutter_demo/ohos/entry/build/default/outputs/default/entry-default-signed.hap. -3. After flutter devices discover the ohos device, use `hdc -d install ` to install it. + ``` + # Create project + flutter create --platforms ohos flutter_demo + # Enter the project root directory to compile + flutter build hap --local-engine-src-path /home//ohos/engine/src --local-engine ohos_release_arm64 + ``` -## About how to connect and debug OpenHarmony devices with Linux virtual machines under Windows +3. After flutter devices discover the ohos device, use `hdc -t install ` to install it. -- Problem: Linux virtual machine cannot directly discover OpenHarmony devices through hdc -- Solution: In the Windows host, open the hdc server. The specific instructions are as follows: +## About how to connect and debug OpenHarmony devices for Linux virtual machines under Windows +* Problem: Linux virtual machine cannot directly discover OpenHarmony devices through hdc +* Solution: In the Windows host, open the hdc server. The specific instructions are as follows: ``` hdc kill hdc -s serverIP:8710 -m ``` - Configure environment variables in linux: - ``` HDC_SERVER= HDC_SERVER_PORT=8710 ``` -After the configuration is completed, flutter sdk can complete the device connection through hdc server. You can also refer to the official guidance. - -## Instruction list compatible with OpenHarmony development: +After the configuration is completed, the flutter sdk can complete the device connection through the hdc server. You can also refer to [official guidance](https://docs.openharmony.cn/pages/v4.0/zh-cn/device-dev/subsystems/subsys-toolchain -hdc-guide.md/#hdc-client%E5%A6%82%E4%BD%95%E8%BF%9C%E7%A8%8B%E8%AE%BF%E9%97%AEhdc-server) -| Instruction name | Instruction description | Instructions for use | -| ---------------- | ------------------------- | ------------------------------------------------------------ | -| doctor | environment detection | flutter doctor | -| config | environment configuration | flutter config --\ \ | -| create | Create a new project | flutter create --platforms ohos,android --org \ \ | -| devices | connected devices find | flutter devices | -| install | application installation | flutter install -d \ \ | -| assemble | resource packaging | flutter assemble | -| build | test application build | flutter build hap --target-platform ohos-arm64 --debug --local-engine=< debug engine product path compatible with ohos > | -| build | Formal application build | flutter build hap --target-platform ohos-arm64 --release --local-engine=< ohos-compatible release engine product path > | -| run | application runs | flutter run --local-engine=< ohos-compatible engine product path > | -| attach | debug mode | flutter attach | +## Compatible command list developed by OpenHarmony: +| Command name | Command description | Instructions for use | +| ------- | ------- |---------------------------------- ----------------------------------| +| doctor | environment detection | flutter doctor | +| config | environment configuration | flutter config --\ \ | +| create | Create a new project | flutter create --platforms ohos,android --org \ \ | +| devices | Connected device discovery | flutter devices | +| install | application installation | flutter install -t \ \ | +| assemble | resource packaging | flutter assemble | +| build | Test application build | flutter build hap --target-platform ohos-arm64 --debug --local-engine=\ | +| build | Formal application build | flutter build hap --target-platform ohos-arm64 --release --local-engine=\ | +| run | application run | flutter run --local-engine=\ | +| attach | debug mode | flutter attach | -## Common Problem: +## common problem: -1. Recommended version of ohos sdk: `4.0.10.3`, which can be downloaded around August 20 when it is built daily. If there are problems related to the SDK version during the compilation process, you can try to replace this version of the SDK. +1. Recommended ohos sdk version: `4.0.10.3`, which can be downloaded around August 20 when it is built daily. If there are problems related to the SDK version during the compilation process, you can try to replace this version of the SDK. 2. If an error message appears: `The SDK license agreement is not accepted`, please execute the following command and compile again: - ``` - ./ohsdkmgr install ets:9 js:9 native:9 previewer:9 toolchains:9 --sdk-directory='/home/xc/code/sdk/ohos-sdk/' --accept-license - ``` + ``` + ./ohsdkmgr install ets:9 js:9 native:9 previewer:9 toolchains:9 --sdk-directory='/home/xc/code/sdk/ohos-sdk/' --accept-license + ``` 3. After switching between debug and release compilation modes, an error may be reported during operation. You can try deleting the oh_modules cache file and recompiling. -2. If `flutter docker -v` prompts that ohpm cannot be found, but the environment variables are detected correctly, please ensure that you have executed the `ohpm/bin/init` command to install ohpm and check again. +4. If `flutter docker -v` prompts that ohpm cannot be found, but the environment variables are detected correctly, please ensure that you have executed the `ohpm/bin/init` command to install ohpm and check again. -3. If you encounter the error Unsupported class file major version 61 when compiling the signature tool, it means that the current JDK version does not support it. You can command to display all JDK versions in the current system and select the required version. Enter the number and confirm the selection to compile again. +5. If you encounter the error Unsupported class file major version 61 when compiling the signature tool, it means that the current JDK version does not support it. You can command to display all JDK versions in the current system and select the required version. Enter the number and confirm the selection to compile again. - ``` - sudo update-alternatives --config java - ``` + ``` + sudo update-alternatives --config java + ``` +6. If you are using the Beta version of DevEco Studio and encounter the error "must have required property 'compatibleSdkVersion', location: demo/ohos/build-profile.json5:17:11" when compiling the project, please refer to "DevEco Studio" Modify the hvigor/hvigor-config.json5 file in the '6 Creating Projects and Running Hello World' [Configuration Plug-in] chapter in "Environment Configuration Guide.docx". \ No newline at end of file diff --git a/README.md b/README.md index 844427f6c721a40045ea151fc84f9cb4faa532cf..f39a73c8062b03783c0770b674dd48a93224c415 100644 --- a/README.md +++ b/README.md @@ -24,7 +24,7 @@ Flutter SDK 仓库 export PATH=$PATH:$OHPM_HOME/bin ``` - 2. 下载sdk并配置环境变量，可参考[ohsdkmgr使用指导](https://developer.harmonyos.com/cn/docs/documentation/doc-guides-V3/ide-command-line-ohsdkmgr-0000001545647965-V3) 使用命令下载OpenHarmony sdk（API9以下），AP10需要从[每日构建](http://ci.openharmony.cn/workbench/cicd/dailybuild/detail/component)下载ohos-full-sdk，请保持sdk目录结构如下。 + 2. 下载sdk并配置环境变量，可参考[ohsdkmgr使用指导](https://developer.harmonyos.com/cn/docs/documentation/doc-guides-V3/ide-command-line-ohsdkmgr-0000001545647965-V3) 使用命令下载OpenHarmony sdk（API9以下），AP10需要从[每日构建](http://ci.openharmony.cn/workbench/cicd/dailybuild/detail/component)下载ohos-full-sdk，请保持sdk目录结构如下。(mac环境编译，请下载mac-sdk-full或者mac-sdk-m1-full) ``` export OHOS_SDK_HOME=/home//env/sdk @@ -174,7 +174,7 @@ export PATH=$NODE_HOME/bin:$PATH flutter build hap --local-engine-src-path /home//ohos/engine/src --local-engine ohos_release_arm64 ``` -3. flutter devices发现ohos设备之后，使用 `hdc -d install `进行安装。 +3. flutter devices发现ohos设备之后，使用 `hdc -t install `进行安装。 ## 关于windows下linux虚拟机如何连接和调试OpenHarmony设备 @@ -199,7 +199,7 @@ HDC_SERVER_PORT=8710 | config | 环境配置 | flutter config --\ \ | | create | 创建新项目 | flutter create --platforms ohos,android --org \ \ | | devices | 已连接设备查找 | flutter devices | -| install | 应用安装 | flutter install -d \ \ | +| install | 应用安装 | flutter install -t \ \ | | assemble | 资源打包 | flutter assemble | | build | 测试应用构建 | flutter build hap --target-platform ohos-arm64 --debug --local-engine=\<兼容ohos的debug engine产物路径\> | | build | 正式应用构建 | flutter build hap --target-platform ohos-arm64 --release --local-engine=\<兼容ohos的release engine产物路径\> | @@ -216,7 +216,6 @@ HDC_SERVER_PORT=8710 ./ohsdkmgr install ets:9 js:9 native:9 previewer:9 toolchains:9 --sdk-directory='/home/xc/code/sdk/ohos-sdk/' --accept-license ``` - 3. 切换debug和release编译模式后，可能运行报错，可尝试删除oh_modules缓存文件，重新编译。 4. 如果`flutter docker -v`提示ohpm无法找到，但是检测环境变量无误，请确保已执行`ohpm/bin/init`命令安装ohpm后再次检查。 @@ -225,4 +224,6 @@ HDC_SERVER_PORT=8710 ``` sudo update-alternatives --config java - ``` \ No newline at end of file + ``` + +6. 如果你使用的是DevEco Studio的Beta版本，编译工程时遇到“must have required property 'compatibleSdkVersion', location: demo/ohos/build-profile.json5:17:11"错误，请参考《DevEco Studio环境配置指导.docx》中的‘6 创建工程和运行Hello World’【配置插件】章节修改 hvigor/hvigor-config.json5文件。 \ No newline at end of file