From 97bc4053fb835ced53411c4f74d36f7b5e4b9ece Mon Sep 17 00:00:00 2001 From: hhl Date: Wed, 6 Aug 2025 16:33:50 +0800 Subject: [PATCH] fix codecheck Signed-off-by: hhl --- services/appdfr/src/appfreeze_manager.cpp | 8 +++++++- .../appfreeze_manager_test.cpp | 12 ++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/services/appdfr/src/appfreeze_manager.cpp b/services/appdfr/src/appfreeze_manager.cpp index fc6e4f1a548..e4d6ef56023 100644 --- a/services/appdfr/src/appfreeze_manager.cpp +++ b/services/appdfr/src/appfreeze_manager.cpp @@ -894,7 +894,13 @@ void AppfreezeManager::PerfStart(std::string eventName) } std::string AppfreezeManager::GetFirstLine(const std::string &path) { - std::ifstream inFile(path.c_str()); + std::string realPath; + if (!OHOS::PathToRealPath(path, realPath)) { + TAG_LOGE(AAFwkTag::APPDFR, "realpath failed, path:%{public}s errno:%{public}d", + path.c_str(), errno); + return ""; + } + std::ifstream inFile(realPath.c_str()); if (!inFile) { return ""; } diff --git a/test/unittest/dfr_test/appfreeze_manager_test/appfreeze_manager_test.cpp b/test/unittest/dfr_test/appfreeze_manager_test/appfreeze_manager_test.cpp index aa170c629c4..fc145dd7c04 100644 --- a/test/unittest/dfr_test/appfreeze_manager_test/appfreeze_manager_test.cpp +++ b/test/unittest/dfr_test/appfreeze_manager_test/appfreeze_manager_test.cpp @@ -379,5 +379,17 @@ HWTEST_F(AppfreezeManagerTest, AppfreezeManagerTest_GetFaultNotifyData_001, Test faultNotifyData = appfreezeManager->GetFaultNotifyData(faultData, pid); EXPECT_EQ(faultNotifyData.eventId, 10); } + +/** + * @tc.number: AppfreezeManagerTest_GetFirstLine_001 + * @tc.desc: add testcase + * @tc.type: FUNC + */ +HWTEST_F(AppfreezeManagerTest, AppfreezeManagerTest_GetFirstLine_001, TestSize.Level1) +{ + std::string ret = appfreezeManager->GetFirstLine("../111"); + EXPECT_EQ(ret, ""); + appfreezeManager->GetFirstLine("/data/log/test"); +} } // namespace AppExecFwk } // namespace OHOS -- Gitee