diff --git a/contactsCJ/include/contacts_utils.h b/contactsCJ/include/contacts_utils.h index 14e2464fd14871f19d72f7e167af0b17022d93d6..d311014b3a574bb3a7bd6c4c0ad4646ae5e8b080 100644 --- a/contactsCJ/include/contacts_utils.h +++ b/contactsCJ/include/contacts_utils.h @@ -96,7 +96,7 @@ struct Buckets { void freeContent() { if (data != nullptr) { - for (int b = 0; b < bucketCount; b++) { + for (uint64_t b = 0; b < bucketCount; b++) { ValuesBucket bucket = data[b]; bucket.freeContent(); } @@ -118,7 +118,7 @@ struct ContactsData { void freeContent() { if (contactsData != nullptr) { - for (int i = 0; i < contactsCount; i++) { + for (uint64_t i = 0; i < contactsCount; i++) { ContactData contactData = contactsData[i]; contactData.freeContent(); } diff --git a/contactsCJ/src/contacts_ffi.cpp b/contactsCJ/src/contacts_ffi.cpp index 25b7db073df47631459f3f3d433fc3ebd0d982bf..bcf537c8287e9244b13950ad7ca4432539766a50 100644 --- a/contactsCJ/src/contacts_ffi.cpp +++ b/contactsCJ/src/contacts_ffi.cpp @@ -30,7 +30,7 @@ extern "C" { { DataShare::DataShareValuesBucket convertedRawContact = convertToDataShareVB(rawContact[0]); std::vector convertedContact; - for (int64_t i = 0; i < contactData->bucketCount; i++) { + for (uint64_t i = 0; i < contactData->bucketCount; i++) { ContactsFfi::ValuesBucket vb = contactData->data[i]; convertedContact.push_back(convertToDataShareVB(vb)); } @@ -46,7 +46,7 @@ extern "C" { int64_t predicatesId, int32_t *errCode) { std::vector convertedContact; - for (int64_t i = 0; i < contactData->bucketCount; i++) { + for (uint64_t i = 0; i < contactData->bucketCount; i++) { ContactsFfi::ValuesBucket vb = contactData->data[i]; convertedContact.push_back(convertToDataShareVB(vb)); } diff --git a/contactsCJ/src/contacts_utils.cpp b/contactsCJ/src/contacts_utils.cpp index 8014ac738ecd0700b1907d1292f3c81f92ebd3a0..cd3653f8c3a0ab08802249f9137d0d5cdb9eeb53 100644 --- a/contactsCJ/src/contacts_utils.cpp +++ b/contactsCJ/src/contacts_utils.cpp @@ -49,9 +49,9 @@ bool allocBucket(ValuesBucket* b, size_t total, int32_t *errCode) DataShareValuesBucket convertToDataShareVB(ValuesBucket vb) { - int64_t size = vb.size; + uint64_t size = vb.size; DataShareValuesBucket dsvb = DataShareValuesBucket(); - for (int64_t i = 0; i < size; i++) { + for (uint64_t i = 0; i < size; i++) { switch (vb.value[i].tag) { case DataShareValueObjectType::TYPE_STRING: { DataShareValueObject valueObject = DataShareValueObject(std::string(vb.value[i].string)); @@ -620,7 +620,7 @@ GroupsData* parseResultSetForGroups(std::shared_ptr &resultS int totalGroups = 0; resultSet->GetRowCount(totalGroups); HILOG_INFO("parseResultSetForGroups GetRowCount is %{public}d", totalGroups); - if (totalGroups == 0) { + if (totalGroups <= 0) { return nullptr; } @@ -637,7 +637,7 @@ GroupsData* parseResultSetForGroups(std::shared_ptr &resultS *errCode = ERROR; return NULL; } - allGroups->bucketCount = totalGroups; + allGroups->bucketCount = static_cast(totalGroups); int resultSetNum = resultSet->GoToFirstRow(); int count = 0; @@ -670,7 +670,7 @@ HoldersData* parseResultSetForHolders(std::shared_ptr &resul int totalHolders = 0; resultSet->GetRowCount(totalHolders); HILOG_INFO("parseResultSetForHolders GetRowCount is %{public}d", totalHolders); - if (totalHolders == 0) { + if (totalHolders <= 0) { return nullptr; } @@ -687,7 +687,7 @@ HoldersData* parseResultSetForHolders(std::shared_ptr &resul *errCode = ERROR; return nullptr; } - allHolders->bucketCount = totalHolders; + allHolders->bucketCount = static_cast(totalHolders); int resultSetNum = resultSet->GoToFirstRow(); int count = 0;