From f04641faca083396ca177727f044e42d67427606 Mon Sep 17 00:00:00 2001
From: wujianlin <wujianlin8@h-partners.com>
Date: Fri, 21 Mar 2025 17:15:12 +0800
Subject: [PATCH] Add check for attemp acquire

Issue:https://gitee.com/openharmony/commonlibrary_c_utils/issues/IBVBIU?from=project-issue
Signed-off-by: wujianlin <wujianlin8@h-partners.com>
---
 base/include/refbase.h                             | 14 ++++++++++++++
 base/src/refbase.cpp                               | 14 ++++++++++++++
 .../refbase_benchmark_test.cpp                     |  4 ++++
 base/test/unittest/common/utils_refbase_test.cpp   |  4 ++++
 4 files changed, 36 insertions(+)

diff --git a/base/include/refbase.h b/base/include/refbase.h
index 0a3a86f..65658b2 100644
--- a/base/include/refbase.h
+++ b/base/include/refbase.h
@@ -184,6 +184,11 @@ public:
      */
     void SetAttemptAcquire();
 
+    /**
+     * @brief Get the current times of attempts.
+     */
+    int GetAttemptAcquire();
+
     /**
      * @brief Check if the number of attempts is greater than 0.
      *
@@ -490,6 +495,15 @@ public:
      */
     bool AttemptAcquire(const void *objectId);
 
+    // Only for IPC use.
+    /**
+     * @brief Check attempt acquire is setted
+     *
+     * @note This fuction is extracted from `IncStrongRef()`
+     * It is only for IPC use.
+     */
+    void CheckIsAttemptAcquireSet(const void *objectId);
+
     /**
      * @brief Attempts to increment the count of strong references.
      *
diff --git a/base/src/refbase.cpp b/base/src/refbase.cpp
index affddd9..9d58480 100644
--- a/base/src/refbase.cpp
+++ b/base/src/refbase.cpp
@@ -302,6 +302,11 @@ int RefCounter::GetWeakRefCount()
     return atomicWeak_.load(std::memory_order_relaxed);
 }
 
+int RefCounter::GetAttemptAcquire()
+{
+    return atomicAttempt_.load(std::memory_order_relaxed);
+}
+
 void RefCounter::SetAttemptAcquire()
 {
     (void)atomicAttempt_.fetch_add(1, std::memory_order_relaxed);
@@ -482,8 +487,17 @@ void RefBase::IncStrongRef(const void *objectId)
     if (curCount == INITIAL_PRIMARY_VALUE) {
         OnFirstStrongRef(objectId);
     }
+}
+
+void RefBase::CheckIsAttemptAcquireSet(const void *objectId)
+{
     if (refs_->IsAttemptAcquireSet()) {
         refs_->ClearAttemptAcquire();
+        const int attemptCount = refs_->GetAttemptAcquire();
+        if (attemptCount < 0) {
+            UTILS_LOGF("Multi-threads trigger illegal decstrong from %{public}d due to AttemptIncStrong in ipc",
+                attemptCount);
+        }
         refs_->DecStrongRefCount(objectId);
         refs_->DecWeakRefCount(objectId);
     }
diff --git a/base/test/benchmarktest/refbase_benchmark_test/refbase_benchmark_test.cpp b/base/test/benchmarktest/refbase_benchmark_test/refbase_benchmark_test.cpp
index 1535689..c3032cb 100644
--- a/base/test/benchmarktest/refbase_benchmark_test/refbase_benchmark_test.cpp
+++ b/base/test/benchmarktest/refbase_benchmark_test/refbase_benchmark_test.cpp
@@ -349,6 +349,7 @@ int RegisterEventThread()
     int handle = 10;
     for (int i = 0; i < CYCLE_NUM2; i++) {
         sptr<IRemoteObject> remote = ipc.FindOrNewObject(handle);
+        remote->CheckIsAttemptAcquireSet(remote);
         if (remote) {
             remote->IsProxyObject();
         }
@@ -543,10 +544,12 @@ BENCHMARK_F(BenchmarkRefbaseTest, testRefbaseOperate001)(benchmark::State& state
         remoteObject->AttemptAcquire(this);
         remoteObject->IncWeakRef(this);
         remoteObject->IncStrongRef(this);
+        remoteObject->CheckIsAttemptAcquireSet(this);
         remoteObject->DecStrongRef(this);
         remoteObject->AttemptAcquire(this);
 
         remoteObject->IncStrongRef(this);
+        remoteObject->CheckIsAttemptAcquireSet(this);
         remoteObject->DecStrongRef(this);
 
         remoteObject->DecWeakRef(this);
@@ -637,6 +640,7 @@ BENCHMARK_F(BenchmarkRefbaseTest, testRefbaseAcquire001)(benchmark::State& state
         {
             AssertTrue(testobject->IsAttemptAcquireSet(),
                 "testobject->IsAttemptAcquireSet() did not equal true", state);
+            testobject->CheckIsAttemptAcquireSet(this);
             sptr<RefBaseTest> sptrRef = testobject;
             AssertEqual(sptrRef->GetSptrRefCount(), EXPECTED_REF_COUNT_ONE,
                 "sptrRef->GetSptrRefCount() did not equal EXPECTED_REF_COUNT_ONE", state);
diff --git a/base/test/unittest/common/utils_refbase_test.cpp b/base/test/unittest/common/utils_refbase_test.cpp
index 6672314..31a165d 100644
--- a/base/test/unittest/common/utils_refbase_test.cpp
+++ b/base/test/unittest/common/utils_refbase_test.cpp
@@ -304,6 +304,7 @@ int RegisterEventThread()
     int handle = 10;
     for (int i = 0; i < CYCLE_NUM2; i++) {
         sptr<IRemoteObject> remote = ipc.FindOrNewObject(handle);
+        remote->CheckIsAttemptAcquireSet(remote);
         if (remote) {
             remote->IsProxyObject();
         }
@@ -348,10 +349,12 @@ HWTEST_F(UtilsRefbaseTest, testRefbaseOperateNull001, TestSize.Level0)
 
     remoteObject->IncWeakRef(nullptr);
     remoteObject->IncStrongRef(nullptr);
+    remoteObject->CheckIsAttemptAcquireSet(nullptr);
     remoteObject->DecStrongRef(nullptr);
     remoteObject->AttemptAcquire(this);
 
     remoteObject->IncStrongRef(nullptr);
+    remoteObject->CheckIsAttemptAcquireSet(nullptr);
     remoteObject->DecStrongRef(nullptr);
 
     remoteObject->DecWeakRef(nullptr);
@@ -468,6 +471,7 @@ HWTEST_F(UtilsRefbaseTest, testRefbaseAcquire001, TestSize.Level0)
     EXPECT_EQ(testobject->GetSptrRefCount(), 1);
     {
         EXPECT_TRUE(testobject->IsAttemptAcquireSet());
+        testobject->CheckIsAttemptAcquireSet(this);
         sptr<RefBaseTest> sptrRef = testobject;
         EXPECT_EQ(sptrRef->GetSptrRefCount(), 1);
         EXPECT_FALSE(testobject->IsAttemptAcquireSet());
-- 
Gitee