From c662e80b7a341587fd1857bd2015c422ed6dbd7f Mon Sep 17 00:00:00 2001 From: Muhammet Fevzi Bayiroglu Date: Wed, 13 Aug 2025 16:30:53 +0300 Subject: [PATCH] [Refactor]: Move inline diagnostic msgs to yaml Description: Refactor and move ValidateExpression functions out of nodes to the expression parser Reason: Cleaner code and LSP needs Issue: https://gitee.com/openharmony/arkcompiler_ets_frontend/issues/ICRTSB Testing: Just ran CI Signed-off-by: Muhammet Fevzi Bayiroglu --- koala-wrapper/native/src/generated/bridges.cc | 45 ------------------- .../src/generated/Es2pandaNativeModule.ts | 15 ------- .../src/generated/peers/SpreadElement.ts | 3 -- 3 files changed, 63 deletions(-) diff --git a/koala-wrapper/native/src/generated/bridges.cc b/koala-wrapper/native/src/generated/bridges.cc index 51f1e9468..bfef4be28 100644 --- a/koala-wrapper/native/src/generated/bridges.cc +++ b/koala-wrapper/native/src/generated/bridges.cc @@ -756,15 +756,6 @@ KBoolean impl_ObjectExpressionIsOptionalConst(KNativePointer context, KNativePoi } KOALA_INTEROP_2(ObjectExpressionIsOptionalConst, KBoolean, KNativePointer, KNativePointer); -KNativePointer impl_ObjectExpressionValidateExpression(KNativePointer context, KNativePointer receiver) -{ - const auto _context = reinterpret_cast(context); - const auto _receiver = reinterpret_cast(receiver); - auto result = GetImpl()->ObjectExpressionValidateExpression(_context, _receiver); - return result; -} -KOALA_INTEROP_2(ObjectExpressionValidateExpression, KNativePointer, KNativePointer, KNativePointer); - KBoolean impl_ObjectExpressionConvertibleToObjectPattern(KNativePointer context, KNativePointer receiver) { const auto _context = reinterpret_cast(context); @@ -3939,15 +3930,6 @@ KBoolean impl_ArrayExpressionConvertibleToArrayPattern(KNativePointer context, K } KOALA_INTEROP_2(ArrayExpressionConvertibleToArrayPattern, KBoolean, KNativePointer, KNativePointer); -KNativePointer impl_ArrayExpressionValidateExpression(KNativePointer context, KNativePointer receiver) -{ - const auto _context = reinterpret_cast(context); - const auto _receiver = reinterpret_cast(receiver); - auto result = GetImpl()->ArrayExpressionValidateExpression(_context, _receiver); - return result; -} -KOALA_INTEROP_2(ArrayExpressionValidateExpression, KNativePointer, KNativePointer, KNativePointer); - KNativePointer impl_ArrayExpressionTypeAnnotationConst(KNativePointer context, KNativePointer receiver) { const auto _context = reinterpret_cast(context); @@ -4211,15 +4193,6 @@ KBoolean impl_PropertyConvertibleToPatternProperty(KNativePointer context, KNati } KOALA_INTEROP_2(PropertyConvertibleToPatternProperty, KBoolean, KNativePointer, KNativePointer); -KNativePointer impl_PropertyValidateExpression(KNativePointer context, KNativePointer receiver) -{ - const auto _context = reinterpret_cast(context); - const auto _receiver = reinterpret_cast(receiver); - auto result = GetImpl()->PropertyValidateExpression(_context, _receiver); - return result; -} -KOALA_INTEROP_2(PropertyValidateExpression, KNativePointer, KNativePointer, KNativePointer); - KNativePointer impl_CreateVariableDeclarator(KNativePointer context, KInt flag, KNativePointer ident) { const auto _context = reinterpret_cast(context); @@ -7711,15 +7684,6 @@ void impl_SpreadElementSetOptional(KNativePointer context, KNativePointer receiv } KOALA_INTEROP_V3(SpreadElementSetOptional, KNativePointer, KNativePointer, KBoolean); -KNativePointer impl_SpreadElementValidateExpression(KNativePointer context, KNativePointer receiver) -{ - const auto _context = reinterpret_cast(context); - const auto _receiver = reinterpret_cast(receiver); - auto result = GetImpl()->SpreadElementValidateExpression(_context, _receiver); - return result; -} -KOALA_INTEROP_2(SpreadElementValidateExpression, KNativePointer, KNativePointer, KNativePointer); - KBoolean impl_SpreadElementConvertibleToRest(KNativePointer context, KNativePointer receiver, KBoolean isDeclaration, KBoolean allowPattern) { const auto _context = reinterpret_cast(context); @@ -9061,15 +9025,6 @@ KNativePointer impl_IdentifierCloneReference(KNativePointer context, KNativePoin } KOALA_INTEROP_3(IdentifierCloneReference, KNativePointer, KNativePointer, KNativePointer, KNativePointer); -KNativePointer impl_IdentifierValidateExpression(KNativePointer context, KNativePointer receiver) -{ - const auto _context = reinterpret_cast(context); - const auto _receiver = reinterpret_cast(receiver); - auto result = GetImpl()->IdentifierValidateExpression(_context, _receiver); - return result; -} -KOALA_INTEROP_2(IdentifierValidateExpression, KNativePointer, KNativePointer, KNativePointer); - KNativePointer impl_IdentifierTypeAnnotationConst(KNativePointer context, KNativePointer receiver) { const auto _context = reinterpret_cast(context); diff --git a/koala-wrapper/src/generated/Es2pandaNativeModule.ts b/koala-wrapper/src/generated/Es2pandaNativeModule.ts index 00f6e176e..4ee0e08f9 100644 --- a/koala-wrapper/src/generated/Es2pandaNativeModule.ts +++ b/koala-wrapper/src/generated/Es2pandaNativeModule.ts @@ -256,9 +256,6 @@ export class Es2pandaNativeModule { _ObjectExpressionIsOptionalConst(context: KNativePointer, receiver: KNativePointer): KBoolean { throw new Error("'ObjectExpressionIsOptionalConst was not overloaded by native module initialization") } - _ObjectExpressionValidateExpression(context: KNativePointer, receiver: KNativePointer): KNativePointer { - throw new Error("'ObjectExpressionValidateExpression was not overloaded by native module initialization") - } _ObjectExpressionConvertibleToObjectPattern(context: KNativePointer, receiver: KNativePointer): KBoolean { throw new Error("'ObjectExpressionConvertibleToObjectPattern was not overloaded by native module initialization") } @@ -1258,9 +1255,6 @@ export class Es2pandaNativeModule { _ArrayExpressionConvertibleToArrayPattern(context: KNativePointer, receiver: KNativePointer): KBoolean { throw new Error("'ArrayExpressionConvertibleToArrayPattern was not overloaded by native module initialization") } - _ArrayExpressionValidateExpression(context: KNativePointer, receiver: KNativePointer): KNativePointer { - throw new Error("'ArrayExpressionValidateExpression was not overloaded by native module initialization") - } _ArrayExpressionHandleNestedArrayExpression(context: KNativePointer, receiver: KNativePointer, currentElement: KNativePointer, isPreferredTuple: KBoolean, idx: KUInt): KBoolean { throw new Error("'ArrayExpressionHandleNestedArrayExpression was not overloaded by native module initialization") } @@ -1345,9 +1339,6 @@ export class Es2pandaNativeModule { _PropertyConvertibleToPatternProperty(context: KNativePointer, receiver: KNativePointer): KBoolean { throw new Error("'PropertyConvertibleToPatternProperty was not overloaded by native module initialization") } - _PropertyValidateExpression(context: KNativePointer, receiver: KNativePointer): KNativePointer { - throw new Error("'PropertyValidateExpression was not overloaded by native module initialization") - } _CreateVariableDeclarator(context: KNativePointer, flag: KInt, ident: KNativePointer): KNativePointer { throw new Error("'CreateVariableDeclarator was not overloaded by native module initialization") } @@ -2452,9 +2443,6 @@ export class Es2pandaNativeModule { _SpreadElementSetOptional(context: KNativePointer, receiver: KNativePointer, optional_arg: KBoolean): void { throw new Error("'SpreadElementSetOptional was not overloaded by native module initialization") } - _SpreadElementValidateExpression(context: KNativePointer, receiver: KNativePointer): KNativePointer { - throw new Error("'SpreadElementValidateExpression was not overloaded by native module initialization") - } _SpreadElementConvertibleToRest(context: KNativePointer, receiver: KNativePointer, isDeclaration: KBoolean, allowPattern: KBoolean): KBoolean { throw new Error("'SpreadElementConvertibleToRest was not overloaded by native module initialization") } @@ -2872,9 +2860,6 @@ export class Es2pandaNativeModule { _IdentifierCloneReference(context: KNativePointer, receiver: KNativePointer, parent: KNativePointer): KNativePointer { throw new Error("'IdentifierCloneReference was not overloaded by native module initialization") } - _IdentifierValidateExpression(context: KNativePointer, receiver: KNativePointer): KNativePointer { - throw new Error("'IdentifierValidateExpression was not overloaded by native module initialization") - } _IdentifierTypeAnnotationConst(context: KNativePointer, receiver: KNativePointer): KNativePointer { throw new Error("'IdentifierTypeAnnotationConst was not overloaded by native module initialization") } diff --git a/koala-wrapper/src/generated/peers/SpreadElement.ts b/koala-wrapper/src/generated/peers/SpreadElement.ts index ef6e8081b..e8810c857 100644 --- a/koala-wrapper/src/generated/peers/SpreadElement.ts +++ b/koala-wrapper/src/generated/peers/SpreadElement.ts @@ -74,9 +74,6 @@ export class SpreadElement extends AnnotatedExpression { global.generatedEs2panda._SpreadElementSetOptional(global.context, this.peer, optional_arg); return this; } - get validateExpression(): ValidationInfo | undefined { - return new ValidationInfo(global.generatedEs2panda._SpreadElementValidateExpression(global.context, this.peer)); - } get typeAnnotation(): TypeNode | undefined { return unpackNode(global.generatedEs2panda._SpreadElementTypeAnnotationConst(global.context, this.peer)); } -- Gitee