diff --git a/interfaces/inner_kits/native_cpp/src/ipc/lite/ipc_client_stub.cpp b/interfaces/inner_kits/native_cpp/src/ipc/lite/ipc_client_stub.cpp index 3549f3e2a59b1aaa392d7a6985aff5a1177fd9a3..d692823eaf1121d998c3e5899cd457135f9675b9 100644 --- a/interfaces/inner_kits/native_cpp/src/ipc/lite/ipc_client_stub.cpp +++ b/interfaces/inner_kits/native_cpp/src/ipc/lite/ipc_client_stub.cpp @@ -35,9 +35,7 @@ static int32_t ClientIpcInterfaceMsgHandle(const IpcContext *ctx, void *ipcMsg, uint32_t code = 0; GetCode(ipcMsg, &code); - int32_t errCode = DM_OK; - - errCode = IpcCmdRegister::GetInstance().OnIpcCmd(code, *io); + int32_t errCode = IpcCmdRegister::GetInstance().OnIpcCmd(code, *io); LOGI("receive ipc transact code:%u, retCode=%d", code, errCode); FreeBuffer(ctx, ipcMsg); return errCode; diff --git a/services/devicemanagerservice/include/authentication/dm_auth_manager.h b/services/devicemanagerservice/include/authentication/dm_auth_manager.h index 8a73fe200cb302ba463bc545a1f0cc593ba538d5..a0d9f6b9368a65cae6bfe9b3663bce8f16dc9828 100644 --- a/services/devicemanagerservice/include/authentication/dm_auth_manager.h +++ b/services/devicemanagerservice/include/authentication/dm_auth_manager.h @@ -132,12 +132,11 @@ public: int32_t UnAuthenticateDevice(const std::string &pkgName, const std::string &deviceId); int32_t VerifyAuthentication(const std::string &authParam); void OnSessionOpened(int32_t sessionId, int32_t sessionSide, int32_t result); - void OnSessionClosed(int32_t sessionId); + void OnSessionClosed(const int32_t sessionId); void OnDataReceived(int32_t sessionId, std::string message); void OnGroupCreated(int64_t requestId, const std::string &groupId); void OnMemberJoin(int64_t requestId, int32_t status); - // auth state machine int32_t EstablishAuthChannel(const std::string &deviceId); void StartNegotiate(const int32_t &sessionId); void RespNegotiate(const int32_t &sessionId); diff --git a/services/devicemanagerservice/include/dependency/hichain/hichain_connector.h b/services/devicemanagerservice/include/dependency/hichain/hichain_connector.h index d48e2228d7a35a3286e02aea69f98b42397283c5..6e6991d6c242c510f9ba4c65de2af37dcdcc2536 100644 --- a/services/devicemanagerservice/include/dependency/hichain/hichain_connector.h +++ b/services/devicemanagerservice/include/dependency/hichain/hichain_connector.h @@ -56,14 +56,14 @@ public: int32_t RegisterHiChainCallback(std::shared_ptr callback); int32_t UnRegisterHiChainCallback(); int32_t CreateGroup(int64_t requestId, const std::string &groupName); - int32_t AddMember(std::string deviceId, std::string &connectInfo); - int32_t DelMemberFromGroup(std::string groupId, std::string deviceId); + int32_t AddMember(const std::string &deviceId, const std::string &connectInfo); + int32_t DelMemberFromGroup(const std::string &groupId, const std::string &deviceId); int32_t DeleteGroup(std::string &groupId); int32_t DeleteGroup(const int32_t userId, std::string &groupId); - bool IsDevicesInGroup(std::string hostDevice, std::string peerDevice); - int32_t GetRelatedGroups(std::string DeviceId, std::vector &groupList); - int32_t GetGroupInfo(std::string queryParams, std::vector &groupList); - int32_t GetGroupInfo(const int32_t userId, std::string queryParams, std::vector &groupList); + bool IsDevicesInGroup(const std::string &hostDevice, const std::string &peerDevice); + int32_t GetRelatedGroups(const std::string &DeviceId, std::vector &groupList); + int32_t GetGroupInfo(const std::string &queryParams, std::vector &groupList); + int32_t GetGroupInfo(const int32_t userId, const std::string &queryParams, std::vector &groupList); int32_t DeleteTimeOutGroup(const char* deviceId); private: int64_t GenRequestId(); diff --git a/services/devicemanagerservice/src/authentication/dm_auth_manager.cpp b/services/devicemanagerservice/src/authentication/dm_auth_manager.cpp index 0b26255bb37ccd55aeeb17ba55531ae3809f4491..63b9ac954a27628f36e91b366f255a6111acff34 100644 --- a/services/devicemanagerservice/src/authentication/dm_auth_manager.cpp +++ b/services/devicemanagerservice/src/authentication/dm_auth_manager.cpp @@ -243,7 +243,7 @@ void DmAuthManager::OnSessionOpened(int32_t sessionId, int32_t sessionSide, int3 } } -void DmAuthManager::OnSessionClosed(int32_t sessionId) +void DmAuthManager::OnSessionClosed(const int32_t sessionId) { LOGI("DmAuthManager::OnSessionOpened sessionId=%d", sessionId); } diff --git a/services/devicemanagerservice/src/dependency/hichain/hichain_connector.cpp b/services/devicemanagerservice/src/dependency/hichain/hichain_connector.cpp index 33a3b3f61809817280c0e04a5e41e67c12a2ef9e..db8c6e950c693a623b369114dccd494924e050ff 100644 --- a/services/devicemanagerservice/src/dependency/hichain/hichain_connector.cpp +++ b/services/devicemanagerservice/src/dependency/hichain/hichain_connector.cpp @@ -139,7 +139,7 @@ bool HiChainConnector::IsGroupCreated(std::string groupName, GroupInfo &groupInf return false; } -int32_t HiChainConnector::GetGroupInfo(std::string queryParams, std::vector &groupList) +int32_t HiChainConnector::GetGroupInfo(const std::string &queryParams, std::vector &groupList) { char *groupVec = nullptr; uint32_t num = 0; @@ -178,7 +178,8 @@ int32_t HiChainConnector::GetGroupInfo(std::string queryParams, std::vector &groupList) +int32_t HiChainConnector::GetGroupInfo(const int32_t userId, const std::string &queryParams, + std::vector &groupList) { char *groupVec = nullptr; uint32_t num = 0; @@ -195,7 +196,7 @@ int32_t HiChainConnector::GetGroupInfo(const int32_t userId, std::string queryPa LOGE("HiChainConnector::GetGroupInfo group failed, groupNum is 0."); return false; } - LOGI("HiChainConnector::GetGroupInfo group(%s), groupNum(%d)", groupVec, num); + LOGI("HiChainConnector::GetGroupInfo group(%s), groupNum(%lu)", groupVec, num); std::string relatedGroups = std::string(groupVec); deviceGroupManager_->destroyInfo(&groupVec); nlohmann::json jsonObject = nlohmann::json::parse(relatedGroups); @@ -212,7 +213,7 @@ int32_t HiChainConnector::GetGroupInfo(const int32_t userId, std::string queryPa return true; } -int32_t HiChainConnector::AddMember(std::string deviceId, std::string &connectInfo) +int32_t HiChainConnector::AddMember(const std::string &deviceId, const std::string &connectInfo) { LOGI("HiChainConnector::AddMember"); if (deviceGroupManager_ == nullptr) { @@ -299,8 +300,7 @@ char *HiChainConnector::onRequest(int64_t requestId, int operationCode, const ch LOGE("HiChainAuthCallBack::onRequest operationCode %d", operationCode); return nullptr; } - int32_t pinCode = 0; - pinCode = hiChainConnectorCallback_->GetPinCode(); + int32_t pinCode = hiChainConnectorCallback_->GetPinCode(); nlohmann::json jsonObj; if (pinCode == DM_FAILED) { jsonObj[FIELD_CONFIRMATION] = REQUEST_REJECTED; @@ -324,8 +324,7 @@ int64_t HiChainConnector::GenRequestId() std::string HiChainConnector::GetConnectPara(std::string deviceId, std::string reqDeviceId) { - std::string connectAddr = ""; - connectAddr = hiChainConnectorCallback_->GetConnectAddr(deviceId); + std::string connectAddr = hiChainConnectorCallback_->GetConnectAddr(deviceId); LOGE("HiChainConnector::GetConnectPara get addrInfo"); nlohmann::json jsonObject = nlohmann::json::parse(connectAddr, nullptr, false); if (jsonObject.is_discarded()) { @@ -337,7 +336,7 @@ std::string HiChainConnector::GetConnectPara(std::string deviceId, std::string r return jsonObject.dump(); } -int32_t HiChainConnector::GetRelatedGroups(std::string deviceId, std::vector &groupList) +int32_t HiChainConnector::GetRelatedGroups(const std::string &deviceId, std::vector &groupList) { LOGI("HiChainConnector::GetRelatedGroups Start to get local related groups."); uint32_t groupNum = 0; @@ -368,7 +367,7 @@ int32_t HiChainConnector::GetRelatedGroups(std::string deviceId, std::vector groupInfos = jsonObject.get>(); - if (groupInfos.size() == 0) { + if (groupInfos.empty()) { LOGE("HiChainConnector::GetRelatedGroups group failed, groupInfos is empty."); return DM_FAILED; } @@ -391,7 +390,7 @@ int32_t HiChainConnector::GetSyncGroupList(std::vector &groupList, st return DM_OK; } -bool HiChainConnector::IsDevicesInGroup(std::string hostDevice, std::string peerDevice) +bool HiChainConnector::IsDevicesInGroup(const std::string &hostDevice, const std::string &peerDevice) { LOGE("HiChainConnector::IsDevicesInGroup"); std::vector hostGroupInfoList; @@ -434,7 +433,7 @@ int32_t HiChainConnector::SyncGroups(std::string deviceId, std::vector