From 0a42df97462633bf3c1e3fbcd11135a60a73bcb2 Mon Sep 17 00:00:00 2001
From: tangfan <tangfan5@huawei.com>
Date: Thu, 27 Oct 2022 20:12:18 +0800
Subject: [PATCH] fix cppcheck

Signed-off-by: tangfan <tangfan5@huawei.com>
---
 .../src/task/offline_task.cpp                             | 2 +-
 .../src/task/online_task.cpp                              | 2 +-
 .../test/unittest/common/task/src/mock_offline_task.cpp   | 2 +-
 utils/test/fuzztest/utils_fuzzer/utils_fuzzer.cpp         | 8 ++++----
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/services/distributedhardwarefwkservice/src/task/offline_task.cpp b/services/distributedhardwarefwkservice/src/task/offline_task.cpp
index d73ae1f4..de8508e6 100644
--- a/services/distributedhardwarefwkservice/src/task/offline_task.cpp
+++ b/services/distributedhardwarefwkservice/src/task/offline_task.cpp
@@ -54,7 +54,7 @@ void OffLineTask::DoTaskInner()
 {
     DHLOGD("start offline task, id = %s, uuid = %s", GetId().c_str(), GetAnonyString(GetUUID()).c_str());
     this->SetTaskState(TaskState::RUNNING);
-    for (auto& step : this->GetTaskSteps()) {
+    for (const auto& step : this->GetTaskSteps()) {
         switch (step) {
             case TaskStep::UNREGISTER_OFFLINE_DISTRIBUTED_HARDWARE: {
                 CreateDisableTask();
diff --git a/services/distributedhardwarefwkservice/src/task/online_task.cpp b/services/distributedhardwarefwkservice/src/task/online_task.cpp
index 8f65bb36..b5475d40 100644
--- a/services/distributedhardwarefwkservice/src/task/online_task.cpp
+++ b/services/distributedhardwarefwkservice/src/task/online_task.cpp
@@ -47,7 +47,7 @@ void OnLineTask::DoTask()
 {
     DHLOGD("start online task, id = %s, uuid = %s", GetId().c_str(), GetAnonyString(GetUUID()).c_str());
     this->SetTaskState(TaskState::RUNNING);
-    for (auto& step : this->GetTaskSteps()) {
+    for (const auto& step : this->GetTaskSteps()) {
         switch (step) {
             case TaskStep::SYNC_ONLINE_INFO: {
                 DoSyncInfo();
diff --git a/services/distributedhardwarefwkservice/test/unittest/common/task/src/mock_offline_task.cpp b/services/distributedhardwarefwkservice/test/unittest/common/task/src/mock_offline_task.cpp
index ad52c38f..b30914ec 100644
--- a/services/distributedhardwarefwkservice/test/unittest/common/task/src/mock_offline_task.cpp
+++ b/services/distributedhardwarefwkservice/test/unittest/common/task/src/mock_offline_task.cpp
@@ -30,7 +30,7 @@ MockOffLineTask::MockOffLineTask(const std::string &networkId, const std::string
 
 void MockOffLineTask::CreateDisableTask()
 {
-    for (auto &devInfo : offLineDevInfos) {
+    for (const auto &devInfo : offLineDevInfos) {
         TaskParam taskParam = {
             .networkId = devInfo.networkId,
             .uuid = devInfo.uuid,
diff --git a/utils/test/fuzztest/utils_fuzzer/utils_fuzzer.cpp b/utils/test/fuzztest/utils_fuzzer/utils_fuzzer.cpp
index e1b65aa1..69b35ced 100644
--- a/utils/test/fuzztest/utils_fuzzer/utils_fuzzer.cpp
+++ b/utils/test/fuzztest/utils_fuzzer/utils_fuzzer.cpp
@@ -31,7 +31,7 @@ void GetAnonyStringTest(const uint8_t* data, size_t size)
     }
 
     std::string str(reinterpret_cast<const char*>(data), size);
-    std::string anonyStr = GetAnonyString(str);
+    GetAnonyString(str);
 }
 
 void GetAnonyInt32Test(const uint8_t* data, size_t size)
@@ -41,7 +41,7 @@ void GetAnonyInt32Test(const uint8_t* data, size_t size)
     }
 
     int32_t i = *(reinterpret_cast<const int32_t*>(data));
-    std::string anonyStr = GetAnonyInt32(i);
+    GetAnonyInt32(i);
 }
 
 void UtilsToolTest(const uint8_t* data, size_t size)
@@ -52,8 +52,8 @@ void UtilsToolTest(const uint8_t* data, size_t size)
 
     std::string networkId(reinterpret_cast<const char*>(data), size);
     std::string uuid(reinterpret_cast<const char*>(data), size);
-    std::string uuidStr = GetUUIDBySoftBus(networkId);
-    std::string deviceIdStr = GetDeviceIdByUUID(uuid);
+    GetUUIDBySoftBus(networkId);
+    GetDeviceIdByUUID(uuid);
 }
 }
 }
-- 
Gitee