From 7e828bfea89f1a227d2cbb901a0b9d378cb2c301 Mon Sep 17 00:00:00 2001
From: YOUR_NAME <xieyingdong1@huawei.com>
Date: Thu, 16 Sep 2021 07:14:53 +0000
Subject: [PATCH] solve the warning

Signed-off-by: YOUR_NAME <xieyingdong1@huawei.com>
---
 model/display/driver/backlight/hdf_bl.c   |  1 -
 model/display/driver/hdf_disp.c           | 21 ++++++++++++++++-----
 model/display/driver/hdf_disp.h           |  1 -
 model/display/driver/panel/ili9881c_boe.c |  1 +
 model/display/driver/panel/mipi_icn9700.c |  1 +
 5 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/model/display/driver/backlight/hdf_bl.c b/model/display/driver/backlight/hdf_bl.c
index 1f0743961..8caa4f59b 100644
--- a/model/display/driver/backlight/hdf_bl.c
+++ b/model/display/driver/backlight/hdf_bl.c
@@ -9,7 +9,6 @@
 #include "hdf_bl.h"
 #include <securec.h>
 #include "hdf_base.h"
-#include "hdf_disp.h"
 #include "hdf_log.h"
 #include "osal.h"
 
diff --git a/model/display/driver/hdf_disp.c b/model/display/driver/hdf_disp.c
index 4cf12379c..902b3b269 100644
--- a/model/display/driver/hdf_disp.c
+++ b/model/display/driver/hdf_disp.c
@@ -9,6 +9,7 @@
 #include "hdf_disp.h"
 #include <securec.h>
 #include "hdf_base.h"
+#include "hdf_bl.h"
 #include "hdf_log.h"
 #include "osal.h"
 
@@ -172,7 +173,7 @@ static int32_t SetDispPower(uint32_t devId, uint32_t powerStatus)
     OsalMutexLock(&disp->dispMutex);
     if (panel->powerStatus == powerStatus) {
         OsalMutexUnlock(&disp->dispMutex);
-        HDF_LOGE("%s:devId[%d] already in mode = %d", __func__, devId, powerStatus);
+        HDF_LOGE("%s: panel already in mode = %d", __func__, powerStatus);
         return HDF_SUCCESS;
     }
     switch (powerStatus) {
@@ -394,6 +395,10 @@ static void EsdTimerHandler(uintptr_t arg)
     struct DispManager *disp = NULL;
 
     disp = GetDispManager();
+    if ((disp == NULL) || (disp->esd == NULL)) {
+        HDF_LOGE("%s: disp or esd is null", __func__);
+        return;
+    }
     if (devId >= disp->esd->panelNum) {
         HDF_LOGE("%s: esd is null", __func__);
         return;
@@ -410,14 +415,20 @@ static void EsdWorkHandler(void *arg)
     struct DispManager *disp = NULL;
 
     disp = GetDispManager();
+    if ((disp == NULL) || (disp->panelManager == NULL)) {
+        HDF_LOGE("%s: disp or panelManager is null", __func__);
+        return;
+    }
     if (devId >= disp->panelManager->panelNum) {
         HDF_LOGE("%s: dispCtrl is null or panel is null", __func__);
         return;
     }
     panel = disp->panelManager->panel[devId];
-    if ((panel->esd != NULL) && (panel->esd->checkFunc != NULL)) {
-        ret = panel->esd->checkFunc(panel);
+    if ((panel->esd == NULL) || (panel->esd->checkFunc == NULL)) {
+        HDF_LOGE("%s: esd or checkFunc is null", __func__);
+        return;
     }
+    ret = panel->esd->checkFunc(panel);
     if (ret != HDF_SUCCESS) {
         OsalMutexLock(&disp->dispMutex);
         if (panel->esd->state == ESD_RUNNING) {
@@ -460,7 +471,7 @@ static void EsdCheckStartUp(struct DispEsd *esd, uint32_t devId)
                 EsdTimerHandler, (uintptr_t)devId);
             OsalTimerStartLoop(esd->timer[devId]);
             esd->panelEsd[devId]->state = ESD_RUNNING;
-            HDF_LOGI("%s devId[%d] enable esd check", __func__, devId);
+            HDF_LOGI("%s panel enable esd check", __func__);
         }
     }
 }
@@ -477,7 +488,7 @@ static void EsdCheckEnd(struct DispEsd *esd, uint32_t devId)
         if (esd->panelEsd[devId]->state == ESD_RUNNING) {
             OsalTimerDelete(esd->timer[devId]);
             esd->panelEsd[devId]->state = ESD_READY;
-            HDF_LOGI("%s devId[%d], disable esd check", __func__, devId);
+            HDF_LOGI("%s panel disable esd check", __func__);
         }
     }
 }
diff --git a/model/display/driver/hdf_disp.h b/model/display/driver/hdf_disp.h
index d9c6d9de1..8f497d596 100644
--- a/model/display/driver/hdf_disp.h
+++ b/model/display/driver/hdf_disp.h
@@ -10,7 +10,6 @@
 #define HDF_DISP_H
 
 #include "hdf_base.h"
-#include "hdf_bl.h"
 #include "hdf_device_desc.h"
 #include "hdf_log.h"
 #include "hdf_sbuf.h"
diff --git a/model/display/driver/panel/ili9881c_boe.c b/model/display/driver/panel/ili9881c_boe.c
index 96945d70f..00a8e4788 100644
--- a/model/display/driver/panel/ili9881c_boe.c
+++ b/model/display/driver/panel/ili9881c_boe.c
@@ -8,6 +8,7 @@
 
 #include "ili9881c_boe.h"
 #include "gpio_if.h"
+#include "hdf_bl.h"
 #include "hdf_disp.h"
 #include "osal.h"
 
diff --git a/model/display/driver/panel/mipi_icn9700.c b/model/display/driver/panel/mipi_icn9700.c
index f26994b8f..99c1d49d5 100644
--- a/model/display/driver/panel/mipi_icn9700.c
+++ b/model/display/driver/panel/mipi_icn9700.c
@@ -7,6 +7,7 @@
  */
 
 #include "gpio_if.h"
+#include "hdf_bl.h"
 #include "hdf_disp.h"
 #include "hdf_log.h"
 #include "mipi_dsi_if.h"
-- 
Gitee