diff --git a/interfaces/inner_api/file_access/src/file_access_ext_ability.cpp b/interfaces/inner_api/file_access/src/file_access_ext_ability.cpp index 3a16de4c5b171a1a7eaae54f5895190200ae462b..281f2a8c88d08344126440b51e59bf797de29552 100644 --- a/interfaces/inner_api/file_access/src/file_access_ext_ability.cpp +++ b/interfaces/inner_api/file_access/src/file_access_ext_ability.cpp @@ -37,10 +37,12 @@ void FileAccessExtAbility::SetCreator(const CreatorFunc &creator) FileAccessExtAbility* FileAccessExtAbility::Create(const std::unique_ptr &runtime) { if (runtime == nullptr) { + HILOG_ERROR("Create runtime is nullptr"); return new FileAccessExtAbility(); } if (creator_) { + HILOG_ERROR("Create creator_ is nullptr"); return creator_(runtime); } diff --git a/interfaces/inner_api/file_access/src/file_access_ext_proxy.cpp b/interfaces/inner_api/file_access/src/file_access_ext_proxy.cpp index 09273855d87f2024821b26a5ebe5201b5b278a13..c7b511f9a8153ef7f99cfe68fbac17b300cadb7e 100644 --- a/interfaces/inner_api/file_access/src/file_access_ext_proxy.cpp +++ b/interfaces/inner_api/file_access/src/file_access_ext_proxy.cpp @@ -585,6 +585,7 @@ int FileAccessExtProxy::ListFile(const FileInfo &fileInfo, const int64_t offset, int ret = WriteFileFilterFuncArguments(data, std::make_tuple(&fileInfo, offset, &filter, &memInfo)); if (ret != ERR_OK) { + HILOG_ERROR("WriteFileFilterFuncArguments failed err: %{public}d", ret); return ret; } diff --git a/interfaces/inner_api/file_access/src/file_access_ext_stub.cpp b/interfaces/inner_api/file_access/src/file_access_ext_stub.cpp index c341a4ad15a6ee8bc635ce7fe07021d67eb2b351..0550f427f08d4f5be5d6d02b636c11e0b4828658 100644 --- a/interfaces/inner_api/file_access/src/file_access_ext_stub.cpp +++ b/interfaces/inner_api/file_access/src/file_access_ext_stub.cpp @@ -438,10 +438,12 @@ ErrCode FileAccessExtStub::CmdListFile(MessageParcel &data, MessageParcel &reply std::tie(ret, fileInfo, offset, filter, memInfo) = ReadFileFilterFuncArguments(data); if (ret != ERR_OK) { + HILOG_ERROR("ListFile ReadFileFilterFuncArguments error"); return ret; } ret = SharedMemoryOperation::MapSharedMemory(*memInfo); if (ret != ERR_OK) { + HILOG_ERROR("ListFile MapSharedMemory error"); return ret; } diff --git a/interfaces/inner_api/file_access/src/file_access_helper.cpp b/interfaces/inner_api/file_access/src/file_access_helper.cpp index 6bbd80be4e01d9ed1590fee7abc321c7bbb533af..cbd85f1856151172a804e78e47ba03d2e2f4d250 100644 --- a/interfaces/inner_api/file_access/src/file_access_helper.cpp +++ b/interfaces/inner_api/file_access/src/file_access_helper.cpp @@ -96,11 +96,13 @@ sptr FileAccessHelper::GetBundleMgrProxy() sptr systemAbilityManager = SystemAbilityManagerClient::GetInstance().GetSystemAbilityManager(); if (!systemAbilityManager) { + HILOG_ERROR("systemAbilityManager error"); return nullptr; } sptr remoteObject = systemAbilityManager->GetSystemAbility(BUNDLE_MGR_SERVICE_SYS_ABILITY_ID); if (!remoteObject) { + HILOG_ERROR("remoteObject error"); return nullptr; } diff --git a/interfaces/kits/native/recent/recent_n_exporter.cpp b/interfaces/kits/native/recent/recent_n_exporter.cpp index 1695d1581733880a1f9a37b4a1a440ecc2784861..85af5524f4da17fdd94a139638d61960bf954895 100644 --- a/interfaces/kits/native/recent/recent_n_exporter.cpp +++ b/interfaces/kits/native/recent/recent_n_exporter.cpp @@ -164,7 +164,7 @@ static void Deleter(struct NameListArg *arg) (arg->namelist)[i] = nullptr; } free(arg->namelist); - free(arg); + delete arg; arg = nullptr; } diff --git a/interfaces/kits/picker/picker.js b/interfaces/kits/picker/picker.js index b12bd07e6abdb176b12533c421b3d533276c9ed1..7b3ded416efc3281b270239d6e5da3818387e916 100644 --- a/interfaces/kits/picker/picker.js +++ b/interfaces/kits/picker/picker.js @@ -548,7 +548,6 @@ function getSelectedSuffixIndex() { console.log('[picker] Get Selected Suffix Index end: ' + index); return index; } - async function sendResult(args, result) { try { if (result === undefined) { diff --git a/services/file_extension_hap/entry/src/main/ets/FileExtensionAbility/Common.ts b/services/file_extension_hap/entry/src/main/ets/FileExtensionAbility/Common.ts index d8e2c59d44fb123d3c80939b2e5c77590cc9e190..c09b24f6a95841089f27ff4835a2eceab10ddde0 100644 --- a/services/file_extension_hap/entry/src/main/ets/FileExtensionAbility/Common.ts +++ b/services/file_extension_hap/entry/src/main/ets/FileExtensionAbility/Common.ts @@ -26,7 +26,7 @@ function checkUri(uri: string): boolean { hilog.info(DOMAIN_CODE, TAG, 'uri is ' + uri); return true; } else { - hilog.error(DOMAIN_CODE, TAG, 'checkUri error, uri is ' + uri); + hilog.error(DOMAIN_CODE, TAG, 'checkUri failed, uri is ' + uri); return false; } } catch (error) { @@ -47,7 +47,7 @@ function getPath(uri): string { if (arr[1].indexOf('/') > 0 && arr[1].split('/')[0] === BUNDLE_NAME) { path = path.replace(arr[1].split('/')[0], ''); } else { - hilog.error(DOMAIN_CODE, TAG, 'getPath-parameter-uri format exception, uri is ' + uri); + hilog.error(DOMAIN_CODE, TAG, 'getPath-parameter-uri format exception, uri = ' + uri); return ''; } diff --git a/services/file_extension_hap/entry/src/main/ets/FileExtensionAbility/FileExtensionAbility.ts b/services/file_extension_hap/entry/src/main/ets/FileExtensionAbility/FileExtensionAbility.ts index 0a5283064047df1bc3d1d391faff099483092074..7f2c77b6c5bed97e7b0070d7468d918af9eaecf0 100644 --- a/services/file_extension_hap/entry/src/main/ets/FileExtensionAbility/FileExtensionAbility.ts +++ b/services/file_extension_hap/entry/src/main/ets/FileExtensionAbility/FileExtensionAbility.ts @@ -811,7 +811,7 @@ export default class FileExtAbility extends Extension { try { roots = roots.concat(getHmdfsPath()); } catch (e) { - hilog.info(DOMAIN_CODE, TAG, 'getRoots errorcode: ' + e.code, ' message: ' + e.message); + hilog.info(DOMAIN_CODE, TAG, 'getRoots failed errorcode is: ' + e.code, ' message: ' + e.message); } return rootsReturnObject(roots, ERR_OK); diff --git a/utils/file_util.h b/utils/file_util.h index 32487323b07cd6f52fbc6d30c72d3722499cb7f5..e937c8e4b56c597b8fbf8c73d5512e94d453c379 100644 --- a/utils/file_util.h +++ b/utils/file_util.h @@ -57,7 +57,7 @@ static void Deleter(struct NameListArg *arg) (arg->namelist)[i] = nullptr; } free(arg->namelist); - free(arg); + delete arg; arg = nullptr; }