diff --git a/frameworks/native/format.cpp b/frameworks/native/format.cpp index 55d84810476f3d6f8d8727e20b03e7adbd177267..b814ed70686f2fdcdbd05dd7383a609c448ae8e8 100644 --- a/frameworks/native/format.cpp +++ b/frameworks/native/format.cpp @@ -160,7 +160,7 @@ void HilogShowBuffer(char* buffer, int bufLen, const HilogShowFormatBuffer& cont logLen += ((ret > 0) ? ret : 0); ret = snprintf_s(buffer + logLen, bufLen - logLen, bufLen - logLen - 1, " %s", contentOut.data + contentOut.tag_len); - logLen += ((ret > 0) ? ret : 0); + logLen += ((ret > 0) ? ret : 0); } } } diff --git a/frameworks/native/hilog_printf.cpp b/frameworks/native/hilog_printf.cpp index d40da43d14e476761b49f5ffbd26ce6f4e8a3a84..2541ec9cbf1b3b42caef1bbda2750d568226977b 100644 --- a/frameworks/native/hilog_printf.cpp +++ b/frameworks/native/hilog_printf.cpp @@ -117,11 +117,11 @@ static uint32_t ParseProcessQuota() break; } ret = sscanf_s(quotaValue, "%d", &proQuota); - if (ret != 0) { + if (ret <= 0) { cout << "invalid quota config" << endl; } break; - } + } } ifs.close(); return proQuota; diff --git a/services/hilogd/log_buffer.cpp b/services/hilogd/log_buffer.cpp index d1f162ce4512adabca333e017aaf3b4c9547e167..7a4e68356ffef06eca30dca42505de73a323fc4c 100644 --- a/services/hilogd/log_buffer.cpp +++ b/services/hilogd/log_buffer.cpp @@ -231,7 +231,7 @@ void HilogBuffer::RemoveLogReader(std::shared_ptr reader) { logReaderListMutex.lock(); const auto findIter = std::find_if(logReaderList.begin(), logReaderList.end(), - [reader](const std::weak_ptr& ptr0) { + [&reader](const std::weak_ptr& ptr0) { return ptr0.lock() == reader; }); if (findIter != logReaderList.end()) {