diff --git a/frameworks/inputmethod_ability/include/event_target.h b/frameworks/inputmethod_ability/include/event_target.h index afd0c49248d0e9a3902cc980759bcfb03d83a338..e4aa7509a3f686d77fa98fd9864075f8a98018e8 100644 --- a/frameworks/inputmethod_ability/include/event_target.h +++ b/frameworks/inputmethod_ability/include/event_target.h @@ -45,6 +45,9 @@ namespace MiscServices { napi_ref thisVarRef_; EventListener *first_; EventListener *last_; + + private: + static const int LISTENER_TYPTE_MAX_LENGTH = 64; }; } } diff --git a/frameworks/inputmethod_ability/src/event_target.cpp b/frameworks/inputmethod_ability/src/event_target.cpp index 4c6f1b032f04058bf1d970829101b6c5b40eb1f8..f769c719c1827675fc71f09d5586c5d515c60d45 100644 --- a/frameworks/inputmethod_ability/src/event_target.cpp +++ b/frameworks/inputmethod_ability/src/event_target.cpp @@ -19,10 +19,10 @@ #include "utils/log.h" #include "input_method_ability.h" -#define LISTENER_TYPTE_MAX_LENGTH 64 namespace OHOS { namespace MiscServices { struct EventListener { + static const int LISTENER_TYPTE_MAX_LENGTH = 64; char type[LISTENER_TYPTE_MAX_LENGTH] = { 0 }; bool isOnce = false; napi_ref handlerRef = nullptr; @@ -181,6 +181,7 @@ namespace MiscServices { uv_work_t *work = new (std::nothrow) uv_work_t; if (work == nullptr) { IMSA_HILOGI("EventTarget::Emit No memory work == nullptr"); + delete work; return; } @@ -190,7 +191,7 @@ namespace MiscServices { work->data = (void *)eventTargetCB; int ret = uv_queue_work(loop, work, [](uv_work_t *work) {}, [](uv_work_t *work, int status) { - //Js Thread + // Js Thread if (work == nullptr) { IMSA_HILOGI("EventTarget::Emit work == nullptr"); return; @@ -202,13 +203,15 @@ namespace MiscServices { napi_value thisVar = nullptr; napi_get_reference_value(eventTargetCB->env, eventTargetCB->thisVarRef, &thisVar); - for (EventListener *eventListener = eventTargetCB->first; eventListener != nullptr; eventListener = eventListener->next) { + for (EventListener *eventListener = eventTargetCB->first; eventListener != nullptr; + eventListener = eventListener->next) { if (strcmp(eventListener->type, eventTargetCB->type) == 0) { napi_value jsEvent = eventTargetCB->event ? eventTargetCB->event->ToJsObject() : nullptr; napi_value handler = nullptr; napi_value result = nullptr; napi_get_reference_value(eventTargetCB->env, eventListener->handlerRef, &handler); - napi_call_function(eventTargetCB->env, thisVar, handler, jsEvent ? 1 : 0, jsEvent ? &jsEvent : nullptr, &result); + napi_call_function(eventTargetCB->env, thisVar, handler, + jsEvent ? 1 : 0, jsEvent ? &jsEvent : nullptr, &result); if (eventListener->isOnce) { eventTargetCB->eventTarget->Off(eventTargetCB->type, handler); } @@ -219,12 +222,11 @@ namespace MiscServices { if (eventTargetCB) { delete eventTargetCB; } - delete work; }); if (ret != 0) { IMSA_HILOGI("EventTarget::Emit failed to execute libuv work queue"); - delete work; } + delete work; } } } \ No newline at end of file diff --git a/frameworks/inputmethod_ability/src/input_method_ability.cpp b/frameworks/inputmethod_ability/src/input_method_ability.cpp index c14fd5ff083bae4e7634b44ef7aab4f755bcc780..1f3b59d71c64968fe4fcea079ca61137d0b6dbf3 100644 --- a/frameworks/inputmethod_ability/src/input_method_ability.cpp +++ b/frameworks/inputmethod_ability/src/input_method_ability.cpp @@ -32,6 +32,7 @@ namespace MiscServices { InputMethodAbility::InputMethodAbility() : stop_(false) { writeInputChannel = nullptr; + editorAttribute = nullptr; Initialize(); OnConnect(); } @@ -89,8 +90,9 @@ namespace MiscServices { sptr stub2 = stub; if (mImms != nullptr) { mImms->setInputMethodCore(stub2); + } else { + IMSA_HILOGI("InputMethodAbility::OnConnect() mImms is nullptr"); } - IMSA_HILOGI("InputMethodAbility::OnConnect() mImms is nullptr"); return nullptr; } diff --git a/frameworks/inputmethod_ability/src/input_method_agent_proxy.cpp b/frameworks/inputmethod_ability/src/input_method_agent_proxy.cpp index 1e06f7e0fee51d11551dde38f4d2beb030e6038d..e148163178c5366b96c6d4986feb64f542fd9f8d 100644 --- a/frameworks/inputmethod_ability/src/input_method_agent_proxy.cpp +++ b/frameworks/inputmethod_ability/src/input_method_agent_proxy.cpp @@ -19,7 +19,7 @@ namespace OHOS { namespace MiscServices { using namespace ErrorCode; InputMethodAgentProxy::InputMethodAgentProxy(const sptr &object) - : IRemoteProxy(object) + : IRemoteProxy(object) { } diff --git a/frameworks/inputmethod_ability/src/input_method_core_proxy.cpp b/frameworks/inputmethod_ability/src/input_method_core_proxy.cpp index 58dc01ac53609eddf0cd0a056c23aff6ae7d0ff6..113207af51e57db66940e3dd098a42ef14eaa27c 100644 --- a/frameworks/inputmethod_ability/src/input_method_core_proxy.cpp +++ b/frameworks/inputmethod_ability/src/input_method_core_proxy.cpp @@ -21,7 +21,7 @@ namespace OHOS { namespace MiscServices { InputMethodCoreProxy::InputMethodCoreProxy(const OHOS::sptr &impl) - : IRemoteProxy(impl) + : IRemoteProxy(impl) { } diff --git a/frameworks/inputmethod_ability/src/input_method_core_stub.cpp b/frameworks/inputmethod_ability/src/input_method_core_stub.cpp index bf51a666e6a3bd35c8a8ef1d3cc4f73c35fe788c..a0d5a0f667312db50b87b1191cc055277551b3e7 100644 --- a/frameworks/inputmethod_ability/src/input_method_core_stub.cpp +++ b/frameworks/inputmethod_ability/src/input_method_core_stub.cpp @@ -12,8 +12,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -#include -#include #include "message_handler.h" #include "i_input_data_channel.h" #include "input_method_core_stub.h" diff --git a/frameworks/inputmethod_controller/include/input_client_proxy.h b/frameworks/inputmethod_controller/include/input_client_proxy.h index a6324edf847d0dc46371f6c09ec09f289d4da39a..fbac59e8dc17d77b3c34b7c5e25b5541cd36222f 100644 --- a/frameworks/inputmethod_controller/include/input_client_proxy.h +++ b/frameworks/inputmethod_controller/include/input_client_proxy.h @@ -22,13 +22,14 @@ namespace OHOS { namespace MiscServices { -class InputClientProxy : public IRemoteProxy { + class InputClientProxy : public IRemoteProxy { public: explicit InputClientProxy(const sptr &object); ~InputClientProxy() = default; DISALLOW_COPY_AND_MOVE(InputClientProxy); - int32_t onInputReady(int32_t retValue, const sptr& agent, const InputChannel *channel) override; + int32_t onInputReady(int32_t retValue, const sptr& agent, + const InputChannel *channel) override; int32_t onInputReleased(int32_t retValue) override; int32_t setDisplayMode(int32_t mode) override; diff --git a/frameworks/inputmethod_controller/src/input_method_controller.cpp b/frameworks/inputmethod_controller/src/input_method_controller.cpp index 25aeae2f5b1c46155ab395488bdbc44297df00dc..b4c05e7dcf7b2748a8266c711ef8d178ba069038 100644 --- a/frameworks/inputmethod_controller/src/input_method_controller.cpp +++ b/frameworks/inputmethod_controller/src/input_method_controller.cpp @@ -159,7 +159,7 @@ using namespace MessageID; void InputMethodController::Attach(sptr &listener) { PrepareInput(0, mClient, mInputDataChannel, mAttribute); - textListener=listener; + textListener = listener; } void InputMethodController::ShowTextInput() diff --git a/interfaces/kits/js/declaration/api/@ohos.inputmethodengine.d.ts b/interfaces/kits/js/declaration/api/@ohos.inputmethodengine.d.ts index 0d4ef4db27534035b7d01523ced36fcd86f93fd9..6daa45ffff5190bae8a535969cda466ba0dca673 100644 --- a/interfaces/kits/js/declaration/api/@ohos.inputmethodengine.d.ts +++ b/interfaces/kits/js/declaration/api/@ohos.inputmethodengine.d.ts @@ -34,7 +34,7 @@ declare namespace inputMethodEngine { function DeleteBackward(length: number, callback: () => void): void; function DeleteBackward(length: number): Promise; - function HideKeyboardSelf(callback: callback: () => void): void; + function HideKeyboardSelf(callback: () => void): void; function HideKeyboardSelf(): Promise; } diff --git a/services/include/i_platform_api.h b/services/include/i_platform_api.h index 1c7066c50728cc989927cc8586e9fe1e486f3373..006b03955c38361bd34cc0fd07b9fde1f349fa12 100644 --- a/services/include/i_platform_api.h +++ b/services/include/i_platform_api.h @@ -56,7 +56,6 @@ namespace OHOS { InputMethodProperty *inputMethodProperty) = 0; virtual int32_t getInputMethodSetting(int userId, InputMethodSetting *inputMethodSetting) = 0; virtual int32_t setInputMethodSetting(int userId, const InputMethodSetting& inputMethodSetting) = 0; - }; } } diff --git a/services/include/input_method_setting.h b/services/include/input_method_setting.h index 589fa65612d79a6ea7c50421fb8520005104ecac..0594a12457345a99fabb98ece8fe7187e58c45e0 100644 --- a/services/include/input_method_setting.h +++ b/services/include/input_method_setting.h @@ -32,7 +32,6 @@ namespace MiscServices { const static std::u16string CURRENT_SYS_KEYBOARD_TYPE_TAG; // default keyboard type for security IME const static std::u16string SYSTEM_LOCALE_TAG; // locale list supported in the system - InputMethodSetting(); ~InputMethodSetting(); InputMethodSetting(const InputMethodSetting& inputMethodSetting); diff --git a/services/include/input_method_system_ability_stub.h b/services/include/input_method_system_ability_stub.h index ad4d8192a1a96ab752d9a3db7ea2b47237095bdb..c04361ecc78e5f48746f2acec031f3d3b1045506 100644 --- a/services/include/input_method_system_ability_stub.h +++ b/services/include/input_method_system_ability_stub.h @@ -26,7 +26,8 @@ namespace OHOS { namespace MiscServices { class InputMethodSystemAbilityStub : public IRemoteStub { public: - int32_t OnRemoteRequest(uint32_t code, MessageParcel &data, MessageParcel &reply, MessageOption &option) override; + int32_t OnRemoteRequest(uint32_t code, MessageParcel &data, MessageParcel &reply, + MessageOption &option) override; virtual void prepareInput(MessageParcel& data) override; virtual void releaseInput(MessageParcel& data) override; diff --git a/services/include/message_handler.h b/services/include/message_handler.h index b370193c52b027c00dba920a93f6bdfeda47f785..93e894692aae4440e53c2bf267b5ba4e9ddb2f07 100644 --- a/services/include/message_handler.h +++ b/services/include/message_handler.h @@ -58,7 +58,7 @@ namespace MessageID { MSG_ID_SHELL_COMMAND, // shell command MSG_ID_EXIT_SERVICE, // exit service - //the request from IMSA to IMC + // the request from IMSA to IMC MSG_ID_INSERT_CHAR, MSG_ID_DELETE_BACKWARD, MSG_ID_CLOSE, diff --git a/services/include/peruser_session.h b/services/include/peruser_session.h index 77fdbb513245fe3fdd45deb01e861fd2559dbbd5..84b63402c2fa4a4485ae670ae5d4283050920b5c 100644 --- a/services/include/peruser_session.h +++ b/services/include/peruser_session.h @@ -125,6 +125,7 @@ namespace MiscServices { int IME_ERROR_CODE = 3; int COMMON_COUNT_THREE_HUNDRED = 300; int SLEEP_TIME = 300000; + int SLEEP_TIME_MORE = 1600000; InputMethodProperty *currentIme[MAX_IME]; // 0 - the default ime. 1 - security ime diff --git a/services/include/utils.h b/services/include/utils.h index 8312017f0ceecb05115d12576d79572ca6509113..8cb9d01db7eb914378e86681803366078c6c68ba 100644 --- a/services/include/utils.h +++ b/services/include/utils.h @@ -19,7 +19,6 @@ #define FM_IMMS_PROJECT_UTILS_H #include -#include #include #include @@ -27,10 +26,12 @@ namespace OHOS { namespace MiscServices { class Utils { public: - static std::string to_utf8(std::u16string str16) { + static std::string to_utf8(std::u16string str16) + { return std::wstring_convert, char16_t> {}.to_bytes(str16); } - static std::u16string to_utf16(std::string str) { + static std::u16string to_utf16(std::string str) + { return std::wstring_convert, char16_t> {}.from_bytes(str); } }; diff --git a/services/src/input_attribute.cpp b/services/src/input_attribute.cpp index e739e8111975fadf0d88dbadcd3d7daf91398bc6..3e1cb6dc48e2d788b4da4ad745f870d71e759eca 100644 --- a/services/src/input_attribute.cpp +++ b/services/src/input_attribute.cpp @@ -21,6 +21,7 @@ namespace MiscServices { */ InputAttribute::InputAttribute() : enterKeyType(0), inputOption(0) { + inputPattern = PATTERN_TEXT; } /*! Constructor diff --git a/services/src/input_method_ability_connection_stub.cpp b/services/src/input_method_ability_connection_stub.cpp index 88dc89281680f0181a43a9df2ac702b2004bdebf..b5108c998a1b8366aa0b9cfcac065c0a3fc95cad 100644 --- a/services/src/input_method_ability_connection_stub.cpp +++ b/services/src/input_method_ability_connection_stub.cpp @@ -22,6 +22,7 @@ namespace MiscServices { InputMethodAbilityConnectionStub::InputMethodAbilityConnectionStub(const int index) { mIndex = index; + messageHandler = nullptr; } InputMethodAbilityConnectionStub::~InputMethodAbilityConnectionStub() diff --git a/services/src/input_method_property.cpp b/services/src/input_method_property.cpp index 349f82162d0db423bde76110686453fda8725c44..904015035277279108b200756ecf90b2a30dfad3 100644 --- a/services/src/input_method_property.cpp +++ b/services/src/input_method_property.cpp @@ -22,6 +22,7 @@ namespace MiscServices { */ InputMethodProperty::InputMethodProperty() { + mDefaultImeId = 0; } /*! Destructor diff --git a/services/src/input_method_system_ability.cpp b/services/src/input_method_system_ability.cpp index 246dc981239870daf5f0f5a0ed72595cd64dee6b..71b6ddf2d102c0dd84078b19204face0eeda13dc 100644 --- a/services/src/input_method_system_ability.cpp +++ b/services/src/input_method_system_ability.cpp @@ -58,7 +58,7 @@ namespace MiscServices { } std::map::const_iterator it; - for (it = userSessions.cbegin(); it != userSessions.cend();) { + for (it = userSessions.cbegin(); it != userSessions.cend(); ) { PerUserSession *session = it->second; it = userSessions.erase(it); delete session; @@ -66,7 +66,7 @@ namespace MiscServices { } userSessions.clear(); std::map::const_iterator it1; - for (it1 = userSettings.cbegin(); it1 != userSettings.cend();) { + for (it1 = userSettings.cbegin(); it1 != userSettings.cend(); ) { PerUserSetting *setting = it1->second; it1 = userSettings.erase(it1); delete setting; @@ -74,7 +74,7 @@ namespace MiscServices { } userSettings.clear(); std::map::const_iterator it2; - for (it2 = msgHandlers.cbegin(); it2 != msgHandlers.cend();) { + for (it2 = msgHandlers.cbegin(); it2 != msgHandlers.cend(); ) { MessageHandler *handler = it2->second; it2 = msgHandlers.erase(it2); delete handler; diff --git a/services/src/keyboard_type.cpp b/services/src/keyboard_type.cpp index c92fe77400ca1994914c2d59fe3ddc0706efa0b5..237052bf11bb84c728c03d4fa0943c9ea8d1d676 100644 --- a/services/src/keyboard_type.cpp +++ b/services/src/keyboard_type.cpp @@ -110,7 +110,6 @@ namespace MiscServices { } else { mHashCode = ID_NONE; } - } void KeyboardType::setLabelId(int32_t labelId) diff --git a/services/src/peruser_session.cpp b/services/src/peruser_session.cpp index 3be9b5ad56bd2b2588b34cfe19b40e08e11eed93..f0393676c721f550a25ebeae2915ac3af0ac5390 100644 --- a/services/src/peruser_session.cpp +++ b/services/src/peruser_session.cpp @@ -12,15 +12,13 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - -#include "unistd.h" +#include "unistd.h" // usleep #include "platform.h" #include "parcel.h" #include "message_parcel.h" #include "utils.h" #include "want.h" #include "input_method_ability_connection_stub.h" -#include #include "peruser_session.h" #include "ability_connect_callback_proxy.h" #include "ability_manager_interface.h" @@ -713,7 +711,7 @@ namespace MiscServices { parcel->WriteInt32(index); parcel->WriteString16(currentIme[index]->mImeId); Message *msg = new Message(MSG_ID_RESTART_IMS, parcel); - usleep(1600*1000); // wait that PACKAGE_REMOVED message is received if this ime has been removed + usleep(SLEEP_TIME_MORE); // wait that PACKAGE_REMOVED message is received if this ime has been removed MessageHandler::Instance()->SendMessage(msg); } IMSA_HILOGI("End...[%{public}d]\n", userId_); @@ -995,7 +993,7 @@ namespace MiscServices { time_t now = time(0); double diffSeconds = difftime(now, past[imeIndex]); - //time difference is more than 5 minutes, reset time and error num; + // time difference is more than 5 minutes, reset time and error num; if (diffSeconds > COMMON_COUNT_THREE_HUNDRED) { past[imeIndex] = now; errorNum[imeIndex] = 1; diff --git a/services/src/peruser_setting.cpp b/services/src/peruser_setting.cpp index 5dcdf453e8bd81f488cfa59fe28cc4cbd2230b1b..574d92108ee7f7876937850f06beca9f70c6b054 100644 --- a/services/src/peruser_setting.cpp +++ b/services/src/peruser_setting.cpp @@ -12,8 +12,8 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - -#include "unistd.h" + +#include "unistd.h" // usleep #include "peruser_setting.h" #include "platform.h" #include "utils.h" diff --git a/services/src/platform_api_proxy.cpp b/services/src/platform_api_proxy.cpp index 4906fadf7087b0dd4164a14fd517da6a29794ec3..5cf2b198eb12ff8c6a898562a408b89a32f1bf12 100644 --- a/services/src/platform_api_proxy.cpp +++ b/services/src/platform_api_proxy.cpp @@ -76,7 +76,7 @@ namespace MiscServices { return nullptr; } int code = reply.ReadException(); - if (code != 0) {// code = 0, means no exception. + if (code != 0) { // code = 0, means no exception. LOG_DEBUG("exception code : %d\n", code); return nullptr; }