From 3a31dd55a9d29964eb181fbe3333d591f374790c Mon Sep 17 00:00:00 2001 From: wuyajun Date: Tue, 2 Sep 2025 08:17:00 +0000 Subject: [PATCH 1/3] =?UTF-8?q?=E8=B7=B3=E8=BF=87standby=E8=BF=9B=E8=A1=8C?= =?UTF-8?q?=E5=A4=84=E7=90=86?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: wuyajun --- .../server/src/pa_renderer_stream_impl.cpp | 4 ++-- .../pa_renderer_stream_impl_unit_test.cpp | 16 ++++++++++++++++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/services/audio_service/server/src/pa_renderer_stream_impl.cpp b/services/audio_service/server/src/pa_renderer_stream_impl.cpp index 5991643c5a..73d8632781 100644 --- a/services/audio_service/server/src/pa_renderer_stream_impl.cpp +++ b/services/audio_service/server/src/pa_renderer_stream_impl.cpp @@ -201,8 +201,8 @@ int32_t PaRendererStreamImpl::Pause(bool isStandby) return ERR_OPERATION_FAILED; } - AudioVolume::GetInstance()->SetFadeoutState(sinkInputIndex_, DO_FADE); - if (!offloadEnable_) { + if (!offloadEnable_ && !isStandby) { + AudioVolume::GetInstance()->SetFadeoutState(sinkInputIndex_, DO_FADE); palock.Unlock(); { std::unique_lock lock(fadingMutex_); diff --git a/services/audio_service/test/unittest/pa_renderer_stream_impl_unit_test.cpp b/services/audio_service/test/unittest/pa_renderer_stream_impl_unit_test.cpp index bcd669f4f5..05aae6778c 100644 --- a/services/audio_service/test/unittest/pa_renderer_stream_impl_unit_test.cpp +++ b/services/audio_service/test/unittest/pa_renderer_stream_impl_unit_test.cpp @@ -918,5 +918,21 @@ HWTEST_F(PaRendererStreamUnitTest, PaRenderer_051, TestSize.Level1) ReleasePaPort(); #endif } + +/** + * @tc.name : Test Pause. + * @tc.type : FUNC + * @tc.number: PaRenderer_052 + * @tc.desc : Test Pause. + */ +HWTEST_F(PaRendererStreamUnitTest, PaRenderer_052, TestSize.Level1) +{ +auto unit = CreatePaRendererStreamImpl(); +unit->paStream_ = nullptr; +unit->offloadEnable_ = false; +bool isStandby = false; +int32_t ret = unit->Pause(isStandby); +EXPECT_EQ(ret, ERR_ILLEGAL_STATE); +} } } \ No newline at end of file -- Gitee From 8acaca559bdf1bb0dde2d973caeecb79dd93c8a3 Mon Sep 17 00:00:00 2001 From: wuyajun Date: Tue, 2 Sep 2025 08:19:56 +0000 Subject: [PATCH 2/3] update services/audio_service/test/unittest/pa_renderer_stream_impl_unit_test.cpp. Signed-off-by: wuyajun --- .../unittest/pa_renderer_stream_impl_unit_test.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/services/audio_service/test/unittest/pa_renderer_stream_impl_unit_test.cpp b/services/audio_service/test/unittest/pa_renderer_stream_impl_unit_test.cpp index 05aae6778c..375c35f181 100644 --- a/services/audio_service/test/unittest/pa_renderer_stream_impl_unit_test.cpp +++ b/services/audio_service/test/unittest/pa_renderer_stream_impl_unit_test.cpp @@ -927,12 +927,12 @@ HWTEST_F(PaRendererStreamUnitTest, PaRenderer_051, TestSize.Level1) */ HWTEST_F(PaRendererStreamUnitTest, PaRenderer_052, TestSize.Level1) { -auto unit = CreatePaRendererStreamImpl(); -unit->paStream_ = nullptr; -unit->offloadEnable_ = false; -bool isStandby = false; -int32_t ret = unit->Pause(isStandby); -EXPECT_EQ(ret, ERR_ILLEGAL_STATE); + auto unit = CreatePaRendererStreamImpl(); + unit->paStream_ = nullptr; + unit->offloadEnable_ = false; + bool isStandby = false; + int32_t ret = unit->Pause(isStandby); + EXPECT_EQ(ret, ERR_ILLEGAL_STATE); } } } \ No newline at end of file -- Gitee From 67949e9f3f6bf3adee0f1f118dfbb6d084d7a5c2 Mon Sep 17 00:00:00 2001 From: wuyajun Date: Tue, 2 Sep 2025 11:17:52 +0000 Subject: [PATCH 3/3] update services/audio_service/test/unittest/pa_renderer_stream_impl_unit_test.cpp. Signed-off-by: wuyajun --- .../test/unittest/pa_renderer_stream_impl_unit_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/audio_service/test/unittest/pa_renderer_stream_impl_unit_test.cpp b/services/audio_service/test/unittest/pa_renderer_stream_impl_unit_test.cpp index 375c35f181..dab9deaf34 100644 --- a/services/audio_service/test/unittest/pa_renderer_stream_impl_unit_test.cpp +++ b/services/audio_service/test/unittest/pa_renderer_stream_impl_unit_test.cpp @@ -930,7 +930,7 @@ HWTEST_F(PaRendererStreamUnitTest, PaRenderer_052, TestSize.Level1) auto unit = CreatePaRendererStreamImpl(); unit->paStream_ = nullptr; unit->offloadEnable_ = false; - bool isStandby = false; + bool isStandby = false; int32_t ret = unit->Pause(isStandby); EXPECT_EQ(ret, ERR_ILLEGAL_STATE); } -- Gitee