From 4889c0232628a2ce9081a01b32a3611e9e167b77 Mon Sep 17 00:00:00 2001 From: fuxiuwsz Date: Tue, 20 May 2025 17:13:29 +0800 Subject: [PATCH 01/10] qos manager for audio deadline Signed-off-by: fuxiuwsz --- .../idl/IConcurrentTaskService.idl | 1 + .../src/concurrent_task_client.cpp | 12 ++++ interfaces/inner_api/concurrent_task_client.h | 11 ++++ interfaces/inner_api/concurrent_task_type.h | 7 +++ .../concurrent_task_controller_interface.h | 3 + services/include/concurrent_task_service.h | 1 + .../concurrent_task_controller_interface.cpp | 10 ++++ services/src/concurrent_task_service.cpp | 8 +++ .../concurrent_fuzzer/concurrent_fuzzer.cpp | 55 +++++++++++++++++++ .../phone/concurrent_task_client_test.cpp | 13 +++++ ...current_task_controller_interface_test.cpp | 20 +++++++ .../phone/concurrent_task_service_test.cpp | 23 +++++++- test/unittest/phone/func_loader_test.cpp | 1 + 13 files changed, 164 insertions(+), 1 deletion(-) diff --git a/frameworks/concurrent_task_client/idl/IConcurrentTaskService.idl b/frameworks/concurrent_task_client/idl/IConcurrentTaskService.idl index 44c58e9..64e0a73 100644 --- a/frameworks/concurrent_task_client/idl/IConcurrentTaskService.idl +++ b/frameworks/concurrent_task_client/idl/IConcurrentTaskService.idl @@ -20,5 +20,6 @@ [oneway] void ReportSceneInfo([in] unsigned int type, [in] Map payload); void QueryInterval([in] int queryItem, [inout] IpcIntervalReply queryRs); [oneway] void QueryDeadline([in] int queryItem, [in] IpcDeadlineReply IpcDdlReply, [in] Map payload); + void SetAudioDeadline([in] int queryItem, [in] int tid, [in] int grpId, [inout] IpcIntervalReply queryRs); void RequestAuth([in] Map payload); } \ No newline at end of file diff --git a/frameworks/concurrent_task_client/src/concurrent_task_client.cpp b/frameworks/concurrent_task_client/src/concurrent_task_client.cpp index fe5a6ca..ca74e23 100644 --- a/frameworks/concurrent_task_client/src/concurrent_task_client.cpp +++ b/frameworks/concurrent_task_client/src/concurrent_task_client.cpp @@ -108,6 +108,18 @@ void ConcurrentTaskClient::QueryDeadline(int queryItem, DeadlineReply& ddlReply, return; } +void ConcurrentTaskClient::SetAudioDeadline(int queryItem, int tid, int grpId, IntervalReply& queryRs) +{ + if (TryConnect() != ERR_OK) { + CONCUR_LOGE("QueryInterval connnect fail"); + return; + } + IpcIntervalReply IpcQueryRs = QueryRsToIpc(queryRs); + clientService_->SetAudioDeadline(queryItem, tid, grpId, IpcQueryRs); + queryRs = IpcToQueryRs(IpcQueryRs); + return; +} + void ConcurrentTaskClient::RequestAuth(const std::unordered_map& mapPayload) { if (TryConnect() != ERR_OK) { diff --git a/interfaces/inner_api/concurrent_task_client.h b/interfaces/inner_api/concurrent_task_client.h index f56b85b..0510394 100644 --- a/interfaces/inner_api/concurrent_task_client.h +++ b/interfaces/inner_api/concurrent_task_client.h @@ -82,6 +82,17 @@ public: void QueryDeadline(int queryItem, DeadlineReply& ddlReply, const std::unordered_map& mapPayload); + /** + * @brief audio rtg id and other info provided by concurrent task service. + * + * @param queryItem Information of the corresponding query module. + * @param tid Thread number of the audio thread. + * @param grpId The group which will be operate. + * @param queryRs Indicates the context info of the query message. + * + */ + void SetAudioDeadline(int queryItem, int tid, int grpId, IntervalReply& queryRs); + /** * @brief Report auth request data to the concurrent task service. * diff --git a/interfaces/inner_api/concurrent_task_type.h b/interfaces/inner_api/concurrent_task_type.h index c494c42..98024a5 100644 --- a/interfaces/inner_api/concurrent_task_type.h +++ b/interfaces/inner_api/concurrent_task_type.h @@ -61,6 +61,13 @@ enum QueryIntervalItem { QURRY_TYPE_MAX, }; +enum AudioDeadlineType { + AUDIO_DDL_CREATE_GRP = 0, + AUDIO_DDL_DESTORY_GRP, + AUDIO_DDL_ADD_THREAD, + AUDIO_DDL_REMOVE_THREAD, +}; + enum DeadlineType { DDL_RATE = 0, MSG_GAME = 1, diff --git a/services/include/concurrent_task_controller_interface.h b/services/include/concurrent_task_controller_interface.h index 97ee36e..b62fb66 100644 --- a/services/include/concurrent_task_controller_interface.h +++ b/services/include/concurrent_task_controller_interface.h @@ -32,6 +32,7 @@ using ReportDataFunc = void (*)(uint32_t resType, int64_t value, const Json::Val using ReportSceneInfoFunc = void (*)(uint32_t type, const Json::Value& payload); using QueryIntervalFunc = void (*)(int queryItem, IntervalReply& queryRs); using QueryDeadlineFunc = void (*)(int queryItem, DeadlineReply& ddlReply, const Json::Value& payload); +using SetAudioDeadlineFunc = void (*)(int queryItem, int tid, int grpId, IntervalReply& queryRs); using RequestAuthFunc = void (*)(const Json::Value& payload); using InitFunc = void (*)(); using ReleaseFunc = void (*)(); @@ -47,6 +48,7 @@ public: void ReportSceneInfo(uint32_t type, const Json::Value& payload); void QueryInterval(int queryItem, IntervalReply& queryRs); void QueryDeadline(int queryItem, DeadlineReply& ddlReply, const Json::Value& payload); + void SetAudioDeadline(int queryItem, int tid, int grpId, IntervalReply& queryRs); void Init(); void Release(); @@ -61,6 +63,7 @@ private: ReportSceneInfoFunc reportSceneInfoFunc_ = nullptr; QueryIntervalFunc queryIntervalFunc_ = nullptr; QueryDeadlineFunc queryDeadlineFunc_ = nullptr; + SetAudioDeadlineFunc setAudioDeadlineFunc_ = nullptr; RequestAuthFunc requestAuthFunc_ = nullptr; InitFunc initFunc_ = nullptr; ReleaseFunc releaseFunc_ = nullptr; diff --git a/services/include/concurrent_task_service.h b/services/include/concurrent_task_service.h index 3e776e6..fe16574 100644 --- a/services/include/concurrent_task_service.h +++ b/services/include/concurrent_task_service.h @@ -35,6 +35,7 @@ public: ErrCode QueryInterval(int queryItem, IpcIntervalReply& IpcQueryRs) override; ErrCode QueryDeadline(int queryItem, const IpcDeadlineReply& IpcDdlReply, const std::unordered_map& payload) override; + ErrCode SetAudioDeadline(int queryItem, int tid, int grpId, IpcIntervalReply& IpcQueryRs) override; ErrCode RequestAuth(const std::unordered_map& payload) override; Json::Value MapToJson(const std::unordered_map& dataMap); diff --git a/services/src/concurrent_task_controller_interface.cpp b/services/src/concurrent_task_controller_interface.cpp index 2161aed..f70cb6c 100644 --- a/services/src/concurrent_task_controller_interface.cpp +++ b/services/src/concurrent_task_controller_interface.cpp @@ -89,6 +89,15 @@ void TaskControllerInterface::QueryDeadline(int queryItem, DeadlineReply& ddlRep queryDeadlineFunc_(queryItem, ddlReply, payload); } +void TaskControllerInterface::SetAudioDeadline(int queryItem, int tid, int grpId, IntervalReply& queryRs) +{ + if (!inited_) { + CONCUR_LOGE("[TaskControllerInterface] setAudioDeadline failed, funcLoader_ load func failed"); + return; + } + setAudioDeadlineFunc_(queryItem, tid, grpId, queryRs); +} + void TaskControllerInterface::Init() { std::lock_guard autoLock(funcLoaderLock_); @@ -121,6 +130,7 @@ bool TaskControllerInterface::LoadFunc() reportSceneInfoFunc_ = ReportSceneInfoFunc(funcLoader_.LoadSymbol("ReportSceneInfo")); queryIntervalFunc_ = QueryIntervalFunc(funcLoader_.LoadSymbol("QueryInterval")); queryDeadlineFunc_ = QueryDeadlineFunc(funcLoader_.LoadSymbol("QueryDeadline")); + setAudioDeadlineFunc_ = SetAudioDeadlineFunc(funcLoader_.LoadSymbol("SetAudioDeadline")); requestAuthFunc_ = RequestAuthFunc(funcLoader_.LoadSymbol("RequestAuth")); initFunc_ = InitFunc(funcLoader_.LoadSymbol("Init")); releaseFunc_ = ReleaseFunc(funcLoader_.LoadSymbol("Release")); diff --git a/services/src/concurrent_task_service.cpp b/services/src/concurrent_task_service.cpp index ef9aa4e..59ea934 100644 --- a/services/src/concurrent_task_service.cpp +++ b/services/src/concurrent_task_service.cpp @@ -44,6 +44,14 @@ ErrCode ConcurrentTaskService::QueryInterval(int queryItem, IpcIntervalReply& Ip return ERR_OK; } +ErrCode ConcurrentTaskService::SetAudioDeadline(int queryItem, int tid, int grpId, IpcIntervalReply& IpcQueryRs) +{ + IntervalReply queryRs = IpcToQueryRs(IpcQueryRs); + TaskControllerInterface::GetInstance().SetAudioDeadline(queryItem, tid, grpId, queryRs); + IpcQueryRs = QueryRsToIpc(queryRs); + return ERR_OK; +} + ErrCode ConcurrentTaskService::QueryDeadline( int queryItem, const IpcDeadlineReply& IpcDdlReply, const std::unordered_map& payload) { diff --git a/test/fuzztest/concurrent_fuzzer/concurrent_fuzzer.cpp b/test/fuzztest/concurrent_fuzzer/concurrent_fuzzer.cpp index 34bed7e..0f6ee79 100644 --- a/test/fuzztest/concurrent_fuzzer/concurrent_fuzzer.cpp +++ b/test/fuzztest/concurrent_fuzzer/concurrent_fuzzer.cpp @@ -159,6 +159,30 @@ bool FuzzConcurrentTaskServiceQueryDeadline(const uint8_t* data, size_t size) return true; } +bool FuzzConcurrentTaskServiceSetAudioDeadline(const uint8_t* data, size_t size) +{ + g_baseFuzzData = data; + g_baseFuzzSize = size; + g_baseFuzzPos = 0; + if (size > sizeof(int) + sizeof(int)) { + MessageParcel data1; + Parcel parcel; + sptr iremoteobject = IRemoteObject::Unmarshalling(parcel); + int intdata = GetData(); + void *voiddata = &intdata; + size_t size1 = sizeof(int); + data1.WriteRemoteObject(iremoteobject); + data1.WriteRawData(voiddata, size1); + data1.ReadRawData(size1); + MessageParcel reply; + MessageOption option; + uint32_t code = static_cast(IConcurrentTaskServiceIpcCode::COMMAND_SET_AUDIO_DEADLINE); + ConcurrentTaskService s = ConcurrentTaskService(); + s.OnRemoteRequest(code, data1, reply, option); + } + return true; +} + bool FuzzConcurrentTaskServiceRequestAuth(const uint8_t* data, size_t size) { g_baseFuzzData = data; @@ -405,6 +429,20 @@ bool FuzzConcurrentTaskClientQueryDeadline(const uint8_t* data, size_t size) return true; } +bool FuzzConcurrentTaskClientSetAudioDeadline(const uint8_t* data, size_t size) +{ + g_baseFuzzData = data; + g_baseFuzzSize = size; + g_baseFuzzPos = 0; + if (size > sizeof(int) + sizeof(int)) { + int queryItem = GetData(); + queryItem = queryItem % (AUDIO_DDL_REMOVE_THREAD + 1); + IntervalReply queryRs; + ConcurrentTaskClient::GetInstance().SetAudioDeadline(queryItem, 20, 40, queryRs); + } + return true; +} + bool FuzzConcurrentTaskClinetRequestAuth(const uint8_t* data, size_t size) { g_baseFuzzData = data; @@ -492,6 +530,21 @@ bool FuzzConcurrentTaskControllerInterfaceQueryDeadline(const uint8_t* data, siz return true; } +bool FuzzConcurrentTaskControllerInterfaceSetAudioDeadline(const uint8_t* data, size_t size) +{ + g_baseFuzzData = data; + g_baseFuzzSize = size; + g_baseFuzzPos = 0; + if (size > sizeof(int) + sizeof(int)) { + ConcurrentTaskService s = ConcurrentTaskService(); + int queryItem = GetData(); + queryItem = queryItem % (AUDIO_DDL_REMOVE_THREAD + 1); + IntervalReply queryRs; + TaskControllerInterface::GetInstance().SetAudioDeadline(queryItem, 20, 40, queryRs); + } + return true; +} + bool FuzzConcurrentTaskControllerInterfaceRequestAuth(const uint8_t* data, size_t size) { g_baseFuzzData = data; @@ -546,6 +599,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) OHOS::FuzzConcurrentTaskServiceReportSceneInfo(data, size); OHOS::FuzzConcurrentTaskServiceQueryDeadline(data, size); OHOS::FuzzConcurrentTaskServiceQueryInterval(data, size); + OHOS::FuzzConcurrentTaskServiceSetAudioDeadline(data, size); OHOS::FuzzConcurrentTaskServiceRequestAuth(data, size); OHOS::FuzzConcurrentTaskServiceStopRemoteObject(data, size); @@ -566,6 +620,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) OHOS::FuzzConcurrentTaskClientReportSceneInfo(data, size); OHOS::FuzzConcurrentTaskClientQueryDeadline(data, size); OHOS::FuzzConcurrentTaskClientQueryInterval(data, size); + OHOS::FuzzConcurrentTaskClientSetAudioDeadline(data, size); OHOS::FuzzConcurrentTaskClinetRequestAuth(data, size); OHOS::FuzzConcurrentTaskClientStopRemoteObject(data, size); diff --git a/test/unittest/phone/concurrent_task_client_test.cpp b/test/unittest/phone/concurrent_task_client_test.cpp index 1a7bcc9..66d7deb 100644 --- a/test/unittest/phone/concurrent_task_client_test.cpp +++ b/test/unittest/phone/concurrent_task_client_test.cpp @@ -122,6 +122,19 @@ HWTEST_F(ConcurrentTaskClientTest, QueryDeadlineTest, TestSize.Level1) EXPECT_FALSE(payload.empty()); } +/** + * @tc.name: PushTaskTest + * @tc.desc: Test whether the PushTask interface are normal. + * @tc.type: FUNC +*/ +HWTEST_F(ConcurrentTaskClientTest, SetAudioDeadlineTest, TestSize.Level1) +{ + int queryItem = 0; + IntervalReply queryRs = {87, 657, 357, 214}; + ConcurrentTaskClient::GetInstance().QueryDeadline(queryItem, -1, -1, queryRs); + EXPECT_TRUE(queryRs.rtgId != -1); +} + /** * @tc.name: RequestAuthTest * @tc.desc: Test whether the RequestAuth interface are normal. diff --git a/test/unittest/phone/concurrent_task_controller_interface_test.cpp b/test/unittest/phone/concurrent_task_controller_interface_test.cpp index 232f952..427fcfc 100644 --- a/test/unittest/phone/concurrent_task_controller_interface_test.cpp +++ b/test/unittest/phone/concurrent_task_controller_interface_test.cpp @@ -135,6 +135,26 @@ HWTEST_F(ConcurrentTaskControllerInterfaceTest, QueryIntervalTest, TestSize.Leve EXPECT_FALSE(queInt.inited_); } +/** + * @tc.name: PushTaskTest + * @tc.desc: Test whether the PushTask interface are normal. + * @tc.type: FUNC + */ +HWTEST_F(ConcurrentTaskControllerInterfaceTest, SetAudioDeadlineTest, TestSize.Level1) +{ + TaskControllerInterface queInt; + int queryItem = AUDIO_DDL_CREATE_GRP; + IntervalReply queryRs = {0}; + queInt.SetAudioDeadline(queryItem, -1, -1, queryRs); + queryItem = AUDIO_DDL_ADD_THREAD; + queInt.SetAudioDeadline(queryItem, gettid(), queryRs.rtgId, queryRs); + queryItem = AUDIO_DDL_REMOVE_THREAD; + queInt.SetAudioDeadline(queryItem, gettid(), queryRs.rtgId, queryRs); + queryItem = AUDIO_DDL_DESTROY_GRP; + queInt.SetAudioDeadline(queryItem, gettid(), queryRs.rtgId, queryRs); + EXPECT_FALSE(queInt.inited_); +} + /** * @tc.name: PushTaskTest * @tc.desc: Test whether the PushTask interface are normal. diff --git a/test/unittest/phone/concurrent_task_service_test.cpp b/test/unittest/phone/concurrent_task_service_test.cpp index 3fd40bc..5dc04b3 100644 --- a/test/unittest/phone/concurrent_task_service_test.cpp +++ b/test/unittest/phone/concurrent_task_service_test.cpp @@ -175,5 +175,26 @@ HWTEST_F(ConcurrentTaskServiceTest, IpcToDdlReplyTest, TestSize.Level1) EXPECT_EQ(expectedDdlReply.setStatus, resultDdlReply.setStatus); } + +/** + * @tc.name: SetAudioDeadline + * @tc.desc: Test whether the SetAudioDeadline interface are normal. + * @tc.type: FUNC + */ +HWTEST_F(ConcurrentTaskServiceTest, SetAudioDeadlineTest, TestSize.Level1) +{ + int queryItem = AUDIO_DDL_CREATE_GRP; + IpcIntervalReply IpcQueryRs = { 0 }; + ConcurrentTaskService queInt; + queInt.SetAudioDeadline(queryItem, -1, -1, IpcQueryRs); + EXPECT_NE(IpcQueryRs.rtgId, -1); + queryItem = AUDIO_DDL_ADD_THREAD; + queInt.SetAudioDeadline(queryItem, gettid(), IpcQueryRs.rtgId, IpcQueryRs); + EXPECT_EQ(IpcQueryRs.paramA, 0); + queryItem = AUDIO_DDL_REMOVE_THREAD; + queInt.SetAudioDeadline(queryItem, gettid(), IpcQueryRs.rtgId, IpcQueryRs); + EXPECT_EQ(IpcQueryRs.paramA, 0); +} + } // namespace FFRT_TEST -} // namespace OHOS \ No newline at end of file +} // namespace OHOS diff --git a/test/unittest/phone/func_loader_test.cpp b/test/unittest/phone/func_loader_test.cpp index e90ab8a..463582b 100644 --- a/test/unittest/phone/func_loader_test.cpp +++ b/test/unittest/phone/func_loader_test.cpp @@ -76,6 +76,7 @@ HWTEST_F(FuncLoaderTest, LoadSymbolTest, TestSize.Level1) funcLoader.LoadSymbol("ReportSceneInfo"); funcLoader.LoadSymbol("QueryInterval"); funcLoader.LoadSymbol("QueryDeadline"); + funcLoader.LoadSymbol("SetAudioDeadline"); void* funcSym = funcLoader.LoadSymbol("RequestAuth"); EXPECT_TRUE(funcSym == nullptr); } -- Gitee From edc6208d4b4085a2e071450d298407a7867fa2c8 Mon Sep 17 00:00:00 2001 From: fuxiuwsz Date: Tue, 20 May 2025 11:55:59 +0000 Subject: [PATCH 02/10] update test/unittest/phone/concurrent_task_client_test.cpp. Signed-off-by: fuxiuwsz --- test/unittest/phone/concurrent_task_client_test.cpp | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/test/unittest/phone/concurrent_task_client_test.cpp b/test/unittest/phone/concurrent_task_client_test.cpp index 66d7deb..286fbd1 100644 --- a/test/unittest/phone/concurrent_task_client_test.cpp +++ b/test/unittest/phone/concurrent_task_client_test.cpp @@ -129,10 +129,16 @@ HWTEST_F(ConcurrentTaskClientTest, QueryDeadlineTest, TestSize.Level1) */ HWTEST_F(ConcurrentTaskClientTest, SetAudioDeadlineTest, TestSize.Level1) { - int queryItem = 0; - IntervalReply queryRs = {87, 657, 357, 214}; - ConcurrentTaskClient::GetInstance().QueryDeadline(queryItem, -1, -1, queryRs); + int queryItem = AUDIO_DDL_CREATE_GRP; + IntervalReply queryRs = { 0 }; + ConcurrentTaskClient::GetInstance().SetAudioDeadline(queryItem, -1, -1, queryRs); EXPECT_TRUE(queryRs.rtgId != -1); + queryItem = AUDIO_DDL_ADD_THREAD; + ConcurrentTaskClient::GetInstance().SetAudioDeadline(queryItem, gettid(), queryRs.rtgId, queryRs); + EXPECT_TRUE(queryRs.paramA == 0); + queryItem = AUDIO_DDL_REMOVE_THREAD; + ConcurrentTaskClient::GetInstance().SetAudioDeadline(queryItem, gettid(), queryRs.rtgId, queryRs); + EXPECT_TRUE(queryRs.paramA == 0); } /** -- Gitee From eb5ac44998a7e5201358cfa681a5da202e69c042 Mon Sep 17 00:00:00 2001 From: fuxiuwsz Date: Tue, 20 May 2025 12:24:08 +0000 Subject: [PATCH 03/10] update test/unittest/phone/concurrent_task_controller_interface_test.cpp. Signed-off-by: fuxiuwsz --- .../phone/concurrent_task_controller_interface_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unittest/phone/concurrent_task_controller_interface_test.cpp b/test/unittest/phone/concurrent_task_controller_interface_test.cpp index 427fcfc..4e0bf57 100644 --- a/test/unittest/phone/concurrent_task_controller_interface_test.cpp +++ b/test/unittest/phone/concurrent_task_controller_interface_test.cpp @@ -150,7 +150,7 @@ HWTEST_F(ConcurrentTaskControllerInterfaceTest, SetAudioDeadlineTest, TestSize.L queInt.SetAudioDeadline(queryItem, gettid(), queryRs.rtgId, queryRs); queryItem = AUDIO_DDL_REMOVE_THREAD; queInt.SetAudioDeadline(queryItem, gettid(), queryRs.rtgId, queryRs); - queryItem = AUDIO_DDL_DESTROY_GRP; + queryItem = AUDIO_DDL_DESTORY_GRP; queInt.SetAudioDeadline(queryItem, gettid(), queryRs.rtgId, queryRs); EXPECT_FALSE(queInt.inited_); } -- Gitee From 194b451e8e6ded711ca0277deb04f3713db0fd96 Mon Sep 17 00:00:00 2001 From: fuxiuwsz Date: Wed, 21 May 2025 03:15:25 +0000 Subject: [PATCH 04/10] update interfaces/inner_api/concurrent_task_type.h. Signed-off-by: fuxiuwsz --- interfaces/inner_api/concurrent_task_type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/interfaces/inner_api/concurrent_task_type.h b/interfaces/inner_api/concurrent_task_type.h index 98024a5..d2b718d 100644 --- a/interfaces/inner_api/concurrent_task_type.h +++ b/interfaces/inner_api/concurrent_task_type.h @@ -63,7 +63,7 @@ enum QueryIntervalItem { enum AudioDeadlineType { AUDIO_DDL_CREATE_GRP = 0, - AUDIO_DDL_DESTORY_GRP, + AUDIO_DDL_DESTROY_GRP, AUDIO_DDL_ADD_THREAD, AUDIO_DDL_REMOVE_THREAD, }; -- Gitee From cf527b23686d99c4ca8089cae53fdc4168205725 Mon Sep 17 00:00:00 2001 From: fuxiuwsz Date: Wed, 21 May 2025 03:16:11 +0000 Subject: [PATCH 05/10] update test/unittest/phone/concurrent_task_controller_interface_test.cpp. Signed-off-by: fuxiuwsz --- .../phone/concurrent_task_controller_interface_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unittest/phone/concurrent_task_controller_interface_test.cpp b/test/unittest/phone/concurrent_task_controller_interface_test.cpp index 4e0bf57..427fcfc 100644 --- a/test/unittest/phone/concurrent_task_controller_interface_test.cpp +++ b/test/unittest/phone/concurrent_task_controller_interface_test.cpp @@ -150,7 +150,7 @@ HWTEST_F(ConcurrentTaskControllerInterfaceTest, SetAudioDeadlineTest, TestSize.L queInt.SetAudioDeadline(queryItem, gettid(), queryRs.rtgId, queryRs); queryItem = AUDIO_DDL_REMOVE_THREAD; queInt.SetAudioDeadline(queryItem, gettid(), queryRs.rtgId, queryRs); - queryItem = AUDIO_DDL_DESTORY_GRP; + queryItem = AUDIO_DDL_DESTROY_GRP; queInt.SetAudioDeadline(queryItem, gettid(), queryRs.rtgId, queryRs); EXPECT_FALSE(queInt.inited_); } -- Gitee From e8bf5bd4d7ecd3ad2553c050c1fa937504c5b182 Mon Sep 17 00:00:00 2001 From: fuxiuwsz Date: Wed, 21 May 2025 03:33:17 +0000 Subject: [PATCH 06/10] update frameworks/concurrent_task_client/src/concurrent_task_client.cpp. Signed-off-by: fuxiuwsz --- .../concurrent_task_client/src/concurrent_task_client.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frameworks/concurrent_task_client/src/concurrent_task_client.cpp b/frameworks/concurrent_task_client/src/concurrent_task_client.cpp index ca74e23..41963d6 100644 --- a/frameworks/concurrent_task_client/src/concurrent_task_client.cpp +++ b/frameworks/concurrent_task_client/src/concurrent_task_client.cpp @@ -111,7 +111,7 @@ void ConcurrentTaskClient::QueryDeadline(int queryItem, DeadlineReply& ddlReply, void ConcurrentTaskClient::SetAudioDeadline(int queryItem, int tid, int grpId, IntervalReply& queryRs) { if (TryConnect() != ERR_OK) { - CONCUR_LOGE("QueryInterval connnect fail"); + CONCUR_LOGE("SetAudioDeadline connnect fail"); return; } IpcIntervalReply IpcQueryRs = QueryRsToIpc(queryRs); -- Gitee From 61298839f439009e60dddf41af9991d51ee57871 Mon Sep 17 00:00:00 2001 From: fuxiuwsz Date: Wed, 21 May 2025 03:34:26 +0000 Subject: [PATCH 07/10] update services/src/concurrent_task_controller_interface.cpp. Signed-off-by: fuxiuwsz --- services/src/concurrent_task_controller_interface.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/src/concurrent_task_controller_interface.cpp b/services/src/concurrent_task_controller_interface.cpp index f70cb6c..b9f955a 100644 --- a/services/src/concurrent_task_controller_interface.cpp +++ b/services/src/concurrent_task_controller_interface.cpp @@ -92,7 +92,7 @@ void TaskControllerInterface::QueryDeadline(int queryItem, DeadlineReply& ddlRep void TaskControllerInterface::SetAudioDeadline(int queryItem, int tid, int grpId, IntervalReply& queryRs) { if (!inited_) { - CONCUR_LOGE("[TaskControllerInterface] setAudioDeadline failed, funcLoader_ load func failed"); + CONCUR_LOGE("[TaskControllerInterface] SetAudioDeadline failed, funcLoader_ load func failed"); return; } setAudioDeadlineFunc_(queryItem, tid, grpId, queryRs); -- Gitee From 4649496f20b89e850e71cd7f92d1592d09b59c76 Mon Sep 17 00:00:00 2001 From: fuxiuwsz Date: Wed, 21 May 2025 07:36:08 +0000 Subject: [PATCH 08/10] update test/unittest/phone/concurrent_task_client_test.cpp. Signed-off-by: fuxiuwsz --- test/unittest/phone/concurrent_task_client_test.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/unittest/phone/concurrent_task_client_test.cpp b/test/unittest/phone/concurrent_task_client_test.cpp index 286fbd1..43f43ae 100644 --- a/test/unittest/phone/concurrent_task_client_test.cpp +++ b/test/unittest/phone/concurrent_task_client_test.cpp @@ -139,6 +139,9 @@ HWTEST_F(ConcurrentTaskClientTest, SetAudioDeadlineTest, TestSize.Level1) queryItem = AUDIO_DDL_REMOVE_THREAD; ConcurrentTaskClient::GetInstance().SetAudioDeadline(queryItem, gettid(), queryRs.rtgId, queryRs); EXPECT_TRUE(queryRs.paramA == 0); + queryItem = AUDIO_DDL_DESTROY_GRP; + ConcurrentTaskClient::GetInstance().SetAudioDeadline(queryItem, -1, queryRs.rtgId, queryRs); + EXPECT_TRUE(queryRs.paramA == 0); } /** -- Gitee From 5b84f7ec19665c8c4e5d93a0a70a33706a154e39 Mon Sep 17 00:00:00 2001 From: fuxiuwsz Date: Wed, 21 May 2025 07:37:07 +0000 Subject: [PATCH 09/10] update test/unittest/phone/concurrent_task_service_test.cpp. Signed-off-by: fuxiuwsz --- test/unittest/phone/concurrent_task_service_test.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/unittest/phone/concurrent_task_service_test.cpp b/test/unittest/phone/concurrent_task_service_test.cpp index 5dc04b3..62b320a 100644 --- a/test/unittest/phone/concurrent_task_service_test.cpp +++ b/test/unittest/phone/concurrent_task_service_test.cpp @@ -194,6 +194,9 @@ HWTEST_F(ConcurrentTaskServiceTest, SetAudioDeadlineTest, TestSize.Level1) queryItem = AUDIO_DDL_REMOVE_THREAD; queInt.SetAudioDeadline(queryItem, gettid(), IpcQueryRs.rtgId, IpcQueryRs); EXPECT_EQ(IpcQueryRs.paramA, 0); + queryItem = AUDIO_DDL_DESTROY_GRP; + queInt.SetAudioDeadline(queryItem, -1, IpcQueryRs.rtgId, IpcQueryRs); + EXPECT_EQ(IpcQueryRs.paramA, 0); } } // namespace FFRT_TEST -- Gitee From 132dc56c8d29bf1705298e2d266fd689b30a1503 Mon Sep 17 00:00:00 2001 From: fuxiuwsz Date: Wed, 21 May 2025 07:40:23 +0000 Subject: [PATCH 10/10] update test/unittest/phone/concurrent_task_controller_interface_test.cpp. Signed-off-by: fuxiuwsz --- .../phone/concurrent_task_controller_interface_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unittest/phone/concurrent_task_controller_interface_test.cpp b/test/unittest/phone/concurrent_task_controller_interface_test.cpp index 427fcfc..cb61ce3 100644 --- a/test/unittest/phone/concurrent_task_controller_interface_test.cpp +++ b/test/unittest/phone/concurrent_task_controller_interface_test.cpp @@ -151,7 +151,7 @@ HWTEST_F(ConcurrentTaskControllerInterfaceTest, SetAudioDeadlineTest, TestSize.L queryItem = AUDIO_DDL_REMOVE_THREAD; queInt.SetAudioDeadline(queryItem, gettid(), queryRs.rtgId, queryRs); queryItem = AUDIO_DDL_DESTROY_GRP; - queInt.SetAudioDeadline(queryItem, gettid(), queryRs.rtgId, queryRs); + queInt.SetAudioDeadline(queryItem, -1, queryRs.rtgId, queryRs); EXPECT_FALSE(queInt.inited_); } -- Gitee