From 400fa63b8910a13635febcac60c16ac9a9bf53fc Mon Sep 17 00:00:00 2001
From: wangboo <5417808+wangboa@user.noreply.gitee.com>
Date: Thu, 6 Apr 2023 19:49:34 +0800
Subject: [PATCH] 4-6 code review

---
 README.md                  | 5 ++---
 src/db/filename.rs         | 1 +
 src/table/table_builder.rs | 2 ++
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index f05c752..c45a6e3 100644
--- a/README.md
+++ b/README.md
@@ -84,7 +84,7 @@ RUSTFLAGS='--cfg CORE_DEBUG="false"' cargo build --release
 | table.Iterator(TwoLevelIterator)                                                 | kazeseiriou          | 0%   |
 | table.Iterator(tabletest.KeyConvertingIterator)                                  | kazeseiriou          | 0%   |
 | table.Iterator(dbtest.ModelIter)                                                 | kazeseiriou          | 0%   |
-| table.Iterator(Block::Iter)                                                      | fengyang             | 0%   |
+| table.Iterator(Block::Iter)                                                      | wangboo              | 0%   |
 | IteratorWrapper                                                                  | kazeseiriou          | 0%   |
 | db.MemTable(MemTable, MemTableIterator)                                          | wangboo,tzcyujunyong | 20%  | 
 | db.Builder                                                                       | fengyang             | 85%  |
@@ -94,7 +94,7 @@ RUSTFLAGS='--cfg CORE_DEBUG="false"' cargo build --release
 | table.FilterBlockBuilder                                                         | fengyang             | 30%  |
 | FilterBlock, FilterBlockReader                                                   | fengyang             | 80%  |
 | SSTable                                                                          | fengyang             | 0%   |
-| table.Table                                                                      | peach,tzcyujunyong   |      |
+| table.Table                                                                      | peach,tzcyujunyong   | 30%  |
 | db.leveldb_util                                                                  | wangboo              | 0%   |
 | db.log_format                                                                    | wangboo              | 90%  |
 | db.LogReader                                                                     | wangboo              | 90%  |
@@ -104,7 +104,6 @@ RUSTFLAGS='--cfg CORE_DEBUG="false"' cargo build --release
 | db.VersionEdit(Tag, VersionEdit, FileMetaData)                                   | fengyang             | 20%  |
 | db.VersionSet(Version, LevelFileNumIterator, SaverState)                         | fengyang             | 20%  |
 | WriteBatch                                                                       | tzcyujunyong,wangboo | 50%  |
-| table.table                                                                      |                      | 30%  |
 | db.filename                                                                      |                      |      |
 | <website>                                                                        | 半支烟                  | 40%  |
 
diff --git a/src/db/filename.rs b/src/db/filename.rs
index fb1db13..8c47c9d 100644
--- a/src/db/filename.rs
+++ b/src/db/filename.rs
@@ -1,5 +1,6 @@
 use crate::util::slice::Slice;
 
+// TODo 参考 PathBuf
 pub struct FileName {
 
 }
diff --git a/src/table/table_builder.rs b/src/table/table_builder.rs
index 7e0155e..2d7ed0a 100644
--- a/src/table/table_builder.rs
+++ b/src/table/table_builder.rs
@@ -102,6 +102,8 @@ impl Rep {
         }else {
             filter_block = Some(FilterBlockBuilder::new_with_policy(opt.filter_policy.clone().unwrap()));
         }
+        // TODo if let sytax
+        // let filter_block = opt.filter_policy.map(|e|FilterBlockBuilder::new_with_policy(e.clone().unwrap()));
 
         Self {
             options: opt.clone(),
-- 
Gitee