diff --git a/Fix-KDC-null-deref-on-TGS-inner-body-null-server.patch b/Fix-KDC-null-deref-on-TGS-inner-body-null-server.patch new file mode 100644 index 0000000000000000000000000000000000000000..a03f179f13ae00b59faf8b3b08b873f01c820df4 --- /dev/null +++ b/Fix-KDC-null-deref-on-TGS-inner-body-null-server.patch @@ -0,0 +1,45 @@ +From 0a8dfc380fe3b210662ba1b1d452fcec2f84841b Mon Sep 17 00:00:00 2001 +From: Greg Hudson +Date: Tue, 3 Aug 2021 01:15:27 -0400 +Subject: [PATCH] Fix KDC null deref on TGS inner body null server + +After the KDC decodes a FAST inner body, it does not check for a null +server. Prior to commit 39548a5b17bbda9eeb63625a201cfd19b9de1c5b this +would typically result in an error from krb5_unparse_name(), but with +the addition of get_local_tgt() it results in a null dereference. Add +a null check. + +Reported by Joseph Sutton of Catalyst. + +CVE-2021-37750: + +In MIT krb5 releases 1.14 and later, an authenticated attacker can +cause a null dereference in the KDC by sending a FAST TGS request with +no server field. + +ticket: 9008 (new) +tags: pullup +target_version: 1.19-next +target_version: 1.18-next + +RHEL 7.9 backport of commit: d775c95af7606a51bf79547a94fa52ddd1cb7f49 +--- + src/kdc/do_tgs_req.c | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/src/kdc/do_tgs_req.c b/src/kdc/do_tgs_req.c +index 572a2c363..a9a3beb9d 100644 +--- a/src/kdc/do_tgs_req.c ++++ b/src/kdc/do_tgs_req.c +@@ -204,6 +204,11 @@ process_tgs_req(krb5_kdc_req *request, krb5_data *pkt, + status = "FIND_FAST"; + goto cleanup; + } ++ if (sprinc == NULL) { ++ status = "NULL_SERVER"; ++ errcode = KRB5KDC_ERR_S_PRINCIPAL_UNKNOWN; ++ goto cleanup; ++ } + + errcode = get_local_tgt(kdc_context, &sprinc->realm, header_server, + &local_tgt, &local_tgt_storage); diff --git a/krb5.spec b/krb5.spec index aaaf53e6d993996a043a94b577cd5d823a20b49f..83ca69737f7251cc486998ded8824a2ecc40318b 100644 --- a/krb5.spec +++ b/krb5.spec @@ -1,4 +1,3 @@ -%define anolis_release .0.1 %global WITH_DIRSRV 1 # Set this so that find-lang.sh will recognize the .po files. @@ -13,7 +12,7 @@ Summary: The Kerberos network authentication system Name: krb5 Version: 1.15.1 -Release: 50%{anolis_release}%{?dist} +Release: 51%{?dist} # - Maybe we should explode from the now-available-to-everybody tarball instead? # http://web.mit.edu/kerberos/dist/krb5/1.13/krb5-1.13.2-signed.tar @@ -141,6 +140,7 @@ Patch227: Add-PKINIT-test-case-for-generic-client-cert.patch Patch228: Do-expiration-warnings-for-all-init_creds-APIs.patch Patch229: Remove-vestigial-svr_principal.c-code.patch Patch230: Fix-LDAP-policy-enforcement-of-pw_expiration.patch +Patch231: Fix-KDC-null-deref-on-TGS-inner-body-null-server.patch License: MIT URL: http://web.mit.edu/kerberos/www/ @@ -414,6 +414,7 @@ ONLY by kerberos itself. Do not depend on this package. %patch228 -p1 -b .Do-expiration-warnings-for-all-init_creds-APIs %patch229 -p1 -b .Remove-vestigial-svr_principal.c-code %patch230 -p1 -b .Fix-LDAP-policy-enforcement-of-pw_expiration +%patch231 -p1 -b .Fix-KDC-null-deref-on-TGS-inner-body-null-server ln NOTICE LICENSE @@ -544,7 +545,6 @@ popd %{__cc} -fPIC -shared -o noport.so -Wall -Wextra $RPM_SOURCE_DIR/noport.c %check -%if !0%{?anolis7} # The brew builders for this architecture are wildly unreliable. We # run the full upstream suite separately on all arches anyway - this @@ -571,8 +571,6 @@ make -C src/clients check TMPDIR=%{_tmppath} keyctl session - make -C src/util check TMPDIR=%{_tmppath} %endif # ifarch s390x -%endif - %install [ "$RPM_BUILD_ROOT" != '/' ] && rm -rf -- $RPM_BUILD_ROOT @@ -924,8 +922,9 @@ exit 0 %{_libdir}/libkadm5srv_mit.so.* %changelog -* Fri Oct 22 2021 yangxianzhao - 1.15.1-50.0.1 -- Comment make test because of the build env +* Wed Oct 20 2021 Antonio Torres - 1.15.1-51 +- Fix KDC null deref on TGS inner body null server (CVE-2021-37750) +- Resolves: #1997599 * Mon Apr 06 2020 Robbie Harwood - 1.15.1-50 - Disable smoke tests on s390x and remove sleep