From 65f21c68bd26b381d82c8d5af4161b6d3182cfd3 Mon Sep 17 00:00:00 2001 From: jichao wu Date: Mon, 23 Jun 2025 14:55:07 +0800 Subject: [PATCH] [backport]fix CVE-2025-4673 --- ...t-http-strip-sensitive-proxy-headers.patch | 67 +++++++++++++++++++ golang.spec | 9 ++- 2 files changed, 75 insertions(+), 1 deletion(-) create mode 100644 0129-CVE-2025-4673-net-http-strip-sensitive-proxy-headers.patch diff --git a/0129-CVE-2025-4673-net-http-strip-sensitive-proxy-headers.patch b/0129-CVE-2025-4673-net-http-strip-sensitive-proxy-headers.patch new file mode 100644 index 0000000..9b80a49 --- /dev/null +++ b/0129-CVE-2025-4673-net-http-strip-sensitive-proxy-headers.patch @@ -0,0 +1,67 @@ +From 17aefbea07e9e059cdf66fbd8d66211e1089e2d8 Mon Sep 17 00:00:00 2001 +From: Neal Patel +Date: Wed, 21 May 2025 14:11:44 -0400 +Subject: [PATCH] net/http: strip sensitive proxy headers from redirect + requests + +Similarly to Authentication entries, Proxy-Authentication entries should be stripped to ensure sensitive information is not leaked on redirects outside of the original domain. + +https://fetch.spec.whatwg.org/#authentication-entries + +Thanks to Takeshi Kaneko (GMO Cybersecurity by Ierae, Inc.) for reporting this issue. + +Updates golang/go#73816 +Fixes golang/go#73905 +Fixes CVE-2025-4673 + +Confict: no +Reference:https://go-review.googlesource.com/c/go/+/679255 + +Change-Id: I1615f31977a2fd014fbc12aae43f82692315a6d0 +Reviewed-on: https://go-review.googlesource.com/c/go/+/679255 +LUCI-TryBot-Result: Go LUCI +Reviewed-by: Michael Knyszek +Signed-off-by: jichao wu +--- + src/net/http/client.go | 3 ++- + src/net/http/client_test.go | 3 +++ + 2 files changed, 5 insertions(+), 1 deletion(-) + +diff --git a/src/net/http/client.go b/src/net/http/client.go +index 0e9a23b..289f172 100644 +--- a/src/net/http/client.go ++++ b/src/net/http/client.go +@@ -800,7 +800,8 @@ func (c *Client) makeHeadersCopier(ireq *Request) func(req *Request, stripSensit + for k, vv := range ireqhdr { + sensitive := false + switch CanonicalHeaderKey(k) { +- case "Authorization", "Www-Authenticate", "Cookie", "Cookie2": ++ case "Authorization", "Www-Authenticate", "Cookie", "Cookie2", ++ "Proxy-Authorization", "Proxy-Authenticate": + sensitive = true + } + if !(sensitive && stripSensitiveHeaders) { +diff --git a/src/net/http/client_test.go b/src/net/http/client_test.go +index 97ec66d..34bfeb3 100644 +--- a/src/net/http/client_test.go ++++ b/src/net/http/client_test.go +@@ -1544,6 +1544,8 @@ func testClientStripHeadersOnRepeatedRedirect(t *testing.T, mode testMode) { + if r.Host+r.URL.Path != "a.example.com/" { + if h := r.Header.Get("Authorization"); h != "" { + t.Errorf("on request to %v%v, Authorization=%q, want no header", r.Host, r.URL.Path, h) ++ } else if h := r.Header.Get("Proxy-Authorization"); h != "" { ++ t.Errorf("on request to %v%v, Proxy-Authorization=%q, want no header", r.Host, r.URL.Path, h) + } + } + // Follow a chain of redirects from a to b and back to a. +@@ -1572,6 +1574,7 @@ func testClientStripHeadersOnRepeatedRedirect(t *testing.T, mode testMode) { + req, _ := NewRequest("GET", proto+"://a.example.com/", nil) + req.Header.Add("Cookie", "foo=bar") + req.Header.Add("Authorization", "secretpassword") ++ req.Header.Add("Proxy-Authorization", "secretpassword") + res, err := c.Do(req) + if err != nil { + t.Fatal(err) +-- +2.33.0 + diff --git a/golang.spec b/golang.spec index b4fc90d..76005af 100644 --- a/golang.spec +++ b/golang.spec @@ -58,7 +58,7 @@ Name: golang Version: 1.15.7 -Release: 51 +Release: 52 Summary: The Go Programming Language License: BSD and Public Domain URL: https://golang.org/ @@ -270,6 +270,7 @@ Patch6125: 0125-Backport-encoding-gob-cover-missed-cases-when-checking-ignore.pa Patch6126: 0126-CVE-2024-45341-crypto-x509-properly-check-for-IPv6-h.patch Patch6127: 0127-CVE-2024-45336-net-http-persist-header-stripping-acr.patch Patch6128: 0128-CVE-2025-22870-do-not-mismatch-IPv6-zone-ids-ag.patch +Patch6129: 0129-CVE-2025-4673-net-http-strip-sensitive-proxy-headers.patch Patch9002: 0002-fix-patch-cmd-go-internal-modfetch-do-not-sho.patch @@ -508,6 +509,12 @@ fi %files devel -f go-tests.list -f go-misc.list -f go-src.list %changelog +* Mon Jun 23 2025 wujichao - 1.15.7-52 +- Type:CVE +- CVE:CVE-2025-4673 +- SUG:NA +- DESC:fix CVE-2025-4673 + * Tue Apr 08 2025 wujichao - 1.15.7-51 - Type:CVE - CVE:CVE-2025-22870 -- Gitee