Fix clang build error · Pull Request !729 · src-openEuler/iSulad

### 问题背景
- 本PR基于[这个oEEP](https://gitee.com/openeuler/TC/blob/master/oEEP/oEEP-0003%20LLVM%E5%B9%B3%E8%A1%8C%E5%AE%87%E5%AE%99%E8%AE%A1%E5%88%92--%E5%9F%BA%E4%BA%8ELLVM%E6%8A%80%E6%9C%AF%E6%A0%88%E6%9E%84%E5%BB%BAoE%E8%BD%AF%E4%BB%B6%E5%8C%85.md)，旨在使得软件包可以同时支持GCC和LLVM构建。修复前，clang构建出现报错，无法构建成功。

### 具体报错及修复方案
- 本pr的修改内容与在上游提交的pr：https://gitee.com/openeuler/iSulad/pulls/2500 同步。
1. `error: 'cri_stream_server_url' has C-linkage specified, but returns user-defined type 'url::URLDatum' which is incompatible with C`：将cri_stream_server_url移出extern C范围

对应报错：

```
   In file included from /home/abuild/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/connect/grpc/cri/cri_service.cc:19:
   /home/abuild/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/streams/stream_server.h:30:15: error: 'cri_stream_server_url' has C-linkage specified, but returns user-defined type 'url::URLDatum' which is incompatible with C [-Werror,-Wreturn-type-c-linkage]
      30 | url::URLDatum cri_stream_server_url(void);
         |               ^
   1 error generated.
   ```

2. `error: unqualified call to 'std::move'`：将一些`move`改为`std::move`，共8处，涉及5个文件

```
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1/v1_cri_image_manager_service_impl.cc:152:26: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
     152 |         images.push_back(move(image));
         |                          ^
         |                          std::
   ...
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1/v1_cri_container_manager_service.cc:693:30: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
     693 |         containers.push_back(move(container));
         |                              ^
         |                              std::
   ...
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1/v1_cri_pod_sandbox_manager_service.cc:1173:16: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
    1173 |     podStats = move(podStatsPtr);
         |                ^
         |                std::
   ...
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1/v1_cri_pod_sandbox_manager_service.cc:1323:29: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
    1323 |         podsStats.push_back(move(podStats));
         |                             ^
         |                             std::
   ...
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1alpha/cri_image_manager_service_impl.cc:152:26:
    error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
   ...
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1/v1_cri_container_manager_service.cc:693:30: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
   ...
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1/v1_cri_pod_sandbox_manager_service.cc:1173:16:
    error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
   ...
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1/v1_cri_pod_sandbox_manager_service.cc:1323:29:
    error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
   ...
   ```

3. `error: suggest braces around initialization of subobject `：将初始化中的`{ 0 }`改为`{{ 0 }}`

```
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1/v1_cri_pod_sandbox_manager_service.cc:1182:38: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
    1182 |     cgroup_metrics_t cgroupMetrics { 0 };
         |                                      ^
         |                                      {}
   ...
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1alpha/cri_pod_sandbox_manager_service.cc:1574:38: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
    1574 |     cgroup_metrics_t cgroupMetrics { 0 };
         |                                      ^
         |                                      {}
   ```

4. `error: format string is not a string literal (potentially insecure)`：添加两处使用`%s`进行格式化

```
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1/v1_cri_pod_sandbox_manager_service.cc:508:15: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
     508 |         ERROR(tmp_errmsg.c_str());
         |               ^~~~~~~~~~~~~~~~~~
         /usr/include/isula_libutils/log.h:356:22: note: expanded from macro 'ERROR'
     356 |         LXC_ERROR(&locinfo, format, ##__VA_ARGS__);                     \
         |                             ^~~~~~
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1/v1_cri_pod_sandbox_manager_service.cc:508:15: note: treat the string as an argument to avoid this
     508 |         ERROR(tmp_errmsg.c_str());
         |               ^
         |               "%s", 
   /usr/include/isula_libutils/log.h:356:22: note: expanded from macro 'ERROR'
     356 |         LXC_ERROR(&locinfo, format, ##__VA_ARGS__);                     \
         |                             ^
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1/v1_cri_pod_sandbox_manager_service.cc:523:19: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
     523 |             ERROR(list_response->errmsg);
         |                   ^~~~~~~~~~~~~~~~~~~~~
   /usr/include/isula_libutils/log.h:356:22: note: expanded from macro 'ERROR'
     356 |         LXC_ERROR(&locinfo, format, ##__VA_ARGS__);                     \
         |                             ^~~~~~
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1/v1_cri_pod_sandbox_manager_service.cc:523:19: note: treat the string as an argument to avoid this
     523 |             ERROR(list_response->errmsg);
         |                   ^
         |                   "%s", 
   /usr/include/isula_libutils/log.h:356:22: note: expanded from macro 'ERROR'
     356 |         LXC_ERROR(&locinfo, format, ##__VA_ARGS__);                     \
         |                             ^
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1/v1_cri_pod_sandbox_manager_service.cc:523:19: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
     523 |             ERROR(list_response->errmsg);
         |                   ^~~~~~~~~~~~~~~~~~~~~
   /usr/include/isula_libutils/log.h:356:22: note: expanded from macro 'ERROR'
     356 |         LXC_ERROR(&locinfo, format, ##__VA_ARGS__);                     \
         |                             ^~~~~~
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1/v1_cri_pod_sandbox_manager_service.cc:523:19: note: treat the string as an argument to avoid this
     523 |             ERROR(list_response->errmsg);
         |                   ^
         |                   "%s", 
   /usr/include/isula_libutils/log.h:356:22: note: expanded from macro 'ERROR'
     356 |         LXC_ERROR(&locinfo, format, ##__VA_ARGS__);                     \
         |                             ^
   ```

5. `error: cannot pass non-trivial object of type 'std::string' (aka 'basic_string<char>') to variadic function`：两处加入`.c_str()`调用

```
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/common/cri/cri_helpers.cc:528:92: error: cannot pass non-trivial object of type 'std::string' (aka 'basic_string<char>') to variadic function; expected type from format string was 'char *' [-Wnon-pod-varargs]
     528 |             SYSERROR("Failed to remove container %s log symlink %s.", containerID.c_str(), path);
         |                                                                 ~~                         ^~~~
   /usr/include/isula_libutils/log.h:414:32: note: expanded from macro 'SYSERROR'
     414 |                 ERROR("%s - " format, ptr, ##__VA_ARGS__); \
         |                               ~~~~~~         ^~~~~~~~~~~
   /usr/include/isula_libutils/log.h:356:32: note: expanded from macro 'ERROR'
     356 |         LXC_ERROR(&locinfo, format, ##__VA_ARGS__);                     \
         |                             ~~~~~~    ^~~~~~~~~~~
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/common/cri/cri_helpers.cc:528:92: note: did you mean to call the c_str() method?
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/common/cri/cri_helpers.cc:529:96: error: cannot pass object of non-trivial type 'std::string' (aka 'basic_string<char>') through variadic method; call will abort at runtime [-Wnon-pod-varargs]
     529 |             error.Errorf("Failed to remove container %s log symlink %s.", containerID.c_str(), path);
         |                                                                                                ^
   ```

6. `error: moving a temporary object prevents copy elision`：将此处的`std::move`移除

```
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/sandbox/sandbox_ops.cc:75:19: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
      75 |     params.spec = std::move(std::unique_ptr<std::string>(new std::string(oci_spec)));
         |                   ^
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/sandbox/sandbox_ops.cc:75:19: note: remove std::move call here
      75 |     params.spec = std::move(std::unique_ptr<std::string>(new std::string(oci_spec)));
         |                   ^~~~~~~~~~~
   ```

7. `error: more '%' conversions than data arguments`：移除多余的`%s`

```
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/sandbox/sandbox.cc:850:41: error: more '%' conversions than data arguments [-Werror,-Wformat-insufficient-args]
     850 |         SYSERROR("Failed to write file %s");
         |                                        ~^
   /usr/include/isula_libutils/log.h:414:17: note: expanded from macro 'SYSERROR'
     414 |                 ERROR("%s - " format, ptr, ##__VA_ARGS__); \
         |                               ^~~~~~
   /usr/include/isula_libutils/log.h:356:22: note: expanded from macro 'ERROR'
     356 |         LXC_ERROR(&locinfo, format, ##__VA_ARGS__);                     \
         |                             ^~~~~~
   ```

8. `error: private field 'm_enablePodEvents' is not used`：这是笔者比较不确定的一处修改，改法参考StackOverflow的这个帖子https://stackoverflow.com/a/48192493，在声明之前添加了[[maybe_unused]]，由于确实能解决问题所以就直接采用了，并没有深究。

```
   /root/rpmbuild/BUILD/iSulad-v2.1.5/src/daemon/entry/cri/v1/v1_cri_runtime_service_impl.h:107:10: error: private field 'm_enablePodEvents' is not used [-Werror,-Wunused-private-field]
     107 |     bool m_enablePodEvents;
         |          ^
   1 error generated.
   ```
### 验证工程
- 线上OBS平台clang构建成功，验证工程：https://build.tarsier-infra.isrc.ac.cn/package/show/home:yy:branches:Mega-LLVM:24.03/iSulad

src-openEuler/iSulad .gitee-modal { width: 500px !important; }

搜索帮助

src-openEuler/iSulad