From 4968c801b1438686a9cb5f4c01a5133bc8b3426b Mon Sep 17 00:00:00 2001 From: liaosirui Date: Sat, 19 Sep 2020 10:33:25 +0800 Subject: [PATCH] revert version: Always apply GRALLOC_USAGE_SW_READ_OFTEN option for gralloc_lock --- libs/gui/Surface.cpp | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/libs/gui/Surface.cpp b/libs/gui/Surface.cpp index d9e6cf00a..cabab4d54 100644 --- a/libs/gui/Surface.cpp +++ b/libs/gui/Surface.cpp @@ -1234,21 +1234,13 @@ status_t Surface::lock( return INVALID_OPERATION; } - uint32_t lockUsage; - if (inOutDirtyBounds) { - lockUsage = GRALLOC_USAGE_SW_READ_OFTEN | GRALLOC_USAGE_SW_WRITE_OFTEN; - } else { - lockUsage = GRALLOC_USAGE_SW_WRITE_OFTEN; - } - - if (!mConnectedToCpu) { int err = Surface::connect(NATIVE_WINDOW_API_CPU); if (err) { return err; } // we're intending to do software rendering from this point - setUsage(lockUsage); + setUsage(GRALLOC_USAGE_SW_READ_OFTEN | GRALLOC_USAGE_SW_WRITE_OFTEN); } ANativeWindowBuffer* out; @@ -1308,7 +1300,8 @@ status_t Surface::lock( void* vaddr; status_t res = backBuffer->lockAsync( - lockUsage, newDirtyRegion.bounds(), &vaddr, fenceFd); + GRALLOC_USAGE_SW_READ_OFTEN | GRALLOC_USAGE_SW_WRITE_OFTEN, + newDirtyRegion.bounds(), &vaddr, fenceFd); ALOGW_IF(res, "failed locking buffer (handle = %p)", backBuffer->handle); -- Gitee