From b2ca9e3266a228c3f865c83dcd9b15abf5d18a54 Mon Sep 17 00:00:00 2001 From: ZhaoPengyuan Date: Wed, 30 Sep 2020 18:02:27 +0800 Subject: [PATCH] egl:codereview remove magic num and meaningless space --- opengl/libs/EGL/eglApi.cpp | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/opengl/libs/EGL/eglApi.cpp b/opengl/libs/EGL/eglApi.cpp index c7f7e9253..b172f80d0 100644 --- a/opengl/libs/EGL/eglApi.cpp +++ b/opengl/libs/EGL/eglApi.cpp @@ -362,12 +362,10 @@ EGLBoolean eglChooseConfig( EGLDisplay dpy, const EGLint *attrib_list, if (attrib_list) { while (temp_index % 2 == 1 || attrib_list[temp_index] != EGL_NONE) { - #ifdef EGL_Config_Debug ALOGE("index:%d, value:%d", temp_index, attrib_list[temp_index]); #endif - - ++ temp_index; + ++temp_index; } } @@ -721,17 +719,15 @@ EGLContext eglCreateContext(EGLDisplay dpy, EGLConfig config, clearError(); #ifdef EGL_Config_Debug - int attribs[] = {EGL_ALPHA_SIZE, EGL_ALPHA_MASK_SIZE, EGL_BLUE_SIZE, EGL_BUFFER_SIZE, EGL_COLOR_BUFFER_TYPE, EGL_CONFIG_CAVEAT, EGL_CONFIG_ID, EGL_DEPTH_SIZE, EGL_GREEN_SIZE, EGL_LEVEL, EGL_LUMINANCE_SIZE, EGL_MAX_PBUFFER_WIDTH, EGL_MAX_PBUFFER_HEIGHT, EGL_MAX_PBUFFER_PIXELS, EGL_NATIVE_RENDERABLE, EGL_NATIVE_VISUAL_ID, EGL_NATIVE_VISUAL_TYPE, EGL_RED_SIZE, EGL_RENDERABLE_TYPE, EGL_SAMPLE_BUFFERS, EGL_SAMPLES, EGL_STENCIL_SIZE, EGL_SURFACE_TYPE, EGL_TRANSPARENT_TYPE, EGL_TRANSPARENT_RED_VALUE, EGL_TRANSPARENT_GREEN_VALUE, EGL_TRANSPARENT_BLUE_VALUE}; char* attrib_names[] = {"EGL_ALPHA_SIZE", "EGL_ALPHA_MASK_SIZE", "EGL_BLUE_SIZE", "EGL_BUFFER_SIZE", "EGL_COLOR_BUFFER_TYPE", "EGL_CONFIG_CAVEAT", "EGL_CONFIG_ID", "EGL_DEPTH_SIZE", "EGL_GREEN_SIZE", "EGL_LEVEL", "EGL_LUMINANCE_SIZE", "EGL_MAX_PBUFFER_WIDTH", "EGL_MAX_PBUFFER_HEIGHT", "EGL_MAX_PBUFFER_PIXELS", "EGL_NATIVE_RENDERABLE", "EGL_NATIVE_VISUAL_ID", "EGL_NATIVE_VISUAL_TYPE", "EGL_RED_SIZE", "EGL_RENDERABLE_TYPE", "EGL_SAMPLE_BUFFERS", "EGL_SAMPLES", "EGL_STENCIL_SIZE", "EGL_SURFACE_TYPE", "EGL_TRANSPARENT_TYPE", "EGL_TRANSPARENT_RED_VALUE", "EGL_TRANSPARENT_GREEN_VALUE", "EGL_TRANSPARENT_BLUE_VALUE" }; - for (int i = 0; i < 27; i++) { + for (int i = 0; i < (sizeof(attribs) / sizeof(int)); i++) { int colorBufferSize = 0; eglGetConfigAttrib(dpy, config, attribs[i], &colorBufferSize); ALOGE("eglCreateContext configs, %s: %d", attrib_names[i], colorBufferSize); } ALOGE("eglCreateContext configs done"); - #endif size_t temp_index = 0; @@ -741,7 +737,7 @@ EGLContext eglCreateContext(EGLDisplay dpy, EGLConfig config, #ifdef EGL_Config_Debug ALOGE("index:%d, value:%d", temp_index, attrib_list[temp_index]); #endif - ++ temp_index; + ++temp_index; } } -- Gitee