From 4c6a0979e3aa0d809cdc3614570c8d20465129aa Mon Sep 17 00:00:00 2001 From: Chen Qun Date: Mon, 17 May 2021 14:24:49 +0800 Subject: [PATCH 1/3] scsi: mptsas: dequeue request object in case of an error Fix CVE-2021-3392 While processing SCSI i/o requests in mptsas_process_scsi_io_request(), the Megaraid emulator appends new MPTSASRequest object 'req' to the 's->pending' queue. In case of an error, this same object gets dequeued in mptsas_free_request() only if SCSIRequest object 'req->sreq' is initialised. This may lead to a use-after-free issue. Unconditionally dequeue 'req' object from 's->pending' to avoid it. Fixes: CVE-2021-3392 Buglink: https://bugs.launchpad.net/qemu/+bug/1914236 Reported-by: Cheolwoo Myung Signed-off-by: Prasad J Pandit Signed-off-by: Jiajie Li --- ...eue-request-object-in-case-of-an-err.patch | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 scsi-mptsas-dequeue-request-object-in-case-of-an-err.patch diff --git a/scsi-mptsas-dequeue-request-object-in-case-of-an-err.patch b/scsi-mptsas-dequeue-request-object-in-case-of-an-err.patch new file mode 100644 index 00000000..610b9d7f --- /dev/null +++ b/scsi-mptsas-dequeue-request-object-in-case-of-an-err.patch @@ -0,0 +1,41 @@ +From 27b68c47d739a3c4e5ece95ab002ee852103e11f Mon Sep 17 00:00:00 2001 +From: Prasad J Pandit +Date: Mon, 17 May 2021 14:24:49 +0800 +Subject: [PATCH] scsi: mptsas: dequeue request object in case of an error + +Fix CVE-2021-3392 + +While processing SCSI i/o requests in mptsas_process_scsi_io_request(), +the Megaraid emulator appends new MPTSASRequest object 'req' to +the 's->pending' queue. In case of an error, this same object gets +dequeued in mptsas_free_request() only if SCSIRequest object +'req->sreq' is initialised. This may lead to a use-after-free issue. +Unconditionally dequeue 'req' object from 's->pending' to avoid it. + +Fixes: CVE-2021-3392 +Buglink: https://bugs.launchpad.net/qemu/+bug/1914236 +Reported-by: Cheolwoo Myung +Signed-off-by: Prasad J Pandit + +Signed-off-by: Jiajie Li +--- + hw/scsi/mptsas.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c +index 3f94d5ab55..4d23f045d7 100644 +--- a/hw/scsi/mptsas.c ++++ b/hw/scsi/mptsas.c +@@ -259,8 +259,8 @@ static void mptsas_free_request(MPTSASRequest *req) + req->sreq->hba_private = NULL; + scsi_req_unref(req->sreq); + req->sreq = NULL; +- QTAILQ_REMOVE(&s->pending, req, next); + } ++ QTAILQ_REMOVE(&s->pending, req, next); + qemu_sglist_destroy(&req->qsg); + g_free(req); + } +-- +2.27.0 + -- Gitee From 2e25b7c7ff3e2d7b458d21e600102d6f53ae16ea Mon Sep 17 00:00:00 2001 From: Chen Qun Date: Wed, 19 May 2021 11:27:11 +0800 Subject: [PATCH 2/3] spec: Update patch and changelog with !113 fix CVE-2021-3392 #I3E5MB !113 scsi: mptsas: dequeue request object in case of an error Signed-off-by: Chen Qun --- qemu.spec | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/qemu.spec b/qemu.spec index 320a6eaa..37c11dc5 100644 --- a/qemu.spec +++ b/qemu.spec @@ -286,6 +286,7 @@ Patch0273: migration-fix-memory-leak-in-qmp_migrate_set_paramet.patch Patch0274: migration-tls-fix-inverted-semantics-in-multifd_chan.patch Patch0275: migration-tls-add-error-handling-in-multifd_tls_hand.patch Patch0276: arm-cpu-Fixed-function-undefined-error-at-compile-ti.patch +Patch0277: scsi-mptsas-dequeue-request-object-in-case-of-an-err.patch BuildRequires: flex BuildRequires: bison @@ -674,6 +675,9 @@ getent passwd qemu >/dev/null || \ %endif %changelog +* Wed May 19 2021 Chen Qun +- scsi: mptsas: dequeue request object in case of an error + * Mon May 17 2021 Huawei Technologies Co., Ltd - add strip for block-iscsi.so, block-rbd.so and block-ssh.so. * Wed May 12 2021 Chen Qun -- Gitee From bad887cfba4153518926bfcfd21114f389aa7ba0 Mon Sep 17 00:00:00 2001 From: Chen Qun Date: Wed, 19 May 2021 11:27:24 +0800 Subject: [PATCH 3/3] spec: Update release version with !113 increase release verison by one Signed-off-by: Chen Qun --- qemu.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu.spec b/qemu.spec index 37c11dc5..87b6a03b 100644 --- a/qemu.spec +++ b/qemu.spec @@ -1,6 +1,6 @@ Name: qemu Version: 4.1.0 -Release: 44 +Release: 45 Epoch: 2 Summary: QEMU is a generic and open source machine emulator and virtualizer License: GPLv2 and BSD and MIT and CC-BY-SA-4.0 -- Gitee