From 50a02c8eedef54d462ac126d9a43b34abdcf28c2 Mon Sep 17 00:00:00 2001 From: Chen Qun Date: Thu, 22 Jul 2021 09:27:56 +0200 Subject: [PATCH 1/3] usbredir: fix free call MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit data might point into the middle of a larger buffer, there is a separate free_on_destroy pointer passed into bufp_alloc() to handle that. It is only used in the normal workflow though, not when dropping packets due to the queue being full. Fix that. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/491 Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-Id: <20210722072756.647673-1-kraxel@redhat.com> Signed-off-by: imxcc --- usbredir-fix-free-call.patch | 38 ++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 usbredir-fix-free-call.patch diff --git a/usbredir-fix-free-call.patch b/usbredir-fix-free-call.patch new file mode 100644 index 0000000..c988efc --- /dev/null +++ b/usbredir-fix-free-call.patch @@ -0,0 +1,38 @@ +From 17cebe6dfb41f54a71ee7f49e7ad27557ef4183f Mon Sep 17 00:00:00 2001 +From: Gerd Hoffmann +Date: Thu, 22 Jul 2021 09:27:56 +0200 +Subject: [PATCH] usbredir: fix free call +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +data might point into the middle of a larger buffer, there is a separate +free_on_destroy pointer passed into bufp_alloc() to handle that. It is +only used in the normal workflow though, not when dropping packets due +to the queue being full. Fix that. + +Resolves: https://gitlab.com/qemu-project/qemu/-/issues/491 +Signed-off-by: Gerd Hoffmann +Reviewed-by: Marc-André Lureau +Message-Id: <20210722072756.647673-1-kraxel@redhat.com> +Signed-off-by: imxcc +--- + hw/usb/redirect.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c +index 998fc6e4b0..87338f76da 100644 +--- a/hw/usb/redirect.c ++++ b/hw/usb/redirect.c +@@ -459,7 +459,7 @@ static int bufp_alloc(USBRedirDevice *dev, uint8_t *data, uint16_t len, + if (dev->endpoint[EP2I(ep)].bufpq_dropping_packets) { + if (dev->endpoint[EP2I(ep)].bufpq_size > + dev->endpoint[EP2I(ep)].bufpq_target_size) { +- free(data); ++ free(free_on_destroy); + return -1; + } + dev->endpoint[EP2I(ep)].bufpq_dropping_packets = 0; +-- +2.27.0 + -- Gitee From b8f3a23789bc826bf121aebfe242cb5b014abb5d Mon Sep 17 00:00:00 2001 From: Chen Qun Date: Mon, 16 Aug 2021 11:29:39 +0800 Subject: [PATCH 2/3] spec: Update patch and changelog with !187 fix CVE-2021-3682 #I45H4H !187 usbredir: fix free call Signed-off-by: Chen Qun --- qemu.spec | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/qemu.spec b/qemu.spec index 2213052..1a2412d 100644 --- a/qemu.spec +++ b/qemu.spec @@ -298,6 +298,7 @@ Patch0285: target-i386-Add-new-bit-definitions-of-MSR_IA32_ARCH.patch Patch0286: target-i386-Add-missed-security-features-to-Cooperla.patch Patch0287: target-i386-add-PSCHANGE_NO-bit-for-the-ARCH_CAPABIL.patch Patch0288: target-i386-Export-TAA_NO-bit-to-guests.patch +Patch0289: usbredir-fix-free-call.patch BuildRequires: flex BuildRequires: bison @@ -695,6 +696,9 @@ getent passwd qemu >/dev/null || \ %endif %changelog +* Mon Aug 16 2021 Chen Qun +- usbredir: fix free call + * Thu Jul 22 2021 Jiajie Li - add qemu-block-curl package - add qemu-block-curl requirement for qemu. -- Gitee From 90cd66793cc906f78f8e86fc946b4f112e3daf1b Mon Sep 17 00:00:00 2001 From: Chen Qun Date: Mon, 16 Aug 2021 11:30:12 +0800 Subject: [PATCH 3/3] spec: Update release version with !187 increase release verison by one Signed-off-by: Chen Qun --- qemu.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu.spec b/qemu.spec index 1a2412d..3af25b3 100644 --- a/qemu.spec +++ b/qemu.spec @@ -1,6 +1,6 @@ Name: qemu Version: 4.1.0 -Release: 53 +Release: 54 Epoch: 2 Summary: QEMU is a generic and open source machine emulator and virtualizer License: GPLv2 and BSD and MIT and CC-BY-SA-4.0 -- Gitee